summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-18 18:33:35 +0000
committerphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-18 18:33:35 +0000
commit4864ac8df9f2d34718c0d693040d1354dfb7f0eb (patch)
tree7c982bdafeedea8446791fc4de2ac1d4bd841cef
parent3b78284325c04007a09ba8b47ac2980997e39e1d (diff)
downloadchromium_src-4864ac8df9f2d34718c0d693040d1354dfb7f0eb.zip
chromium_src-4864ac8df9f2d34718c0d693040d1354dfb7f0eb.tar.gz
chromium_src-4864ac8df9f2d34718c0d693040d1354dfb7f0eb.tar.bz2
GTTF: Make URLFetcherProtectTestPassedThrough fail fast.
We should not hang entire unit_tests in case of failure. TEST=unit_tests BUG=none Review URL: http://codereview.chromium.org/3104015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56561 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/common/net/url_fetcher_unittest.cc7
1 files changed, 4 insertions, 3 deletions
diff --git a/chrome/common/net/url_fetcher_unittest.cc b/chrome/common/net/url_fetcher_unittest.cc
index a2fa09e..c5da182 100644
--- a/chrome/common/net/url_fetcher_unittest.cc
+++ b/chrome/common/net/url_fetcher_unittest.cc
@@ -358,12 +358,13 @@ void URLFetcherProtectTestPassedThrough::OnURLFetchComplete(
// Check that suggested back off time is bigger than 0.
EXPECT_GT(fetcher_->backoff_delay().InMicroseconds(), 0);
EXPECT_FALSE(data.empty());
- delete fetcher_;
- io_message_loop_proxy()->PostTask(FROM_HERE, new MessageLoop::QuitTask());
} else {
// We should not get here!
- FAIL();
+ ADD_FAILURE();
}
+
+ delete fetcher_;
+ io_message_loop_proxy()->PostTask(FROM_HERE, new MessageLoop::QuitTask());
}