summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-04-08 19:42:21 +0000
committerrsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-04-08 19:42:21 +0000
commit581c20b919145eb5c544548e9ec60314562515f4 (patch)
treec4020b1537d7b8bc4d05d5ed87eb99121f285919
parent634969a2c2c2c77e23e414f7bcb1716754a1e8cf (diff)
downloadchromium_src-581c20b919145eb5c544548e9ec60314562515f4.zip
chromium_src-581c20b919145eb5c544548e9ec60314562515f4.tar.gz
chromium_src-581c20b919145eb5c544548e9ec60314562515f4.tar.bz2
Mark some sync tests as flaky.
These tests are flaky on the chromium trybots, but work just fine on the chromium buildbots. Marking them as flaky so that we still retain test coverage on the main waterfall. TBR=phajdan.jr@chromium.org BUG=78840 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6826007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80968 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/test/live_sync/single_client_live_passwords_sync_test.cc3
-rw-r--r--chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc3
-rw-r--r--chrome/test/live_sync/two_client_live_passwords_sync_test.cc20
3 files changed, 17 insertions, 9 deletions
diff --git a/chrome/test/live_sync/single_client_live_passwords_sync_test.cc b/chrome/test/live_sync/single_client_live_passwords_sync_test.cc
index ba56e02..149763d 100644
--- a/chrome/test/live_sync/single_client_live_passwords_sync_test.cc
+++ b/chrome/test/live_sync/single_client_live_passwords_sync_test.cc
@@ -8,7 +8,8 @@
using webkit_glue::PasswordForm;
-IN_PROC_BROWSER_TEST_F(SingleClientLivePasswordsSyncTest, Sanity) {
+// TODO(rsimha): See http://crbug.com/78840.
+IN_PROC_BROWSER_TEST_F(SingleClientLivePasswordsSyncTest, FLAKY_Sanity) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
PasswordForm form = CreateTestPasswordForm(0);
diff --git a/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc b/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
index 81cbeb9..ee7d561 100644
--- a/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
+++ b/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc
@@ -123,8 +123,9 @@ IN_PROC_BROWSER_TEST_F(TwoClientLiveBookmarksSyncTest,
}
// Test Scribe ID - 370489.
+// TODO(rsimha): See http://crbug.com/78840.
IN_PROC_BROWSER_TEST_F(TwoClientLiveBookmarksSyncTest,
- SC_AddFirstBMWithFavicon) {
+ FLAKY_SC_AddFirstBMWithFavicon) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AllModelsMatchVerifier());
diff --git a/chrome/test/live_sync/two_client_live_passwords_sync_test.cc b/chrome/test/live_sync/two_client_live_passwords_sync_test.cc
index 752c312..810741a 100644
--- a/chrome/test/live_sync/two_client_live_passwords_sync_test.cc
+++ b/chrome/test/live_sync/two_client_live_passwords_sync_test.cc
@@ -12,7 +12,8 @@ using webkit_glue::PasswordForm;
static const char* kValidPassphrase = "passphrase!";
-IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, Add) {
+// TODO(rsimha): See http://crbug.com/78840.
+IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, FLAKY_Add) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
@@ -35,7 +36,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, Add) {
ASSERT_TRUE(ContainsSamePasswordForms(verifier_forms, forms1));
}
-IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, Race) {
+// TODO(rsimha): See http://crbug.com/78840.
+IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, FLAKY_Race) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
PasswordForm form0 = CreateTestPasswordForm(0);
@@ -58,7 +60,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, Race) {
ASSERT_TRUE(ContainsSamePasswordForms(forms0, forms1));
}
-IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, SetPassphrase) {
+// TODO(rsimha): See http://crbug.com/78840.
+IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, FLAKY_SetPassphrase) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
SetPassphrase(0, kValidPassphrase, true);
@@ -69,8 +72,9 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, SetPassphrase) {
ASSERT_TRUE(GetClient(1)->AwaitPassphraseAccepted());
}
+// TODO(rsimha): See http://crbug.com/78840.
IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest,
- SetPassphraseAndAddPassword) {
+ FLAKY_SetPassphraseAndAddPassword) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
SetPassphrase(0, kValidPassphrase, true);
@@ -94,9 +98,9 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest,
ASSERT_EQ(1U, forms1.size());
}
-// TODO(rsimha): This test fails occasionally -- see http://crbug.com/77956.
+// TODO(rsimha): See http://crbug.com/78840.
IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest,
- FAILS_SetPassphraseAndThenSetupSync) {
+ FLAKY_SetPassphraseAndThenSetupSync) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
ASSERT_TRUE(GetClient(0)->SetupSync());
@@ -109,7 +113,9 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest,
ASSERT_TRUE(GetClient(1)->AwaitPassphraseAccepted());
}
-IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, SetPassphraseTwice) {
+// TODO(rsimha): See http://crbug.com/78840.
+IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest,
+ FLAKY_SetPassphraseTwice) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
SetPassphrase(0, kValidPassphrase, true);