summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoralokp@chromium.org <alokp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-06-13 19:13:23 +0000
committeralokp@chromium.org <alokp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-06-13 19:13:23 +0000
commitbae35812af03db00e663a26bea49af2477b8a688 (patch)
treef516e1aa9553ea7ff8075117bf1544ca29e374db
parent36b537fb02505fdd385d86791e5b184eb9555566 (diff)
downloadchromium_src-bae35812af03db00e663a26bea49af2477b8a688.zip
chromium_src-bae35812af03db00e663a26bea49af2477b8a688.tar.gz
chromium_src-bae35812af03db00e663a26bea49af2477b8a688.tar.bz2
Disabled painting transpaent windowless NPAPI plugins when doing accelerated drawing. With accelerated canvas, we do not have a bitmap that can be provided to the plugin for compositing.
Added a TODO and warning log. Review URL: http://codereview.chromium.org/7044116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88870 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--content/renderer/webplugin_delegate_proxy.cc9
1 files changed, 9 insertions, 0 deletions
diff --git a/content/renderer/webplugin_delegate_proxy.cc b/content/renderer/webplugin_delegate_proxy.cc
index c91c2d1..9ac779a 100644
--- a/content/renderer/webplugin_delegate_proxy.cc
+++ b/content/renderer/webplugin_delegate_proxy.cc
@@ -728,6 +728,15 @@ void WebPluginDelegateProxy::Paint(WebKit::WebCanvas* canvas,
// We're using the native OS APIs from here on out.
#if WEBKIT_USING_SKIA
+ if (!skia::SupportsPlatformPaint(canvas)) {
+ // TODO(alokp): Implement this path.
+ // This block will only get hit with --enable-accelerated-drawing flag.
+ // With accelerated canvas, we do not have a bitmap that can be provided
+ // to the plugin for compositing. We may have to implement a solution
+ // described in crbug.com/12586.
+ DLOG(WARNING) << "Could not paint plugin";
+ return;
+ }
skia::ScopedPlatformPaint scoped_platform_paint(canvas);
gfx::NativeDrawingContext context =
scoped_platform_paint.GetPlatformSurface();