diff options
| author | jennb@chromium.org <jennb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-22 22:44:16 +0000 |
|---|---|---|
| committer | jennb@chromium.org <jennb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-22 22:44:16 +0000 |
| commit | 05a1a8b829ab1795aae0666ce0b4dbf23f3bba59 (patch) | |
| tree | b55b82edcfcc94d54f441a33fadffad5bc533e20 | |
| parent | 87e84f965aecf37c64e8404b9186fad04540688e (diff) | |
| download | chromium_src-05a1a8b829ab1795aae0666ce0b4dbf23f3bba59.zip chromium_src-05a1a8b829ab1795aae0666ce0b4dbf23f3bba59.tar.gz chromium_src-05a1a8b829ab1795aae0666ce0b4dbf23f3bba59.tar.bz2 | |
Fix valgrind mem leak in AppCacheUpdateJobTest and remove suppression.
TEST=valgrind test_shell_tests
BUG=none
Review URL: http://codereview.chromium.org/501175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35179 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 26 | ||||
| -rw-r--r-- | webkit/appcache/appcache_update_job_unittest.cc | 4 |
2 files changed, 0 insertions, 30 deletions
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index f3dbbb9..cd46b9a 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -1947,29 +1947,3 @@ fun:_ZN11MessageLoop11RunInternalEv fun:_ZN11MessageLoop10RunHandlerEv } -{ - bug_jennb_1 - Memcheck:Leak - fun:_Znw* - fun:_ZN8appcache21AppCacheUpdateJobTest22IfNoneMatchRefetchTestEv - fun:_ZN8appcache11WrapperTaskIMNS_21AppCacheUpdateJobTestEFvvEE3RunEv - fun:_ZN11MessageLoop7RunTaskEP4Task - fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE - fun:_ZN11MessageLoop6DoWorkEv - fun:_ZN4base19MessagePumpLibevent3RunEPNS_11MessagePump8DelegateE - fun:_ZN11MessageLoop11RunInternalEv - fun:_ZN11MessageLoop10RunHandlerEv -} -{ - bug_jennb_2 - Memcheck:Leak - fun:_Znw* - fun:_ZN8appcache21AppCacheUpdateJobTest26MultipleHeadersRefetchTestEv - fun:_ZN8appcache11WrapperTaskIMNS_21AppCacheUpdateJobTestEFvvEE3RunEv - fun:_ZN11MessageLoop7RunTaskEP4Task - fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE - fun:_ZN11MessageLoop6DoWorkEv - fun:_ZN4base19MessagePumpLibevent3RunEPNS_11MessagePump8DelegateE - fun:_ZN11MessageLoop11RunInternalEv - fun:_ZN11MessageLoop10RunHandlerEv -} diff --git a/webkit/appcache/appcache_update_job_unittest.cc b/webkit/appcache/appcache_update_job_unittest.cc index 45898e8..bf368cd 100644 --- a/webkit/appcache/appcache_update_job_unittest.cc +++ b/webkit/appcache/appcache_update_job_unittest.cc @@ -2384,8 +2384,6 @@ class AppCacheUpdateJobTest : public testing::Test, net::HttpResponseInfo* response_info = new net::HttpResponseInfo(); response_info->headers = headers; // adds ref to headers - update = new AppCacheUpdateJob(service_.get(), group_); - group_->update_job_ = update; group_->update_status_ = AppCacheGroup::DOWNLOADING; update->manifest_response_info_.reset(response_info); update->internal_state_ = AppCacheUpdateJob::REFETCH_MANIFEST; @@ -2422,8 +2420,6 @@ class AppCacheUpdateJobTest : public testing::Test, net::HttpResponseInfo* response_info = new net::HttpResponseInfo(); response_info->headers = headers; // adds ref to headers - update = new AppCacheUpdateJob(service_.get(), group_); - group_->update_job_ = update; group_->update_status_ = AppCacheGroup::DOWNLOADING; update->manifest_response_info_.reset(response_info); update->internal_state_ = AppCacheUpdateJob::REFETCH_MANIFEST; |