summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorerg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-10-18 20:21:31 +0000
committererg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-10-18 20:21:31 +0000
commitb104b50ddb1d70d95ff9ace7a6fb30ec3b1aeb17 (patch)
tree0d35c3f624aec7c6de8824fab2b9521bfff1dbff
parentd13509f32546e26332733ac6153d359fbd566eaa (diff)
downloadchromium_src-b104b50ddb1d70d95ff9ace7a6fb30ec3b1aeb17.zip
chromium_src-b104b50ddb1d70d95ff9ace7a6fb30ec3b1aeb17.tar.gz
chromium_src-b104b50ddb1d70d95ff9ace7a6fb30ec3b1aeb17.tar.bz2
FBTF: Monster ctor patch after changing heuristics in clang plugin.
(Only 916k this time off Debug Linux .a files) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3814013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62967 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--app/multi_animation.cc2
-rw-r--r--app/multi_animation.h1
-rw-r--r--chrome/browser/appcache/appcache_dispatcher_host.cc2
-rw-r--r--chrome/browser/appcache/appcache_dispatcher_host.h2
-rw-r--r--chrome/browser/debugger/devtools_netlog_observer.cc1
-rw-r--r--chrome/browser/file_system/file_system_host_context.cc2
-rw-r--r--chrome/browser/file_system/file_system_host_context.h1
-rw-r--r--chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc26
-rw-r--r--chrome/browser/sync/engine/net/syncapi_server_connection_manager.h19
-rw-r--r--chrome/browser/sync/engine/syncapi.cc12
-rw-r--r--chrome/browser/sync/engine/syncapi.h10
-rw-r--r--chrome/common/extensions/extension_message_bundle.cc4
-rw-r--r--chrome/common/extensions/extension_message_bundle.h3
-rw-r--r--media/base/callback.cc27
-rw-r--r--media/base/callback.h16
-rw-r--r--media/media.gyp1
-rw-r--r--net/disk_cache/disk_format.cc21
-rw-r--r--net/disk_cache/disk_format.h14
-rw-r--r--net/disk_cache/file.cc16
-rw-r--r--net/disk_cache/file.h4
-rw-r--r--net/disk_cache/mem_backend_impl.cc2
-rw-r--r--net/disk_cache/mem_backend_impl.h2
-rw-r--r--net/disk_cache/sparse_control.cc11
-rw-r--r--net/disk_cache/sparse_control.h7
-rw-r--r--net/ftp/ftp_ctrl_response_buffer.cc21
-rw-r--r--net/ftp/ftp_ctrl_response_buffer.h19
-rw-r--r--net/ftp/ftp_directory_listing_parser_hprc.cc2
-rw-r--r--net/ftp/ftp_directory_listing_parser_hprc.h1
-rw-r--r--net/ftp/ftp_directory_listing_parser_ls.cc2
-rw-r--r--net/ftp/ftp_directory_listing_parser_ls.h1
-rw-r--r--net/ftp/ftp_directory_listing_parser_mlsd.cc5
-rw-r--r--net/ftp/ftp_directory_listing_parser_mlsd.h1
-rw-r--r--net/ftp/ftp_directory_listing_parser_netware.cc2
-rw-r--r--net/ftp/ftp_directory_listing_parser_netware.h1
-rw-r--r--net/ftp/ftp_directory_listing_parser_vms.cc2
-rw-r--r--net/ftp/ftp_directory_listing_parser_vms.h1
-rw-r--r--net/ftp/ftp_directory_listing_parser_windows.cc5
-rw-r--r--net/ftp/ftp_directory_listing_parser_windows.h1
-rw-r--r--net/ftp/ftp_network_session.cc15
-rw-r--r--net/ftp/ftp_network_session.h5
-rw-r--r--net/http/http_cache.cc17
-rw-r--r--net/http/http_cache.h8
-rw-r--r--net/http/http_net_log_params.cc59
-rw-r--r--net/http/http_net_log_params.h52
-rw-r--r--net/http/http_proxy_client_socket.cc1
-rw-r--r--net/http/partial_data.cc9
-rw-r--r--net/http/partial_data.h4
-rw-r--r--net/http/url_security_manager.cc2
-rw-r--r--net/http/url_security_manager.h1
-rw-r--r--net/net.gyp4
-rw-r--r--net/proxy/proxy_resolver_script_data.cc10
-rw-r--r--net/proxy/proxy_resolver_script_data.h9
-rw-r--r--net/spdy/spdy_proxy_client_socket.cc1
-rw-r--r--net/url_request/url_request_job_manager.cc2
-rw-r--r--net/url_request/url_request_job_manager.h1
-rw-r--r--net/url_request/url_request_job_metrics.cc8
-rw-r--r--net/url_request/url_request_job_metrics.h7
-rw-r--r--net/url_request/view_cache_helper.cc16
-rw-r--r--net/url_request/view_cache_helper.h9
-rw-r--r--remoting/base/encoder_zlib.cc2
-rw-r--r--remoting/base/encoder_zlib.h2
-rw-r--r--remoting/base/tracer.cc41
-rw-r--r--remoting/base/tracer.h35
-rw-r--r--remoting/host/client_connection.cc2
-rw-r--r--remoting/host/client_connection.h2
-rw-r--r--remoting/host/differ.cc2
-rw-r--r--remoting/host/differ.h1
-rw-r--r--remoting/host/in_memory_host_config.cc2
-rw-r--r--remoting/host/in_memory_host_config.h2
-rw-r--r--remoting/host/json_host_config.cc2
-rw-r--r--remoting/host/json_host_config.h1
-rw-r--r--remoting/protocol/messages_decoder.cc8
-rw-r--r--remoting/protocol/messages_decoder.h11
-rw-r--r--remoting/protocol/stream_reader.cc1
-rw-r--r--webkit/glue/media/media_resource_loader_bridge_factory.cc4
-rw-r--r--webkit/glue/media/media_resource_loader_bridge_factory.h5
-rw-r--r--webkit/glue/plugins/gtk_plugin_container_manager.cc4
-rw-r--r--webkit/glue/plugins/gtk_plugin_container_manager.h3
-rw-r--r--webkit/glue/plugins/pepper_string.cc13
-rw-r--r--webkit/glue/plugins/pepper_string.h4
-rw-r--r--webkit/glue/plugins/pepper_webplugin_impl.cc7
-rw-r--r--webkit/glue/plugins/pepper_webplugin_impl.h7
-rw-r--r--webkit/glue/webkit_glue.gypi6
-rw-r--r--webkit/glue/webvideoframe_impl.cc2
-rw-r--r--webkit/glue/webvideoframe_impl.h1
85 files changed, 498 insertions, 182 deletions
diff --git a/app/multi_animation.cc b/app/multi_animation.cc
index 14cd7f9..11ca6f8 100644
--- a/app/multi_animation.cc
+++ b/app/multi_animation.cc
@@ -25,6 +25,8 @@ MultiAnimation::MultiAnimation(const Parts& parts)
DCHECK(!parts_.empty());
}
+MultiAnimation::~MultiAnimation() {}
+
void MultiAnimation::Step(base::TimeTicks time_now) {
double last_value = current_value_;
size_t last_index = current_part_index_;
diff --git a/app/multi_animation.h b/app/multi_animation.h
index 77f5f4c..5583c3f 100644
--- a/app/multi_animation.h
+++ b/app/multi_animation.h
@@ -45,6 +45,7 @@ class MultiAnimation : public Animation {
typedef std::vector<Part> Parts;
explicit MultiAnimation(const Parts& parts);
+ virtual ~MultiAnimation();
// Returns the current value. The current value for a MultiAnimation is
// determined from the tween type of the current part.
diff --git a/chrome/browser/appcache/appcache_dispatcher_host.cc b/chrome/browser/appcache/appcache_dispatcher_host.cc
index e37784f..e7525e2 100644
--- a/chrome/browser/appcache/appcache_dispatcher_host.cc
+++ b/chrome/browser/appcache/appcache_dispatcher_host.cc
@@ -24,6 +24,8 @@ AppCacheDispatcherHost::AppCacheDispatcherHost(
DCHECK(request_context_getter_.get());
}
+AppCacheDispatcherHost::~AppCacheDispatcherHost() {}
+
void AppCacheDispatcherHost::Initialize(
ResourceDispatcherHost::Receiver* receiver) {
DCHECK(receiver && !receiver_);
diff --git a/chrome/browser/appcache/appcache_dispatcher_host.h b/chrome/browser/appcache/appcache_dispatcher_host.h
index c54784c..23c7c77 100644
--- a/chrome/browser/appcache/appcache_dispatcher_host.h
+++ b/chrome/browser/appcache/appcache_dispatcher_host.h
@@ -34,6 +34,8 @@ class AppCacheDispatcherHost {
explicit AppCacheDispatcherHost(
URLRequestContextGetter* request_context_getter);
+ ~AppCacheDispatcherHost();
+
void Initialize(ResourceDispatcherHost::Receiver* receiver);
bool OnMessageReceived(const IPC::Message& msg, bool* msg_is_ok);
diff --git a/chrome/browser/debugger/devtools_netlog_observer.cc b/chrome/browser/debugger/devtools_netlog_observer.cc
index 1aaf13e..776cc9f 100644
--- a/chrome/browser/debugger/devtools_netlog_observer.cc
+++ b/chrome/browser/debugger/devtools_netlog_observer.cc
@@ -9,6 +9,7 @@
#include "chrome/common/resource_response.h"
#include "net/base/load_flags.h"
#include "net/http/http_net_log_params.h"
+#include "net/http/http_response_headers.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_netlog_params.h"
#include "webkit/glue/resource_loader_bridge.h"
diff --git a/chrome/browser/file_system/file_system_host_context.cc b/chrome/browser/file_system/file_system_host_context.cc
index 3f26048..e94c326 100644
--- a/chrome/browser/file_system/file_system_host_context.cc
+++ b/chrome/browser/file_system/file_system_host_context.cc
@@ -41,3 +41,5 @@ void FileSystemHostContext::ResetOriginQuotaUnlimited(const GURL& url) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
quota_manager_->ResetOriginQuotaUnlimited(url);
}
+
+FileSystemHostContext::~FileSystemHostContext() {}
diff --git a/chrome/browser/file_system/file_system_host_context.h b/chrome/browser/file_system/file_system_host_context.h
index 34f0943..1575c97 100644
--- a/chrome/browser/file_system/file_system_host_context.h
+++ b/chrome/browser/file_system/file_system_host_context.h
@@ -22,6 +22,7 @@ class FileSystemHostContext
BrowserThread::DeleteOnIOThread> {
public:
FileSystemHostContext(const FilePath& data_path, bool is_incognito);
+ virtual ~FileSystemHostContext();
// Quota related methods.
bool CheckOriginQuota(const GURL& url, int64 growth);
diff --git a/chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc b/chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc
index 5ad28de..d50e891 100644
--- a/chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc
+++ b/chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc
@@ -12,6 +12,15 @@ using std::string;
namespace sync_api {
+SyncAPIBridgedPost::SyncAPIBridgedPost(
+ browser_sync::ServerConnectionManager* scm,
+ HttpPostProviderFactory* factory)
+ : Post(scm), factory_(factory) {
+}
+
+SyncAPIBridgedPost::~SyncAPIBridgedPost() {}
+
+
bool SyncAPIBridgedPost::Init(const char* path, const string& auth_token,
const string& payload, HttpResponse* response) {
string sync_server;
@@ -67,6 +76,23 @@ bool SyncAPIBridgedPost::Init(const char* path, const string& auth_token,
return true;
}
+SyncAPIServerConnectionManager::SyncAPIServerConnectionManager(
+ const std::string& server,
+ int port,
+ bool use_ssl,
+ const std::string& client_version,
+ HttpPostProviderFactory* factory)
+ : ServerConnectionManager(server, port, use_ssl, client_version),
+ post_provider_factory_(factory) {
+ DCHECK(post_provider_factory_.get());
+}
+
SyncAPIServerConnectionManager::~SyncAPIServerConnectionManager() {}
+browser_sync::ServerConnectionManager::Post*
+SyncAPIServerConnectionManager::MakePost() {
+ return new SyncAPIBridgedPost(this, post_provider_factory_.get());
+}
+
+
} // namespace sync_api
diff --git a/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h b/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h
index 4108f9a..cdf0711 100644
--- a/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h
+++ b/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h
@@ -21,11 +21,9 @@ class SyncAPIBridgedPost
: public browser_sync::ServerConnectionManager::Post {
public:
SyncAPIBridgedPost(browser_sync::ServerConnectionManager* scm,
- HttpPostProviderFactory* factory)
- : Post(scm), factory_(factory) {
- }
+ HttpPostProviderFactory* factory);
- virtual ~SyncAPIBridgedPost() { }
+ virtual ~SyncAPIBridgedPost();
virtual bool Init(const char* path,
const std::string& auth_token,
@@ -51,17 +49,12 @@ class SyncAPIServerConnectionManager
int port,
bool use_ssl,
const std::string& client_version,
- HttpPostProviderFactory* factory)
- : ServerConnectionManager(server, port, use_ssl, client_version),
- post_provider_factory_(factory) {
- DCHECK(post_provider_factory_.get());
- }
-
+ HttpPostProviderFactory* factory);
virtual ~SyncAPIServerConnectionManager();
+
protected:
- virtual Post* MakePost() {
- return new SyncAPIBridgedPost(this, post_provider_factory_.get());
- }
+ virtual Post* MakePost();
+
private:
// A factory creating concrete HttpPostProviders for use whenever we need to
// issue a POST to sync servers.
diff --git a/chrome/browser/sync/engine/syncapi.cc b/chrome/browser/sync/engine/syncapi.cc
index 0c8b706..f9e9059 100644
--- a/chrome/browser/sync/engine/syncapi.cc
+++ b/chrome/browser/sync/engine/syncapi.cc
@@ -906,6 +906,18 @@ class BridgedGaiaAuthenticator : public gaia::GaiaAuthenticator {
DISALLOW_COPY_AND_ASSIGN(BridgedGaiaAuthenticator);
};
+SyncManager::ChangeRecord::ChangeRecord()
+ : id(kInvalidId), action(ACTION_ADD) {}
+
+SyncManager::ChangeRecord::~ChangeRecord() {}
+
+SyncManager::ExtraPasswordChangeRecordData::ExtraPasswordChangeRecordData(
+ const sync_pb::PasswordSpecificsData& data)
+ : unencrypted_(data) {
+}
+
+SyncManager::ExtraPasswordChangeRecordData::~ExtraPasswordChangeRecordData() {}
+
//////////////////////////////////////////////////////////////////////////
// SyncManager's implementation: SyncManager::SyncInternal
class SyncManager::SyncInternal
diff --git a/chrome/browser/sync/engine/syncapi.h b/chrome/browser/sync/engine/syncapi.h
index 8ffd729..cbd8d8b 100644
--- a/chrome/browser/sync/engine/syncapi.h
+++ b/chrome/browser/sync/engine/syncapi.h
@@ -574,7 +574,9 @@ class SyncManager {
ACTION_DELETE,
ACTION_UPDATE,
};
- ChangeRecord() : id(kInvalidId), action(ACTION_ADD) {}
+ ChangeRecord();
+ ~ChangeRecord();
+
int64 id;
Action action;
sync_pb::EntitySpecifics specifics;
@@ -585,9 +587,9 @@ class SyncManager {
// access to unencrypted bits.
class ExtraPasswordChangeRecordData : public ExtraChangeRecordData {
public:
- ExtraPasswordChangeRecordData(const sync_pb::PasswordSpecificsData& data)
- : unencrypted_(data) {}
- virtual ~ExtraPasswordChangeRecordData() {}
+ explicit ExtraPasswordChangeRecordData(
+ const sync_pb::PasswordSpecificsData& data);
+ virtual ~ExtraPasswordChangeRecordData();
const sync_pb::PasswordSpecificsData& unencrypted() {
return unencrypted_;
}
diff --git a/chrome/common/extensions/extension_message_bundle.cc b/chrome/common/extensions/extension_message_bundle.cc
index 4e6222f..4de6b45 100644
--- a/chrome/common/extensions/extension_message_bundle.cc
+++ b/chrome/common/extensions/extension_message_bundle.cc
@@ -314,6 +314,10 @@ std::string ExtensionMessageBundle::GetL10nMessage(
//
///////////////////////////////////////////////////////////////////////////////
+ExtensionToMessagesMap::ExtensionToMessagesMap() {}
+
+ExtensionToMessagesMap::~ExtensionToMessagesMap() {}
+
ExtensionToL10nMessagesMap* GetExtensionToL10nMessagesMap() {
return &Singleton<ExtensionToMessagesMap>()->messages_map;
}
diff --git a/chrome/common/extensions/extension_message_bundle.h b/chrome/common/extensions/extension_message_bundle.h
index 46d59bd..6370559 100644
--- a/chrome/common/extensions/extension_message_bundle.h
+++ b/chrome/common/extensions/extension_message_bundle.h
@@ -157,6 +157,9 @@ typedef std::map<std::string, L10nMessagesMap > ExtensionToL10nMessagesMap;
// Unique class for Singleton.
struct ExtensionToMessagesMap {
+ ExtensionToMessagesMap();
+ ~ExtensionToMessagesMap();
+
// Maps extension ID to message map.
ExtensionToL10nMessagesMap messages_map;
};
diff --git a/media/base/callback.cc b/media/base/callback.cc
new file mode 100644
index 0000000..1e2b400
--- /dev/null
+++ b/media/base/callback.cc
@@ -0,0 +1,27 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/base/callback.h"
+
+namespace media {
+
+AutoTaskRunner::~AutoTaskRunner() {
+ if (task_.get()) {
+ task_->Run();
+ }
+}
+
+Callback0::Type* TaskToCallbackAdapter::NewCallback(Task* task) {
+ return new TaskToCallbackAdapter(task);
+}
+
+TaskToCallbackAdapter::~TaskToCallbackAdapter() {}
+
+void TaskToCallbackAdapter::RunWithParams(const Tuple0& params) {
+ task_->Run();
+}
+
+TaskToCallbackAdapter::TaskToCallbackAdapter(Task* task) : task_(task) {}
+
+} // namespace media
diff --git a/media/base/callback.h b/media/base/callback.h
index cefcae92..2273ace 100644
--- a/media/base/callback.h
+++ b/media/base/callback.h
@@ -34,11 +34,7 @@ class AutoTaskRunner {
: task_(task) {
}
- ~AutoTaskRunner() {
- if (task_.get()) {
- task_->Run();
- }
- }
+ ~AutoTaskRunner();
Task* release() { return task_.release(); }
@@ -71,16 +67,14 @@ class AutoCallbackRunner {
class TaskToCallbackAdapter : public Callback0::Type {
public:
- static Callback0::Type* NewCallback(Task* task) {
- return new TaskToCallbackAdapter(task);
- }
+ static Callback0::Type* NewCallback(Task* task);
- virtual ~TaskToCallbackAdapter() {}
+ virtual ~TaskToCallbackAdapter();
- virtual void RunWithParams(const Tuple0& params) { task_->Run(); }
+ virtual void RunWithParams(const Tuple0& params);
private:
- TaskToCallbackAdapter(Task* task) : task_(task) {}
+ TaskToCallbackAdapter(Task* task);
scoped_ptr<Task> task_;
diff --git a/media/media.gyp b/media/media.gyp
index 49679b1..9dae16a 100644
--- a/media/media.gyp
+++ b/media/media.gyp
@@ -67,6 +67,7 @@
'audio/win/waveout_output_win.h',
'base/buffers.cc',
'base/buffers.h',
+ 'base/callback.cc',
'base/callback.h',
'base/clock.h',
'base/clock_impl.cc',
diff --git a/net/disk_cache/disk_format.cc b/net/disk_cache/disk_format.cc
new file mode 100644
index 0000000..5216b50
--- /dev/null
+++ b/net/disk_cache/disk_format.cc
@@ -0,0 +1,21 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/disk_cache/disk_format.h"
+
+namespace disk_cache {
+
+IndexHeader::IndexHeader() {
+ memset(this, 0, sizeof(*this));
+ magic = kIndexMagic;
+ version = kCurrentVersion;
+}
+
+BlockFileHeader::BlockFileHeader() {
+ memset(this, 0, sizeof(BlockFileHeader));
+ magic = kBlockMagic;
+ version = kCurrentVersion;
+}
+
+} // namespace disk_cache
diff --git a/net/disk_cache/disk_format.h b/net/disk_cache/disk_format.h
index ac4c6348..ffe36ae 100644
--- a/net/disk_cache/disk_format.h
+++ b/net/disk_cache/disk_format.h
@@ -80,6 +80,8 @@ struct LruData {
// Header for the master index file.
struct IndexHeader {
+ IndexHeader();
+
uint32 magic;
uint32 version;
int32 num_entries; // Number of entries currently stored.
@@ -93,11 +95,6 @@ struct IndexHeader {
uint64 create_time; // Creation time for this set of files.
int32 pad[52];
LruData lru; // Eviction control data.
- IndexHeader() {
- memset(this, 0, sizeof(*this));
- magic = kIndexMagic;
- version = kCurrentVersion;
- };
};
// The structure of the whole index file.
@@ -177,6 +174,8 @@ typedef uint32 AllocBitmap[kMaxBlocks / 32];
// from the beginning every time).
// This Structure is the header of a block-file:
struct BlockFileHeader {
+ BlockFileHeader();
+
uint32 magic;
uint32 version;
int16 this_file; // Index of this file.
@@ -189,11 +188,6 @@ struct BlockFileHeader {
volatile int32 updating; // Keep track of updates to the header.
int32 user[5];
AllocBitmap allocation_map;
- BlockFileHeader() {
- memset(this, 0, sizeof(BlockFileHeader));
- magic = kBlockMagic;
- version = kCurrentVersion;
- };
};
COMPILE_ASSERT(sizeof(BlockFileHeader) == kBlockHeaderSize, bad_header);
diff --git a/net/disk_cache/file.cc b/net/disk_cache/file.cc
new file mode 100644
index 0000000..6b56951
--- /dev/null
+++ b/net/disk_cache/file.cc
@@ -0,0 +1,16 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/disk_cache/file.h"
+
+namespace disk_cache {
+
+// Cross platform constructors. Platform specific code is in
+// file_{win,posix}.cc.
+
+File::File() : init_(false), mixed_(false) {}
+
+File::File(bool mixed_mode) : init_(false), mixed_(mixed_mode) {}
+
+} // namespace disk_cache
diff --git a/net/disk_cache/file.h b/net/disk_cache/file.h
index 43ba5c1..c266311 100644
--- a/net/disk_cache/file.h
+++ b/net/disk_cache/file.h
@@ -29,9 +29,9 @@ class FileIOCallback {
class File : public base::RefCounted<File> {
friend class base::RefCounted<File>;
public:
- File() : init_(false), mixed_(false) {}
+ File();
// mixed_mode set to true enables regular synchronous operations for the file.
- explicit File(bool mixed_mode) : init_(false), mixed_(mixed_mode) {}
+ explicit File(bool mixed_mode);
// Initializes the object to use the passed in file instead of opening it with
// the Init() call. No asynchronous operations can be performed with this
diff --git a/net/disk_cache/mem_backend_impl.cc b/net/disk_cache/mem_backend_impl.cc
index fe57d7d..288a66e 100644
--- a/net/disk_cache/mem_backend_impl.cc
+++ b/net/disk_cache/mem_backend_impl.cc
@@ -62,6 +62,8 @@ bool MemBackendImpl::Init() {
return true;
}
+MemBackendImpl::MemBackendImpl() : max_size_(0), current_size_(0) {}
+
MemBackendImpl::~MemBackendImpl() {
EntryMap::iterator it = entries_.begin();
while (it != entries_.end()) {
diff --git a/net/disk_cache/mem_backend_impl.h b/net/disk_cache/mem_backend_impl.h
index 62ed3c5..c78c670 100644
--- a/net/disk_cache/mem_backend_impl.h
+++ b/net/disk_cache/mem_backend_impl.h
@@ -21,7 +21,7 @@ class MemEntryImpl;
// the operations of the cache without writing to disk.
class MemBackendImpl : public Backend {
public:
- MemBackendImpl() : max_size_(0), current_size_(0) {}
+ MemBackendImpl();
~MemBackendImpl();
// Returns an instance of a Backend implemented only in memory. The returned
diff --git a/net/disk_cache/sparse_control.cc b/net/disk_cache/sparse_control.cc
index 2934184..e94a1bc 100644
--- a/net/disk_cache/sparse_control.cc
+++ b/net/disk_cache/sparse_control.cc
@@ -142,6 +142,17 @@ void ChildrenDeleter::DeleteChildren() {
namespace disk_cache {
+SparseControl::SparseControl(EntryImpl* entry)
+ : entry_(entry),
+ child_(NULL),
+ operation_(kNoOperation),
+ init_(false),
+ child_map_(child_data_.bitmap, kNumSparseBits, kNumSparseBits / 32),
+ ALLOW_THIS_IN_INITIALIZER_LIST(
+ child_callback_(this, &SparseControl::OnChildIOCompleted)),
+ user_callback_(NULL) {
+}
+
SparseControl::~SparseControl() {
if (child_)
CloseChild();
diff --git a/net/disk_cache/sparse_control.h b/net/disk_cache/sparse_control.h
index 88a012b..15704df 100644
--- a/net/disk_cache/sparse_control.h
+++ b/net/disk_cache/sparse_control.h
@@ -40,12 +40,7 @@ class SparseControl {
kGetRangeOperation
};
- explicit SparseControl(EntryImpl* entry)
- : entry_(entry), child_(NULL), operation_(kNoOperation), init_(false),
- child_map_(child_data_.bitmap, kNumSparseBits, kNumSparseBits / 32),
- ALLOW_THIS_IN_INITIALIZER_LIST(
- child_callback_(this, &SparseControl::OnChildIOCompleted)),
- user_callback_(NULL) {}
+ explicit SparseControl(EntryImpl* entry);
~SparseControl();
// Initializes the object for the current entry. If this entry already stores
diff --git a/net/ftp/ftp_ctrl_response_buffer.cc b/net/ftp/ftp_ctrl_response_buffer.cc
index c9ee5dd..950e1e0 100644
--- a/net/ftp/ftp_ctrl_response_buffer.cc
+++ b/net/ftp/ftp_ctrl_response_buffer.cc
@@ -14,6 +14,14 @@ namespace net {
// static
const int FtpCtrlResponse::kInvalidStatusCode = -1;
+FtpCtrlResponse::FtpCtrlResponse() : status_code(kInvalidStatusCode) {}
+
+FtpCtrlResponse::~FtpCtrlResponse() {}
+
+FtpCtrlResponseBuffer::FtpCtrlResponseBuffer() : multiline_(false) {}
+
+FtpCtrlResponseBuffer::~FtpCtrlResponseBuffer() {}
+
int FtpCtrlResponseBuffer::ConsumeData(const char* data, int data_length) {
buffer_.append(data, data_length);
ExtractFullLinesFromBuffer();
@@ -64,6 +72,19 @@ int FtpCtrlResponseBuffer::ConsumeData(const char* data, int data_length) {
return OK;
}
+FtpCtrlResponse FtpCtrlResponseBuffer::PopResponse() {
+ FtpCtrlResponse result = responses_.front();
+ responses_.pop();
+ return result;
+}
+
+FtpCtrlResponseBuffer::ParsedLine::ParsedLine()
+ : has_status_code(false),
+ is_multiline(false),
+ is_complete(false),
+ status_code(FtpCtrlResponse::kInvalidStatusCode) {
+}
+
// static
FtpCtrlResponseBuffer::ParsedLine FtpCtrlResponseBuffer::ParseLine(
const std::string& line) {
diff --git a/net/ftp/ftp_ctrl_response_buffer.h b/net/ftp/ftp_ctrl_response_buffer.h
index b98f494..219a2d4 100644
--- a/net/ftp/ftp_ctrl_response_buffer.h
+++ b/net/ftp/ftp_ctrl_response_buffer.h
@@ -18,7 +18,8 @@ namespace net {
struct FtpCtrlResponse {
static const int kInvalidStatusCode;
- FtpCtrlResponse() : status_code(kInvalidStatusCode) {}
+ FtpCtrlResponse();
+ ~FtpCtrlResponse();
int status_code; // Three-digit status code.
std::vector<std::string> lines; // Response lines, without CRLFs.
@@ -26,7 +27,8 @@ struct FtpCtrlResponse {
class FtpCtrlResponseBuffer {
public:
- FtpCtrlResponseBuffer() : multiline_(false) {}
+ FtpCtrlResponseBuffer();
+ ~FtpCtrlResponseBuffer();
// Called when data is received from the control socket. Returns error code.
int ConsumeData(const char* data, int data_length);
@@ -37,20 +39,11 @@ class FtpCtrlResponseBuffer {
// Returns the next response. It is an error to call this function
// unless ResponseAvailable returns true.
- FtpCtrlResponse PopResponse() {
- FtpCtrlResponse result = responses_.front();
- responses_.pop();
- return result;
- }
+ FtpCtrlResponse PopResponse();
private:
struct ParsedLine {
- ParsedLine()
- : has_status_code(false),
- is_multiline(false),
- is_complete(false),
- status_code(FtpCtrlResponse::kInvalidStatusCode) {
- }
+ ParsedLine();
// Indicates that this line begins with a valid 3-digit status code.
bool has_status_code;
diff --git a/net/ftp/ftp_directory_listing_parser_hprc.cc b/net/ftp/ftp_directory_listing_parser_hprc.cc
index b65ec68..621aba1 100644
--- a/net/ftp/ftp_directory_listing_parser_hprc.cc
+++ b/net/ftp/ftp_directory_listing_parser_hprc.cc
@@ -14,6 +14,8 @@ FtpDirectoryListingParserHprc::FtpDirectoryListingParserHprc(
: current_time_(current_time) {
}
+FtpDirectoryListingParserHprc::~FtpDirectoryListingParserHprc() {}
+
FtpServerType FtpDirectoryListingParserHprc::GetServerType() const {
return SERVER_HPRC;
}
diff --git a/net/ftp/ftp_directory_listing_parser_hprc.h b/net/ftp/ftp_directory_listing_parser_hprc.h
index 73b5195..d153810 100644
--- a/net/ftp/ftp_directory_listing_parser_hprc.h
+++ b/net/ftp/ftp_directory_listing_parser_hprc.h
@@ -22,6 +22,7 @@ class FtpDirectoryListingParserHprc : public FtpDirectoryListingParser {
// that we don't know, |current_time| will be used. This allows passing
// a specific date during testing.
explicit FtpDirectoryListingParserHprc(const base::Time& current_time);
+ virtual ~FtpDirectoryListingParserHprc();
// FtpDirectoryListingParser methods:
virtual FtpServerType GetServerType() const;
diff --git a/net/ftp/ftp_directory_listing_parser_ls.cc b/net/ftp/ftp_directory_listing_parser_ls.cc
index 9fd2400..89fc3d8 100644
--- a/net/ftp/ftp_directory_listing_parser_ls.cc
+++ b/net/ftp/ftp_directory_listing_parser_ls.cc
@@ -89,6 +89,8 @@ FtpDirectoryListingParserLs::FtpDirectoryListingParserLs(
current_time_(current_time) {
}
+FtpDirectoryListingParserLs::~FtpDirectoryListingParserLs() {}
+
bool FtpDirectoryListingParserLs::ConsumeLine(const string16& line) {
if (line.empty() && !received_nonempty_line_) {
// Allow empty lines only at the beginning of the listing. For example VMS
diff --git a/net/ftp/ftp_directory_listing_parser_ls.h b/net/ftp/ftp_directory_listing_parser_ls.h
index 54856c1..6cb3655 100644
--- a/net/ftp/ftp_directory_listing_parser_ls.h
+++ b/net/ftp/ftp_directory_listing_parser_ls.h
@@ -20,6 +20,7 @@ class FtpDirectoryListingParserLs : public FtpDirectoryListingParser {
// date strings, |current_time| will be used. This allows passing a specific
// date during testing.
explicit FtpDirectoryListingParserLs(const base::Time& current_time);
+ virtual ~FtpDirectoryListingParserLs();
// FtpDirectoryListingParser methods:
virtual FtpServerType GetServerType() const { return SERVER_LS; }
diff --git a/net/ftp/ftp_directory_listing_parser_mlsd.cc b/net/ftp/ftp_directory_listing_parser_mlsd.cc
index dc6dace..fa9a44e 100644
--- a/net/ftp/ftp_directory_listing_parser_mlsd.cc
+++ b/net/ftp/ftp_directory_listing_parser_mlsd.cc
@@ -48,8 +48,9 @@ bool MlsdDateListingToTime(const string16& text, base::Time* time) {
namespace net {
-FtpDirectoryListingParserMlsd::FtpDirectoryListingParserMlsd() {
-}
+FtpDirectoryListingParserMlsd::FtpDirectoryListingParserMlsd() {}
+
+FtpDirectoryListingParserMlsd::~FtpDirectoryListingParserMlsd() {}
bool FtpDirectoryListingParserMlsd::ConsumeLine(const string16& line) {
// The first space indicates where the filename begins.
diff --git a/net/ftp/ftp_directory_listing_parser_mlsd.h b/net/ftp/ftp_directory_listing_parser_mlsd.h
index 94df607..c3e3acf 100644
--- a/net/ftp/ftp_directory_listing_parser_mlsd.h
+++ b/net/ftp/ftp_directory_listing_parser_mlsd.h
@@ -17,6 +17,7 @@ namespace net {
class FtpDirectoryListingParserMlsd : public FtpDirectoryListingParser {
public:
FtpDirectoryListingParserMlsd();
+ virtual ~FtpDirectoryListingParserMlsd();
// FtpDirectoryListingParser methods:
virtual FtpServerType GetServerType() const { return SERVER_MLSD; }
diff --git a/net/ftp/ftp_directory_listing_parser_netware.cc b/net/ftp/ftp_directory_listing_parser_netware.cc
index 3cd0c8f..ab7fb6d 100644
--- a/net/ftp/ftp_directory_listing_parser_netware.cc
+++ b/net/ftp/ftp_directory_listing_parser_netware.cc
@@ -40,6 +40,8 @@ FtpDirectoryListingParserNetware::FtpDirectoryListingParserNetware(
current_time_(current_time) {
}
+FtpDirectoryListingParserNetware::~FtpDirectoryListingParserNetware() {}
+
bool FtpDirectoryListingParserNetware::ConsumeLine(const string16& line) {
if (!received_first_line_) {
received_first_line_ = true;
diff --git a/net/ftp/ftp_directory_listing_parser_netware.h b/net/ftp/ftp_directory_listing_parser_netware.h
index e05b55d..5fdcd84 100644
--- a/net/ftp/ftp_directory_listing_parser_netware.h
+++ b/net/ftp/ftp_directory_listing_parser_netware.h
@@ -20,6 +20,7 @@ class FtpDirectoryListingParserNetware : public FtpDirectoryListingParser {
// date strings, |current_time| will be used. This allows passing a specific
// date during testing.
explicit FtpDirectoryListingParserNetware(const base::Time& current_time);
+ virtual ~FtpDirectoryListingParserNetware();
// FtpDirectoryListingParser methods:
virtual FtpServerType GetServerType() const { return SERVER_NETWARE; }
diff --git a/net/ftp/ftp_directory_listing_parser_vms.cc b/net/ftp/ftp_directory_listing_parser_vms.cc
index 3702a14..ed12665 100644
--- a/net/ftp/ftp_directory_listing_parser_vms.cc
+++ b/net/ftp/ftp_directory_listing_parser_vms.cc
@@ -168,6 +168,8 @@ FtpDirectoryListingParserVms::FtpDirectoryListingParserVms()
last_is_directory_(false) {
}
+FtpDirectoryListingParserVms::~FtpDirectoryListingParserVms() {}
+
bool FtpDirectoryListingParserVms::ConsumeLine(const string16& line) {
switch (state_) {
case STATE_INITIAL:
diff --git a/net/ftp/ftp_directory_listing_parser_vms.h b/net/ftp/ftp_directory_listing_parser_vms.h
index 1b1f082..12f8dc7 100644
--- a/net/ftp/ftp_directory_listing_parser_vms.h
+++ b/net/ftp/ftp_directory_listing_parser_vms.h
@@ -16,6 +16,7 @@ namespace net {
class FtpDirectoryListingParserVms : public FtpDirectoryListingParser {
public:
FtpDirectoryListingParserVms();
+ virtual ~FtpDirectoryListingParserVms();
// FtpDirectoryListingParser methods:
virtual FtpServerType GetServerType() const { return SERVER_VMS; }
diff --git a/net/ftp/ftp_directory_listing_parser_windows.cc b/net/ftp/ftp_directory_listing_parser_windows.cc
index d2bbdaa..e3211739 100644
--- a/net/ftp/ftp_directory_listing_parser_windows.cc
+++ b/net/ftp/ftp_directory_listing_parser_windows.cc
@@ -72,8 +72,9 @@ bool WindowsDateListingToTime(const std::vector<string16>& columns,
namespace net {
-FtpDirectoryListingParserWindows::FtpDirectoryListingParserWindows() {
-}
+FtpDirectoryListingParserWindows::FtpDirectoryListingParserWindows() {}
+
+FtpDirectoryListingParserWindows::~FtpDirectoryListingParserWindows() {}
bool FtpDirectoryListingParserWindows::ConsumeLine(const string16& line) {
std::vector<string16> columns;
diff --git a/net/ftp/ftp_directory_listing_parser_windows.h b/net/ftp/ftp_directory_listing_parser_windows.h
index cf869c3..91ffe36 100644
--- a/net/ftp/ftp_directory_listing_parser_windows.h
+++ b/net/ftp/ftp_directory_listing_parser_windows.h
@@ -15,6 +15,7 @@ namespace net {
class FtpDirectoryListingParserWindows : public FtpDirectoryListingParser {
public:
FtpDirectoryListingParserWindows();
+ virtual ~FtpDirectoryListingParserWindows();
// FtpDirectoryListingParser methods:
virtual FtpServerType GetServerType() const { return SERVER_WINDOWS; }
diff --git a/net/ftp/ftp_network_session.cc b/net/ftp/ftp_network_session.cc
new file mode 100644
index 0000000..65dd218
--- /dev/null
+++ b/net/ftp/ftp_network_session.cc
@@ -0,0 +1,15 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/ftp/ftp_network_session.h"
+
+namespace net {
+
+FtpNetworkSession::FtpNetworkSession(HostResolver* host_resolver)
+ : host_resolver_(host_resolver) {}
+
+FtpNetworkSession::~FtpNetworkSession() {}
+
+} // namespace net
+
diff --git a/net/ftp/ftp_network_session.h b/net/ftp/ftp_network_session.h
index 3eab4ff..b53b5c0 100644
--- a/net/ftp/ftp_network_session.h
+++ b/net/ftp/ftp_network_session.h
@@ -16,8 +16,7 @@ class HostResolver;
// This class holds session objects used by FtpNetworkTransaction objects.
class FtpNetworkSession : public base::RefCounted<FtpNetworkSession> {
public:
- explicit FtpNetworkSession(HostResolver* host_resolver)
- : host_resolver_(host_resolver) {}
+ explicit FtpNetworkSession(HostResolver* host_resolver);
HostResolver* host_resolver() { return host_resolver_; }
FtpAuthCache* auth_cache() { return &auth_cache_; }
@@ -25,7 +24,7 @@ class FtpNetworkSession : public base::RefCounted<FtpNetworkSession> {
private:
friend class base::RefCounted<FtpNetworkSession>;
- ~FtpNetworkSession() {}
+ virtual ~FtpNetworkSession();
HostResolver* const host_resolver_;
FtpAuthCache auth_cache_;
diff --git a/net/http/http_cache.cc b/net/http/http_cache.cc
index 867d003..a62c84e 100644
--- a/net/http/http_cache.cc
+++ b/net/http/http_cache.cc
@@ -36,6 +36,23 @@
namespace net {
+HttpCache::DefaultBackend::DefaultBackend(CacheType type,
+ const FilePath& path,
+ int max_bytes,
+ base::MessageLoopProxy* thread)
+ : type_(type),
+ path_(path),
+ max_bytes_(max_bytes),
+ thread_(thread) {
+}
+
+HttpCache::DefaultBackend::~DefaultBackend() {}
+
+// static
+HttpCache::BackendFactory* HttpCache::DefaultBackend::InMemory(int max_bytes) {
+ return new DefaultBackend(MEMORY_CACHE, FilePath(), max_bytes, NULL);
+}
+
int HttpCache::DefaultBackend::CreateBackend(disk_cache::Backend** backend,
CompletionCallback* callback) {
DCHECK_GE(max_bytes_, 0);
diff --git a/net/http/http_cache.h b/net/http/http_cache.h
index 775d035..1eeacdd 100644
--- a/net/http/http_cache.h
+++ b/net/http/http_cache.h
@@ -96,13 +96,11 @@ class HttpCache : public HttpTransactionFactory,
// |cache_thread| is the thread where disk operations should take place. If
// |max_bytes| is zero, a default value will be calculated automatically.
DefaultBackend(CacheType type, const FilePath& path, int max_bytes,
- base::MessageLoopProxy* thread)
- : type_(type), path_(path), max_bytes_(max_bytes), thread_(thread) {}
+ base::MessageLoopProxy* thread);
+ virtual ~DefaultBackend();
// Returns a factory for an in-memory cache.
- static BackendFactory* InMemory(int max_bytes) {
- return new DefaultBackend(MEMORY_CACHE, FilePath(), max_bytes, NULL);
- }
+ static BackendFactory* InMemory(int max_bytes);
// BackendFactory implementation.
virtual int CreateBackend(disk_cache::Backend** backend,
diff --git a/net/http/http_net_log_params.cc b/net/http/http_net_log_params.cc
new file mode 100644
index 0000000..989d30d
--- /dev/null
+++ b/net/http/http_net_log_params.cc
@@ -0,0 +1,59 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/http/http_net_log_params.h"
+
+#include "base/stringprintf.h"
+#include "base/values.h"
+#include "net/http/http_response_headers.h"
+
+namespace net {
+
+NetLogHttpRequestParameter::NetLogHttpRequestParameter(
+ const std::string& line,
+ const HttpRequestHeaders& headers)
+ : line_(line) {
+ headers_.CopyFrom(headers);
+}
+
+Value* NetLogHttpRequestParameter::ToValue() const {
+ DictionaryValue* dict = new DictionaryValue();
+ dict->SetString("line", line_);
+ ListValue* headers = new ListValue();
+ HttpRequestHeaders::Iterator iterator(headers_);
+ while (iterator.GetNext()) {
+ headers->Append(
+ new StringValue(base::StringPrintf("%s: %s",
+ iterator.name().c_str(),
+ iterator.value().c_str())));
+ }
+ dict->Set("headers", headers);
+ return dict;
+}
+
+NetLogHttpRequestParameter::~NetLogHttpRequestParameter() {}
+
+NetLogHttpResponseParameter::NetLogHttpResponseParameter(
+ const scoped_refptr<HttpResponseHeaders>& headers)
+ : headers_(headers) {}
+
+Value* NetLogHttpResponseParameter::ToValue() const {
+ DictionaryValue* dict = new DictionaryValue();
+ ListValue* headers = new ListValue();
+ headers->Append(new StringValue(headers_->GetStatusLine()));
+ void* iterator = NULL;
+ std::string name;
+ std::string value;
+ while (headers_->EnumerateHeaderLines(&iterator, &name, &value)) {
+ headers->Append(
+ new StringValue(base::StringPrintf("%s: %s", name.c_str(),
+ value.c_str())));
+ }
+ dict->Set("headers", headers);
+ return dict;
+}
+
+NetLogHttpResponseParameter::~NetLogHttpResponseParameter() {}
+
+} // namespace net
diff --git a/net/http/http_net_log_params.h b/net/http/http_net_log_params.h
index 4331a0f..403b6a7 100644
--- a/net/http/http_net_log_params.h
+++ b/net/http/http_net_log_params.h
@@ -10,43 +10,28 @@
#include "base/basictypes.h"
#include "base/ref_counted.h"
-#include "base/stringprintf.h"
-#include "base/values.h"
#include "net/base/net_log.h"
#include "net/http/http_request_headers.h"
-#include "net/http/http_response_headers.h"
+
+class Value;
namespace net {
+class HttpResponseHeaders;
+
class NetLogHttpRequestParameter : public NetLog::EventParameters {
public:
NetLogHttpRequestParameter(const std::string& line,
- const HttpRequestHeaders& headers)
- : line_(line) {
- headers_.CopyFrom(headers);
- }
+ const HttpRequestHeaders& headers);
- Value* ToValue() const {
- DictionaryValue* dict = new DictionaryValue();
- dict->SetString("line", line_);
- ListValue* headers = new ListValue();
- HttpRequestHeaders::Iterator iterator(headers_);
- while (iterator.GetNext()) {
- headers->Append(
- new StringValue(base::StringPrintf("%s: %s",
- iterator.name().c_str(),
- iterator.value().c_str())));
- }
- dict->Set("headers", headers);
- return dict;
- }
+ Value* ToValue() const;
const HttpRequestHeaders& GetHeaders() const {
return headers_;
}
private:
- ~NetLogHttpRequestParameter() {}
+ virtual ~NetLogHttpRequestParameter();
const std::string line_;
HttpRequestHeaders headers_;
@@ -57,31 +42,16 @@ class NetLogHttpRequestParameter : public NetLog::EventParameters {
class NetLogHttpResponseParameter : public NetLog::EventParameters {
public:
explicit NetLogHttpResponseParameter(
- const scoped_refptr<HttpResponseHeaders>& headers)
- : headers_(headers) {}
-
- Value* ToValue() const {
- DictionaryValue* dict = new DictionaryValue();
- ListValue* headers = new ListValue();
- headers->Append(new StringValue(headers_->GetStatusLine()));
- void* iterator = NULL;
- std::string name;
- std::string value;
- while (headers_->EnumerateHeaderLines(&iterator, &name, &value)) {
- headers->Append(
- new StringValue(base::StringPrintf("%s: %s", name.c_str(),
- value.c_str())));
- }
- dict->Set("headers", headers);
- return dict;
- }
+ const scoped_refptr<HttpResponseHeaders>& headers);
+
+ Value* ToValue() const;
const HttpResponseHeaders& GetHeaders() const {
return *headers_;
}
private:
- ~NetLogHttpResponseParameter() {}
+ virtual ~NetLogHttpResponseParameter();
const scoped_refptr<HttpResponseHeaders> headers_;
diff --git a/net/http/http_proxy_client_socket.cc b/net/http/http_proxy_client_socket.cc
index 2da59b7..b5ede3d 100644
--- a/net/http/http_proxy_client_socket.cc
+++ b/net/http/http_proxy_client_socket.cc
@@ -16,6 +16,7 @@
#include "net/http/http_network_session.h"
#include "net/http/http_proxy_utils.h"
#include "net/http/http_request_info.h"
+#include "net/http/http_response_headers.h"
#include "net/http/http_stream_parser.h"
#include "net/socket/client_socket_handle.h"
diff --git a/net/http/partial_data.cc b/net/http/partial_data.cc
index 799c3fa..68d8048 100644
--- a/net/http/partial_data.cc
+++ b/net/http/partial_data.cc
@@ -106,6 +106,15 @@ void PartialData::Core::OnIOComplete(int result) {
// -----------------------------------------------------------------------------
+PartialData::PartialData()
+ : range_present_(false),
+ final_range_(false),
+ sparse_entry_(true),
+ truncated_(false),
+ core_(NULL),
+ callback_(NULL) {
+}
+
PartialData::~PartialData() {
if (core_)
core_->Cancel();
diff --git a/net/http/partial_data.h b/net/http/partial_data.h
index 45bef31..4726d10 100644
--- a/net/http/partial_data.h
+++ b/net/http/partial_data.h
@@ -31,9 +31,7 @@ class IOBuffer;
// of those individual network / cache requests.
class PartialData {
public:
- PartialData()
- : range_present_(false), final_range_(false), sparse_entry_(true),
- truncated_(false), core_(NULL), callback_(NULL) {}
+ PartialData();
~PartialData();
// Performs initialization of the object by examining the request |headers|
diff --git a/net/http/url_security_manager.cc b/net/http/url_security_manager.cc
index d848644..4ff0f65 100644
--- a/net/http/url_security_manager.cc
+++ b/net/http/url_security_manager.cc
@@ -15,6 +15,8 @@ URLSecurityManagerWhitelist::URLSecurityManagerWhitelist(
whitelist_delegate_(whitelist_delegate) {
}
+URLSecurityManagerWhitelist::~URLSecurityManagerWhitelist() {}
+
bool URLSecurityManagerWhitelist::CanUseDefaultCredentials(
const GURL& auth_origin) const {
if (whitelist_default_.get())
diff --git a/net/http/url_security_manager.h b/net/http/url_security_manager.h
index 5e148b4..c6a5ec9 100644
--- a/net/http/url_security_manager.h
+++ b/net/http/url_security_manager.h
@@ -61,6 +61,7 @@ class URLSecurityManagerWhitelist : public URLSecurityManager {
// The URLSecurityManagerWhitelist takes ownership of the whitelists.
URLSecurityManagerWhitelist(const HttpAuthFilter* whitelist_default,
const HttpAuthFilter* whitelist_delegation);
+ virtual ~URLSecurityManagerWhitelist();
// URLSecurityManager methods.
virtual bool CanUseDefaultCredentials(const GURL& auth_origin) const;
diff --git a/net/net.gyp b/net/net.gyp
index 699f093..2f19dbc 100644
--- a/net/net.gyp
+++ b/net/net.gyp
@@ -336,6 +336,7 @@
'disk_cache/cache_util_posix.cc',
'disk_cache/cache_util_win.cc',
'disk_cache/disk_cache.h',
+ 'disk_cache/disk_format.cc',
'disk_cache/disk_format.h',
'disk_cache/entry_impl.cc',
'disk_cache/entry_impl.h',
@@ -343,6 +344,7 @@
'disk_cache/eviction.cc',
'disk_cache/eviction.h',
'disk_cache/experiments.h',
+ 'disk_cache/file.cc',
'disk_cache/file.h',
'disk_cache/file_block.h',
'disk_cache/file_lock.cc',
@@ -399,6 +401,7 @@
'ftp/ftp_directory_listing_parser_windows.h',
'ftp/ftp_network_layer.cc',
'ftp/ftp_network_layer.h',
+ 'ftp/ftp_network_session.cc',
'ftp/ftp_network_session.h',
'ftp/ftp_network_transaction.cc',
'ftp/ftp_network_transaction.h',
@@ -454,6 +457,7 @@
'http/http_cache_transaction.h',
'http/http_chunked_decoder.cc',
'http/http_chunked_decoder.h',
+ 'http/http_net_log_params.cc',
'http/http_net_log_params.h',
'http/http_network_delegate.h',
'http/http_network_layer.cc',
diff --git a/net/proxy/proxy_resolver_script_data.cc b/net/proxy/proxy_resolver_script_data.cc
index fd8c399..0314fc3 100644
--- a/net/proxy/proxy_resolver_script_data.cc
+++ b/net/proxy/proxy_resolver_script_data.cc
@@ -45,4 +45,14 @@ const GURL& ProxyResolverScriptData::url() const {
return url_;
}
+ProxyResolverScriptData::ProxyResolverScriptData(Type type,
+ const GURL& url,
+ const string16& utf16)
+ : type_(type),
+ url_(url),
+ utf16_(utf16) {
+}
+
+ProxyResolverScriptData::~ProxyResolverScriptData() {}
+
} // namespace net
diff --git a/net/proxy/proxy_resolver_script_data.h b/net/proxy/proxy_resolver_script_data.h
index 72092e1..7b8118f 100644
--- a/net/proxy/proxy_resolver_script_data.h
+++ b/net/proxy/proxy_resolver_script_data.h
@@ -54,13 +54,12 @@ class ProxyResolverScriptData
const GURL& url() const;
private:
+ friend class base::RefCountedThreadSafe<ProxyResolverScriptData>;
ProxyResolverScriptData(Type type,
const GURL& url,
- const string16& utf16)
- : type_(type),
- url_(url),
- utf16_(utf16) {
- }
+ const string16& utf16);
+ virtual ~ProxyResolverScriptData();
+
const Type type_;
const GURL url_;
diff --git a/net/spdy/spdy_proxy_client_socket.cc b/net/spdy/spdy_proxy_client_socket.cc
index 9973f86..c8a0153 100644
--- a/net/spdy/spdy_proxy_client_socket.cc
+++ b/net/spdy/spdy_proxy_client_socket.cc
@@ -16,6 +16,7 @@
#include "net/http/http_auth_handler_factory.h"
#include "net/http/http_net_log_params.h"
#include "net/http/http_proxy_utils.h"
+#include "net/http/http_response_headers.h"
#include "net/spdy/spdy_http_utils.h"
namespace net {
diff --git a/net/url_request/url_request_job_manager.cc b/net/url_request/url_request_job_manager.cc
index 0615280..edc9f75 100644
--- a/net/url_request/url_request_job_manager.cc
+++ b/net/url_request/url_request_job_manager.cc
@@ -43,6 +43,8 @@ URLRequestJobManager::URLRequestJobManager() {
#endif
}
+URLRequestJobManager::~URLRequestJobManager() {}
+
URLRequestJob* URLRequestJobManager::CreateJob(URLRequest* request) const {
#ifndef NDEBUG
DCHECK(IsAllowedThread());
diff --git a/net/url_request/url_request_job_manager.h b/net/url_request/url_request_job_manager.h
index 51de77a..c93df76 100644
--- a/net/url_request/url_request_job_manager.h
+++ b/net/url_request/url_request_job_manager.h
@@ -27,6 +27,7 @@
class URLRequestJobManager {
public:
URLRequestJobManager();
+ ~URLRequestJobManager();
// Instantiate an URLRequestJob implementation based on the registered
// interceptors and protocol factories. This will always succeed in
diff --git a/net/url_request/url_request_job_metrics.cc b/net/url_request/url_request_job_metrics.cc
index e0726da..8e7b70b 100644
--- a/net/url_request/url_request_job_metrics.cc
+++ b/net/url_request/url_request_job_metrics.cc
@@ -10,6 +10,14 @@
using base::TimeDelta;
+URLRequestJobMetrics::URLRequestJobMetrics()
+ : total_bytes_read_(0),
+ number_of_read_IO_(0),
+ success_(false) {
+}
+
+URLRequestJobMetrics::~URLRequestJobMetrics() {}
+
void URLRequestJobMetrics::AppendText(std::wstring* text) {
if (!text)
return;
diff --git a/net/url_request/url_request_job_metrics.h b/net/url_request/url_request_job_metrics.h
index 2f52c7f..ce0e4bf 100644
--- a/net/url_request/url_request_job_metrics.h
+++ b/net/url_request/url_request_job_metrics.h
@@ -18,11 +18,8 @@
class URLRequestJobMetrics {
public:
- URLRequestJobMetrics()
- : total_bytes_read_(0),
- number_of_read_IO_(0),
- success_(false) { }
- ~URLRequestJobMetrics() { }
+ URLRequestJobMetrics();
+ ~URLRequestJobMetrics();
// The original url the job has been created for.
scoped_ptr<GURL> original_url_;
diff --git a/net/url_request/view_cache_helper.cc b/net/url_request/view_cache_helper.cc
index 92701b7..4a3ad02 100644
--- a/net/url_request/view_cache_helper.cc
+++ b/net/url_request/view_cache_helper.cc
@@ -73,6 +73,22 @@ std::string FormatEntryInfo(disk_cache::Entry* entry,
namespace net {
+ViewCacheHelper::ViewCacheHelper()
+ : disk_cache_(NULL),
+ entry_(NULL),
+ iter_(NULL),
+ buf_len_(0),
+ index_(0),
+ data_(NULL),
+ callback_(NULL),
+ next_state_(STATE_NONE),
+ ALLOW_THIS_IN_INITIALIZER_LIST(
+ cache_callback_(this, &ViewCacheHelper::OnIOComplete)),
+ ALLOW_THIS_IN_INITIALIZER_LIST(
+ entry_callback_(new CancelableCompletionCallback<ViewCacheHelper>(
+ this, &ViewCacheHelper::OnIOComplete))) {
+}
+
ViewCacheHelper::~ViewCacheHelper() {
if (entry_)
entry_->Close();
diff --git a/net/url_request/view_cache_helper.h b/net/url_request/view_cache_helper.h
index dd960a9..03af714 100644
--- a/net/url_request/view_cache_helper.h
+++ b/net/url_request/view_cache_helper.h
@@ -22,14 +22,7 @@ namespace net {
class ViewCacheHelper {
public:
- ViewCacheHelper()
- : disk_cache_(NULL), entry_(NULL), iter_(NULL), buf_len_(0), index_(0),
- data_(NULL), callback_(NULL), next_state_(STATE_NONE),
- ALLOW_THIS_IN_INITIALIZER_LIST(
- cache_callback_(this, &ViewCacheHelper::OnIOComplete)),
- ALLOW_THIS_IN_INITIALIZER_LIST(
- entry_callback_(new CancelableCompletionCallback<ViewCacheHelper>(
- this, &ViewCacheHelper::OnIOComplete))) {}
+ ViewCacheHelper();
~ViewCacheHelper();
// Formats the cache information for |key| as HTML. Returns a net error code.
diff --git a/remoting/base/encoder_zlib.cc b/remoting/base/encoder_zlib.cc
index 575d1f1..a36b8df 100644
--- a/remoting/base/encoder_zlib.cc
+++ b/remoting/base/encoder_zlib.cc
@@ -21,6 +21,8 @@ EncoderZlib::EncoderZlib() : packet_size_(kPacketSize) {
EncoderZlib::EncoderZlib(int packet_size) : packet_size_(packet_size) {
}
+EncoderZlib::~EncoderZlib() {}
+
void EncoderZlib::Encode(scoped_refptr<CaptureData> capture_data,
bool key_frame,
DataAvailableCallback* data_available_callback) {
diff --git a/remoting/base/encoder_zlib.h b/remoting/base/encoder_zlib.h
index 6ed83650..3d0a13e 100644
--- a/remoting/base/encoder_zlib.h
+++ b/remoting/base/encoder_zlib.h
@@ -20,7 +20,7 @@ class EncoderZlib : public Encoder {
EncoderZlib();
EncoderZlib(int packet_size);
- virtual ~EncoderZlib() {}
+ virtual ~EncoderZlib();
virtual void Encode(scoped_refptr<CaptureData> capture_data,
bool key_frame,
diff --git a/remoting/base/tracer.cc b/remoting/base/tracer.cc
index c9df2f0..29b2b62 100644
--- a/remoting/base/tracer.cc
+++ b/remoting/base/tracer.cc
@@ -13,6 +13,7 @@
#include "base/ref_counted.h"
#include "base/stl_util-inl.h"
#include "base/thread.h"
+#include "base/thread_local.h"
#include "base/time.h"
namespace remoting {
@@ -139,6 +140,46 @@ Tracer::~Tracer() {
}
}
+// static
+Tracer* TraceContext::tracer() {
+ return Get()->GetTracerInternal();
+}
+
+// static
+void TraceContext::PushTracer(Tracer* tracer) {
+ Get()->PushTracerInternal(tracer);
+}
+
+// static
+void TraceContext::PopTracer() {
+ Get()->PopTracerInternal();
+}
+
+// static
+TraceContext* TraceContext::Get() {
+ TraceContext* context =
+ Singleton<base::ThreadLocalPointer<TraceContext> >::get()->Get();
+ if (context == NULL) {
+ context = new TraceContext();
+ context->PushTracerInternal(new Tracer("default", 0.0));
+ Singleton<base::ThreadLocalPointer<TraceContext> >::get()->Set(context);
+ }
+ return context;
+}
+
+TraceContext::TraceContext() {}
+
+TraceContext::~TraceContext() {}
+
+void TraceContext::PushTracerInternal(Tracer* tracer) {
+ tracers_.push_back(tracer);
+}
+
+void TraceContext::PopTracerInternal() { tracers_.pop_back(); }
+
+Tracer* TraceContext::GetTracerInternal() { return tracers_.back(); }
+
+
} // namespace remoting
DISABLE_RUNNABLE_METHOD_REFCOUNT(remoting::OutputLogger);
diff --git a/remoting/base/tracer.h b/remoting/base/tracer.h
index 4333f25..95d4e9c 100644
--- a/remoting/base/tracer.h
+++ b/remoting/base/tracer.h
@@ -58,7 +58,6 @@
#include "base/singleton.h"
#include "base/task.h"
#include "base/scoped_ptr.h"
-#include "base/thread_local.h"
#include "remoting/proto/trace.pb.h"
namespace remoting {
@@ -92,40 +91,24 @@ class Tracer : public base::RefCountedThreadSafe<Tracer> {
class TraceContext {
public:
// Get the current tracer.
- static Tracer* tracer() {
- return Get()->GetTracerInternal();
- }
+ static Tracer* tracer();
- static void PushTracer(Tracer* tracer) {
- Get()->PushTracerInternal(tracer);
- }
+ static void PushTracer(Tracer* tracer);
- static void PopTracer() {
- Get()->PopTracerInternal();
- }
+ static void PopTracer();
- static TraceContext* Get() {
- TraceContext* context =
- Singleton<base::ThreadLocalPointer<TraceContext> >::get()->Get();
- if (context == NULL) {
- context = new TraceContext();
- context->PushTracerInternal(new Tracer("default", 0.0));
- Singleton<base::ThreadLocalPointer<TraceContext> >::get()->Set(context);
- }
- return context;
- }
+ static TraceContext* Get();
private:
- TraceContext() {
- }
+ TraceContext();
- ~TraceContext() {}
+ ~TraceContext();
- void PushTracerInternal(Tracer* tracer) { tracers_.push_back(tracer); }
+ void PushTracerInternal(Tracer* tracer);
- void PopTracerInternal() { tracers_.pop_back(); }
+ void PopTracerInternal();
- Tracer* GetTracerInternal() { return tracers_.back(); }
+ Tracer* GetTracerInternal();
std::vector<scoped_refptr<Tracer> > tracers_;
diff --git a/remoting/host/client_connection.cc b/remoting/host/client_connection.cc
index 8c8bc94..57554f4 100644
--- a/remoting/host/client_connection.cc
+++ b/remoting/host/client_connection.cc
@@ -76,6 +76,8 @@ void ClientConnection::Disconnect() {
}
}
+ClientConnection::ClientConnection() {}
+
void ClientConnection::OnConnectionStateChange(
ChromotingConnection::State state) {
if (state == ChromotingConnection::CONNECTED) {
diff --git a/remoting/host/client_connection.h b/remoting/host/client_connection.h
index 6eb6b0d..daac392 100644
--- a/remoting/host/client_connection.h
+++ b/remoting/host/client_connection.h
@@ -87,7 +87,7 @@ class ClientConnection : public base::RefCountedThreadSafe<ClientConnection> {
protected:
// Protected constructor used by unit test.
- ClientConnection() {}
+ ClientConnection();
private:
// Callback for ChromotingConnection.
diff --git a/remoting/host/differ.cc b/remoting/host/differ.cc
index 3409e0f..c7d28b0 100644
--- a/remoting/host/differ.cc
+++ b/remoting/host/differ.cc
@@ -23,6 +23,8 @@ Differ::Differ(int width, int height, int bpp, int stride) {
diff_info_.reset(new uint8[diff_info_size_]);
}
+Differ::~Differ() {}
+
void Differ::CalcDirtyRects(const void* prev_buffer, const void* curr_buffer,
InvalidRects* rects) {
if (!rects) {
diff --git a/remoting/host/differ.h b/remoting/host/differ.h
index 1476cdb..ce76572 100644
--- a/remoting/host/differ.h
+++ b/remoting/host/differ.h
@@ -25,6 +25,7 @@ class Differ {
// Create a differ that operates on bitmaps with the specified width, height
// and bytes_per_pixel.
Differ(int width, int height, int bytes_per_pixel, int stride);
+ ~Differ();
// Given the previous and current screen buffer, calculate the set of
// rectangles that enclose all the changed pixels in the new screen.
diff --git a/remoting/host/in_memory_host_config.cc b/remoting/host/in_memory_host_config.cc
index 2450638..e0cf120 100644
--- a/remoting/host/in_memory_host_config.cc
+++ b/remoting/host/in_memory_host_config.cc
@@ -13,6 +13,8 @@ InMemoryHostConfig::InMemoryHostConfig()
: values_(new DictionaryValue()) {
}
+InMemoryHostConfig::~InMemoryHostConfig() {}
+
bool InMemoryHostConfig::GetString(const std::string& path,
std::string* out_value) {
AutoLock auto_lock(lock_);
diff --git a/remoting/host/in_memory_host_config.h b/remoting/host/in_memory_host_config.h
index 6a44e39..511998d 100644
--- a/remoting/host/in_memory_host_config.h
+++ b/remoting/host/in_memory_host_config.h
@@ -7,7 +7,6 @@
#include <string>
-#include "base/file_path.h"
#include "base/lock.h"
#include "base/ref_counted.h"
#include "base/scoped_ptr.h"
@@ -22,6 +21,7 @@ namespace remoting {
class InMemoryHostConfig : public MutableHostConfig {
public:
InMemoryHostConfig();
+ virtual ~InMemoryHostConfig();
// MutableHostConfig interface.
virtual bool GetString(const std::string& path, std::string* out_value);
diff --git a/remoting/host/json_host_config.cc b/remoting/host/json_host_config.cc
index 897402c..f97b343 100644
--- a/remoting/host/json_host_config.cc
+++ b/remoting/host/json_host_config.cc
@@ -21,6 +21,8 @@ JsonHostConfig::JsonHostConfig(
message_loop_proxy_(file_message_loop_proxy) {
}
+JsonHostConfig::~JsonHostConfig() {}
+
bool JsonHostConfig::Read() {
// TODO(sergeyu): Implement better error handling here.
std::string file_content;
diff --git a/remoting/host/json_host_config.h b/remoting/host/json_host_config.h
index b136cdf..dc892e9 100644
--- a/remoting/host/json_host_config.h
+++ b/remoting/host/json_host_config.h
@@ -27,6 +27,7 @@ class JsonHostConfig : public MutableHostConfig {
public:
JsonHostConfig(const FilePath& pref_filename,
base::MessageLoopProxy* file_message_loop_proxy);
+ virtual ~JsonHostConfig();
virtual bool Read();
diff --git a/remoting/protocol/messages_decoder.cc b/remoting/protocol/messages_decoder.cc
index f7c7439..73e9ea4 100644
--- a/remoting/protocol/messages_decoder.cc
+++ b/remoting/protocol/messages_decoder.cc
@@ -5,6 +5,7 @@
#include "remoting/protocol/messages_decoder.h"
#include "base/logging.h"
+#include "net/base/io_buffer.h"
#include "remoting/base/multiple_array_input_stream.h"
#include "talk/base/byteorder.h"
@@ -31,6 +32,13 @@ void MessagesDecoder::ParseHostMessages(scoped_refptr<net::IOBuffer> data,
ParseMessages<ChromotingHostMessage>(data, data_size, messages);
}
+MessagesDecoder::DataChunk::DataChunk(net::IOBuffer* data, size_t data_size)
+ : data(data),
+ data_size(data_size) {
+}
+
+MessagesDecoder::DataChunk::~DataChunk() {}
+
template <typename T>
void MessagesDecoder::ParseMessages(scoped_refptr<net::IOBuffer> data,
int data_size,
diff --git a/remoting/protocol/messages_decoder.h b/remoting/protocol/messages_decoder.h
index ea1b2c5..b22f6ba 100644
--- a/remoting/protocol/messages_decoder.h
+++ b/remoting/protocol/messages_decoder.h
@@ -10,9 +10,12 @@
#include "base/ref_counted.h"
#include "google/protobuf/message_lite.h"
-#include "net/base/io_buffer.h"
#include "remoting/proto/internal.pb.h"
+namespace net {
+class IOBuffer;
+}
+
namespace remoting {
typedef std::list<ChromotingHostMessage*> HostMessageList;
@@ -42,10 +45,8 @@ class MessagesDecoder {
// DataChunk stores reference to a net::IOBuffer and size of the data
// stored in that buffer.
struct DataChunk {
- DataChunk(net::IOBuffer* data, size_t data_size)
- : data(data),
- data_size(data_size) {
- }
+ DataChunk(net::IOBuffer* data, size_t data_size);
+ ~DataChunk();
scoped_refptr<net::IOBuffer> data;
size_t data_size;
diff --git a/remoting/protocol/stream_reader.cc b/remoting/protocol/stream_reader.cc
index bfceb3e..63786e4 100644
--- a/remoting/protocol/stream_reader.cc
+++ b/remoting/protocol/stream_reader.cc
@@ -5,6 +5,7 @@
#include "remoting/protocol/stream_reader.h"
#include "base/message_loop.h"
+#include "net/base/io_buffer.h"
#include "net/base/net_errors.h"
#include "net/socket/socket.h"
#include "remoting/protocol/chromoting_connection.h"
diff --git a/webkit/glue/media/media_resource_loader_bridge_factory.cc b/webkit/glue/media/media_resource_loader_bridge_factory.cc
index 9d8d547..3fb9d65 100644
--- a/webkit/glue/media/media_resource_loader_bridge_factory.cc
+++ b/webkit/glue/media/media_resource_loader_bridge_factory.cc
@@ -32,6 +32,8 @@ MediaResourceLoaderBridgeFactory::MediaResourceLoaderBridgeFactory(
routing_id_(routing_id) {
}
+MediaResourceLoaderBridgeFactory::~MediaResourceLoaderBridgeFactory() {}
+
ResourceLoaderBridge* MediaResourceLoaderBridgeFactory::CreateBridge(
const GURL& url,
int load_flags,
@@ -54,6 +56,8 @@ ResourceLoaderBridge* MediaResourceLoaderBridgeFactory::CreateBridge(
return webkit_glue::ResourceLoaderBridge::Create(request_info);
}
+MediaResourceLoaderBridgeFactory::MediaResourceLoaderBridgeFactory() {}
+
// static
const std::string MediaResourceLoaderBridgeFactory::GenerateHeaders (
int64 first_byte_position, int64 last_byte_position) {
diff --git a/webkit/glue/media/media_resource_loader_bridge_factory.h b/webkit/glue/media/media_resource_loader_bridge_factory.h
index 5f09235..ccacdc6 100644
--- a/webkit/glue/media/media_resource_loader_bridge_factory.h
+++ b/webkit/glue/media/media_resource_loader_bridge_factory.h
@@ -24,7 +24,7 @@ class MediaResourceLoaderBridgeFactory {
int appcache_host_id,
int32 routing_id);
- virtual ~MediaResourceLoaderBridgeFactory() {}
+ virtual ~MediaResourceLoaderBridgeFactory();
// Factory method to create a ResourceLoaderBridge with the following
// parameters:
@@ -40,8 +40,7 @@ class MediaResourceLoaderBridgeFactory {
protected:
// An empty constructor only used by inherited classes.
- MediaResourceLoaderBridgeFactory() {
- }
+ MediaResourceLoaderBridgeFactory();
private:
FRIEND_TEST_ALL_PREFIXES(MediaResourceLoaderBridgeFactoryTest,
diff --git a/webkit/glue/plugins/gtk_plugin_container_manager.cc b/webkit/glue/plugins/gtk_plugin_container_manager.cc
index f26b44c..2f82b24 100644
--- a/webkit/glue/plugins/gtk_plugin_container_manager.cc
+++ b/webkit/glue/plugins/gtk_plugin_container_manager.cc
@@ -11,6 +11,10 @@
#include "webkit/glue/plugins/gtk_plugin_container.h"
#include "webkit/glue/plugins/webplugin.h"
+GtkPluginContainerManager::GtkPluginContainerManager() : host_widget_(NULL) {}
+
+GtkPluginContainerManager::~GtkPluginContainerManager() {}
+
GtkWidget* GtkPluginContainerManager::CreatePluginContainer(
gfx::PluginWindowHandle id) {
DCHECK(host_widget_);
diff --git a/webkit/glue/plugins/gtk_plugin_container_manager.h b/webkit/glue/plugins/gtk_plugin_container_manager.h
index c33099d..7f7db8d 100644
--- a/webkit/glue/plugins/gtk_plugin_container_manager.h
+++ b/webkit/glue/plugins/gtk_plugin_container_manager.h
@@ -19,7 +19,8 @@ struct WebPluginGeometry;
// Helper class that creates and manages plugin containers (GtkSocket).
class GtkPluginContainerManager {
public:
- GtkPluginContainerManager() : host_widget_(NULL) { }
+ GtkPluginContainerManager();
+ ~GtkPluginContainerManager();
// Sets the widget that will host the plugin containers. Must be a GtkFixed.
void set_host_widget(GtkWidget *widget) { host_widget_ = widget; }
diff --git a/webkit/glue/plugins/pepper_string.cc b/webkit/glue/plugins/pepper_string.cc
new file mode 100644
index 0000000..53c8943
--- /dev/null
+++ b/webkit/glue/plugins/pepper_string.cc
@@ -0,0 +1,13 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "webkit/glue/plugins/pepper_string.h"
+
+namespace pepper {
+
+String::String(const char* str, uint32 len) : value_(str, len) {}
+
+String::~String() {}
+
+} // namespace pepper
diff --git a/webkit/glue/plugins/pepper_string.h b/webkit/glue/plugins/pepper_string.h
index 1fc43c4f..fa1ab2ff 100644
--- a/webkit/glue/plugins/pepper_string.h
+++ b/webkit/glue/plugins/pepper_string.h
@@ -14,8 +14,8 @@ namespace pepper {
class String : public base::RefCountedThreadSafe<String> {
public:
- String(const char* str, uint32 len) : value_(str, len) {
- }
+ String(const char* str, uint32 len);
+ virtual ~String();
const std::string& value() const { return value_; }
diff --git a/webkit/glue/plugins/pepper_webplugin_impl.cc b/webkit/glue/plugins/pepper_webplugin_impl.cc
index ef01c6a..2e8eb3f 100644
--- a/webkit/glue/plugins/pepper_webplugin_impl.cc
+++ b/webkit/glue/plugins/pepper_webplugin_impl.cc
@@ -29,6 +29,13 @@ using WebKit::WebView;
namespace pepper {
+struct WebPluginImpl::InitData {
+ scoped_refptr<PluginModule> module;
+ base::WeakPtr<PluginDelegate> delegate;
+ std::vector<std::string> arg_names;
+ std::vector<std::string> arg_values;
+};
+
WebPluginImpl::WebPluginImpl(
PluginModule* plugin_module,
const WebPluginParams& params,
diff --git a/webkit/glue/plugins/pepper_webplugin_impl.h b/webkit/glue/plugins/pepper_webplugin_impl.h
index 3023d95..15ee784 100644
--- a/webkit/glue/plugins/pepper_webplugin_impl.h
+++ b/webkit/glue/plugins/pepper_webplugin_impl.h
@@ -76,12 +76,7 @@ class WebPluginImpl : public WebKit::WebPlugin {
virtual bool printPage(int page_number, WebKit::WebCanvas* canvas);
virtual void printEnd();
- struct InitData {
- scoped_refptr<PluginModule> module;
- base::WeakPtr<PluginDelegate> delegate;
- std::vector<std::string> arg_names;
- std::vector<std::string> arg_values;
- };
+ struct InitData;
scoped_ptr<InitData> init_data_; // Cleared upon successful initialization.
// True if the instance represents the entire document in a frame instead of
diff --git a/webkit/glue/webkit_glue.gypi b/webkit/glue/webkit_glue.gypi
index e8e1a3e..4f760f0 100644
--- a/webkit/glue/webkit_glue.gypi
+++ b/webkit/glue/webkit_glue.gypi
@@ -197,8 +197,8 @@
'plugins/pepper_cursor_control.h',
'plugins/pepper_directory_reader.cc',
'plugins/pepper_directory_reader.h',
- 'plugins/pepper_error_util.cc',
- 'plugins/pepper_error_util.h',
+ 'plugins/pepper_error_util.cc',
+ 'plugins/pepper_error_util.h',
'plugins/pepper_event_conversion.cc',
'plugins/pepper_event_conversion.h',
'plugins/pepper_file_chooser.cc',
@@ -233,6 +233,8 @@
'plugins/pepper_resource.h',
'plugins/pepper_scrollbar.cc',
'plugins/pepper_scrollbar.h',
+ 'plugins/pepper_string.cc',
+ 'plugins/pepper_string.h',
'plugins/pepper_transport.cc',
'plugins/pepper_transport.h',
'plugins/pepper_url_loader.cc',
diff --git a/webkit/glue/webvideoframe_impl.cc b/webkit/glue/webvideoframe_impl.cc
index 4d1cd72..bfb1d53 100644
--- a/webkit/glue/webvideoframe_impl.cc
+++ b/webkit/glue/webvideoframe_impl.cc
@@ -25,6 +25,8 @@ WebVideoFrameImpl::WebVideoFrameImpl(
: video_frame_(video_frame) {
}
+WebVideoFrameImpl::~WebVideoFrameImpl() {}
+
#define COMPILE_ASSERT_MATCHING_ENUM(webkit_name, chromium_name) \
COMPILE_ASSERT(int(WebKit::WebVideoFrame::webkit_name) == \
int(media::VideoFrame::chromium_name), \
diff --git a/webkit/glue/webvideoframe_impl.h b/webkit/glue/webvideoframe_impl.h
index dfaac03..5454089 100644
--- a/webkit/glue/webvideoframe_impl.h
+++ b/webkit/glue/webvideoframe_impl.h
@@ -18,6 +18,7 @@ class WebVideoFrameImpl : public WebVideoFrame {
static media::VideoFrame* toVideoFrame(WebVideoFrame* web_video_frame);
WebVideoFrameImpl(scoped_refptr<media::VideoFrame> video_frame);
+ virtual ~WebVideoFrameImpl();
virtual WebVideoFrame::SurfaceType surfaceType() const;
virtual WebVideoFrame::Format format() const;
virtual unsigned width() const;