diff options
| author | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-15 21:29:35 +0000 |
|---|---|---|
| committer | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-15 21:29:35 +0000 |
| commit | a58bcd1c302668eea7f8eda3de75acd1f16f3f6a (patch) | |
| tree | 910c2abf95307fed6b29bfe11c0b6c5355963e6c | |
| parent | 8106eed707686841e8734e33467689117fcd9154 (diff) | |
| download | chromium_src-a58bcd1c302668eea7f8eda3de75acd1f16f3f6a.zip chromium_src-a58bcd1c302668eea7f8eda3de75acd1f16f3f6a.tar.gz chromium_src-a58bcd1c302668eea7f8eda3de75acd1f16f3f6a.tar.bz2 | |
Valgrind/Heapchecker: Check for accidental copy/paste in suppression files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7645008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96838 0039d316-1c4b-4281-b951-d872f2087c98
| -rwxr-xr-x | tools/heapcheck/PRESUBMIT.py | 3 | ||||
| -rwxr-xr-x | tools/valgrind/memcheck/PRESUBMIT.py | 3 |
2 files changed, 6 insertions, 0 deletions
diff --git a/tools/heapcheck/PRESUBMIT.py b/tools/heapcheck/PRESUBMIT.py index 77dc66b..075dd1c 100755 --- a/tools/heapcheck/PRESUBMIT.py +++ b/tools/heapcheck/PRESUBMIT.py @@ -25,6 +25,9 @@ def CheckChange(input_api, output_api): continue if skip_next_line: + if 'insert_a_suppression_name_here' in line: + errors.append('"insert_a_suppression_name_here" is not a valid ' + 'suppression name') if suppressions.has_key(line): errors.append('suppression with name "%s" at %s line %s has already ' 'been defined at line %s' % (line, f.LocalPath(), diff --git a/tools/valgrind/memcheck/PRESUBMIT.py b/tools/valgrind/memcheck/PRESUBMIT.py index ad1d2c16..512da0b 100755 --- a/tools/valgrind/memcheck/PRESUBMIT.py +++ b/tools/valgrind/memcheck/PRESUBMIT.py @@ -30,6 +30,9 @@ def CheckChange(input_api, output_api): if skip_next_line: if skip_next_line == 'skip_suppression_name': + if 'insert_a_suppression_name_here' in line: + errors.append('"insert_a_suppression_name_here" is not a valid ' + 'suppression name') if suppressions.has_key(line): if f.LocalPath() == suppressions[line][1]: errors.append('suppression with name "%s" at %s line %s ' |