diff options
author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-15 17:51:43 +0000 |
---|---|---|
committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-15 17:51:43 +0000 |
commit | 562016345565bf1fa5c44bd8dc002c01e8310e46 (patch) | |
tree | e45321242074b20b7a2ec41e1d7087a178b40cbd | |
parent | d4d5b0c58002f683d74cc0c50a1717122be16a56 (diff) | |
download | chromium_src-562016345565bf1fa5c44bd8dc002c01e8310e46.zip chromium_src-562016345565bf1fa5c44bd8dc002c01e8310e46.tar.gz chromium_src-562016345565bf1fa5c44bd8dc002c01e8310e46.tar.bz2 |
Uncomment a different third IPC hook for about:profiler
If this causes ASAN problems with browser tests, then
I'll revert it.
Tests to watch out for (on ASAN bot) are:
IncognitoSplitMode
TwoExtensionsCrashBothAtOnce
TwoExtensionsOneByOne
AutoUpdate
CognitoNoFile
IncognitoNoFile
OnChangedNotificationsBetweenBackgroundPages
SplitModeIncognito
So far, I've uncommented two hooks, with no
problems ;-). One of these hooks will illuminate
the problems.
r=rtenneti
BUG=103830
Review URL: http://codereview.chromium.org/8463033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110114 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | ipc/ipc_message_macros.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ipc/ipc_message_macros.h b/ipc/ipc_message_macros.h index bcc4e57..27fcf83 100644 --- a/ipc/ipc_message_macros.h +++ b/ipc/ipc_message_macros.h @@ -954,7 +954,7 @@ LogFunctionMap g_log_function_mapping; #define IPC_MESSAGE_FORWARD_DELAY_REPLY(msg_class, obj, member_func) \ case msg_class::ID: { \ - /* TRACK_RUN_IN_IPC_HANDLER(member_func); TODO(jar) */ \ + TRACK_RUN_IN_IPC_HANDLER(member_func); \ msg_is_ok__ = msg_class::DispatchDelayReply(&ipc_message__, obj, \ &member_func); \ } \ @@ -964,6 +964,7 @@ LogFunctionMap g_log_function_mapping; IPC_MESSAGE_FORWARD_DELAY_REPLY(msg_class, this, \ _IpcMessageHandlerClass::member_func) +// TODO(jar): fix chrome frame to always supply |code| argument. #define IPC_MESSAGE_HANDLER_GENERIC(msg_class, code) \ case msg_class::ID: { \ /* TRACK_RUN_IN_IPC_HANDLER(code); TODO(jar) */ \ @@ -981,7 +982,6 @@ LogFunctionMap g_log_function_mapping; #define IPC_MESSAGE_UNHANDLED(code) \ default: { \ - /* TRACK_RUN_IN_IPC_HANDLER(code); TODO(jar) */ \ code; \ } \ break; |