summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsunandt@google.com <sunandt@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2011-04-04 23:30:45 +0000
committersunandt@google.com <sunandt@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2011-04-04 23:30:45 +0000
commita45fccc4ea2ed47b8a6658f68e39caab22a0a64e (patch)
tree0a59be08cf7dcf7e165fc182f03c167f1c47f711
parent9f489d785d446e061736d23fa1bb0b3cc8f50efc (diff)
downloadchromium_src-a45fccc4ea2ed47b8a6658f68e39caab22a0a64e.zip
chromium_src-a45fccc4ea2ed47b8a6658f68e39caab22a0a64e.tar.gz
chromium_src-a45fccc4ea2ed47b8a6658f68e39caab22a0a64e.tar.bz2
Trying a workaround to fix the falkiness of a popup test using incognito window.
BUG=70659 TEST=none Review URL: http://codereview.chromium.org/6794033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80393 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/test/functional/popups.py12
1 files changed, 12 insertions, 0 deletions
diff --git a/chrome/test/functional/popups.py b/chrome/test/functional/popups.py
index fc25a73..f2570b1 100644
--- a/chrome/test/functional/popups.py
+++ b/chrome/test/functional/popups.py
@@ -5,6 +5,7 @@
# found in the LICENSE file.
import os
+import logging
import pyauto_functional # Must be imported before pyauto
import pyauto
@@ -66,6 +67,17 @@ class PopupsTest(pyauto.PyUITest):
file_url = self.GetFileURLForPath(os.path.join(
self.DataDir(), 'popup_blocker', 'popup-window-open.html'))
self.NavigateToURL(file_url, 1, 0)
+ # TODO(sunandt): Work around for debugging the flakiness
+ # Related to crbug.com/64274
+ attempts = 0
+ while attempts < 3:
+ if self.GetActiveTabTitle(window_index=1) != \
+ 'Popup created using window.open':
+ logging.debug('Attempt %s' % attempts+1)
+ self.NavigateToURL(file_url, 1, 0)
+ attempts = attempts + 1
+ else:
+ break
self.assertEquals('Popup created using window.open',
self.GetActiveTabTitle(window_index=1))
# Wait until the popup is blocked