diff options
| author | jstritar@chromium.org <jstritar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-27 20:42:55 +0000 |
|---|---|---|
| committer | jstritar@chromium.org <jstritar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-27 20:42:55 +0000 |
| commit | 0753302962c0f671de00bfe0005b384ca055f99b (patch) | |
| tree | 426b3be865443e5de8fed155b98097bd87a6ded2 | |
| parent | ec2f77082b2c23254393ee8f6fd71db79eaa0f43 (diff) | |
| download | chromium_src-0753302962c0f671de00bfe0005b384ca055f99b.zip chromium_src-0753302962c0f671de00bfe0005b384ca055f99b.tar.gz chromium_src-0753302962c0f671de00bfe0005b384ca055f99b.tar.bz2 | |
Do not record extension install histograms for upgrades.
This ensures that the Extensions.Permissions_Install and Extensions.InstallType histograms are only recorded for installs, and not upgrades.
BUG=87469
TEST=about:histograms/Extensions
Review URL: http://codereview.chromium.org/7272005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90635 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/extensions/extension_service.cc | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc index a8973f6..4bc2c20 100644 --- a/chrome/browser/extensions/extension_service.cc +++ b/chrome/browser/extensions/extension_service.cc @@ -2055,10 +2055,14 @@ void ExtensionService::OnExtensionInstalled(const Extension* extension) { } } - UMA_HISTOGRAM_ENUMERATION("Extensions.InstallType", - extension->GetType(), 100); - RecordPermissionMessagesHistogram( - extension, "Extensions.Permissions_Install"); + // Do not record the install histograms for upgrades. + if (!GetExtensionByIdInternal(extension->id(), true, true, false)) { + UMA_HISTOGRAM_ENUMERATION("Extensions.InstallType", + extension->GetType(), 100); + RecordPermissionMessagesHistogram( + extension, "Extensions.Permissions_Install"); + } + ShownSectionsHandler::OnExtensionInstalled(profile_->GetPrefs(), extension); extension_prefs_->OnExtensionInstalled( extension, initial_enable ? Extension::ENABLED : Extension::DISABLED); |