summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormattm@chromium.org <mattm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-28 00:12:36 +0000
committermattm@chromium.org <mattm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-28 00:12:36 +0000
commit306ee6bc3a0624d301c6577bf5fbbe4e0885f4a7 (patch)
tree868b4b62fee920fc7611d32fdf960ec6be48f8f3
parent8ec5d5603c0548afdcae306f792a5989eaddf69d (diff)
downloadchromium_src-306ee6bc3a0624d301c6577bf5fbbe4e0885f4a7.zip
chromium_src-306ee6bc3a0624d301c6577bf5fbbe4e0885f4a7.tar.gz
chromium_src-306ee6bc3a0624d301c6577bf5fbbe4e0885f4a7.tar.bz2
Revert 123833 - Merge 123620 - Set SSLInfo.client_cert_sent when origin bound cert was sent.
BUG=115376 TEST=none Review URL: http://codereview.chromium.org/9454025 TBR=mattm@chromium.org Review URL: https://chromiumcodereview.appspot.com/9478016 TBR=mattm@chromium.org Review URL: https://chromiumcodereview.appspot.com/9478017 git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@123836 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--net/socket/socket_test_util.cc3
-rw-r--r--net/socket/ssl_client_socket_mac.cc4
-rw-r--r--net/socket/ssl_client_socket_nss.cc4
-rw-r--r--net/socket/ssl_client_socket_openssl.cc4
-rw-r--r--net/socket/ssl_client_socket_win.cc4
5 files changed, 9 insertions, 10 deletions
diff --git a/net/socket/socket_test_util.cc b/net/socket/socket_test_util.cc
index 46ad9a5..b8ac5ad 100644
--- a/net/socket/socket_test_util.cc
+++ b/net/socket/socket_test_util.cc
@@ -1119,8 +1119,7 @@ base::TimeDelta MockSSLClientSocket::GetConnectTimeMicros() const {
void MockSSLClientSocket::GetSSLInfo(SSLInfo* ssl_info) {
ssl_info->Reset();
ssl_info->cert = data_->cert;
- ssl_info->client_cert_sent = WasOriginBoundCertSent() ||
- data_->client_cert_sent;
+ ssl_info->client_cert_sent = data_->client_cert_sent;
}
void MockSSLClientSocket::GetSSLCertRequestInfo(
diff --git a/net/socket/ssl_client_socket_mac.cc b/net/socket/ssl_client_socket_mac.cc
index 0b1248d..824b447 100644
--- a/net/socket/ssl_client_socket_mac.cc
+++ b/net/socket/ssl_client_socket_mac.cc
@@ -724,8 +724,8 @@ void SSLClientSocketMac::GetSSLInfo(SSLInfo* ssl_info) {
ssl_info->public_key_hashes = server_cert_verify_result_.public_key_hashes;
ssl_info->is_issued_by_known_root =
server_cert_verify_result_.is_issued_by_known_root;
- ssl_info->client_cert_sent = WasOriginBoundCertSent() ||
- (ssl_config_.send_client_cert && ssl_config_.client_cert);
+ ssl_info->client_cert_sent =
+ ssl_config_.send_client_cert && ssl_config_.client_cert;
// security info
SSLCipherSuite suite;
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc
index b171beb..6c70615 100644
--- a/net/socket/ssl_client_socket_nss.cc
+++ b/net/socket/ssl_client_socket_nss.cc
@@ -500,8 +500,8 @@ void SSLClientSocketNSS::GetSSLInfo(SSLInfo* ssl_info) {
}
ssl_info->is_issued_by_known_root =
server_cert_verify_result_->is_issued_by_known_root;
- ssl_info->client_cert_sent = WasOriginBoundCertSent() ||
- (ssl_config_.send_client_cert && ssl_config_.client_cert);
+ ssl_info->client_cert_sent =
+ ssl_config_.send_client_cert && ssl_config_.client_cert;
PRUint16 cipher_suite =
SSLConnectionStatusToCipherSuite(ssl_connection_status_);
diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc
index 7aba143..d308e4c 100644
--- a/net/socket/ssl_client_socket_openssl.cc
+++ b/net/socket/ssl_client_socket_openssl.cc
@@ -587,8 +587,8 @@ void SSLClientSocketOpenSSL::GetSSLInfo(SSLInfo* ssl_info) {
server_cert_verify_result_.is_issued_by_known_root;
ssl_info->public_key_hashes =
server_cert_verify_result_.public_key_hashes;
- ssl_info->client_cert_sent = WasOriginBoundCertSent() ||
- (ssl_config_.send_client_cert && ssl_config_.client_cert);
+ ssl_info->client_cert_sent =
+ ssl_config_.send_client_cert && ssl_config_.client_cert;
const SSL_CIPHER* cipher = SSL_get_current_cipher(ssl_);
CHECK(cipher);
diff --git a/net/socket/ssl_client_socket_win.cc b/net/socket/ssl_client_socket_win.cc
index 9c3c439..e2509f2 100644
--- a/net/socket/ssl_client_socket_win.cc
+++ b/net/socket/ssl_client_socket_win.cc
@@ -427,8 +427,8 @@ void SSLClientSocketWin::GetSSLInfo(SSLInfo* ssl_info) {
ssl_info->public_key_hashes = server_cert_verify_result_.public_key_hashes;
ssl_info->is_issued_by_known_root =
server_cert_verify_result_.is_issued_by_known_root;
- ssl_info->client_cert_sent = WasOriginBoundCertSent() ||
- (ssl_config_.send_client_cert && ssl_config_.client_cert);
+ ssl_info->client_cert_sent =
+ ssl_config_.send_client_cert && ssl_config_.client_cert;
SecPkgContext_ConnectionInfo connection_info;
SECURITY_STATUS status = QueryContextAttributes(
&ctxt_, SECPKG_ATTR_CONNECTION_INFO, &connection_info);