summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-04-28 08:09:17 +0000
committerbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-04-28 08:09:17 +0000
commit44bbfd8d22cf61e7865f53c2ee9c19ad11c01f65 (patch)
tree199fc8d6665c761b1737612b017e6fbdda22271a
parent329581b6dbfa4ad0ca1013d0407e202b8dffed77 (diff)
downloadchromium_src-44bbfd8d22cf61e7865f53c2ee9c19ad11c01f65.zip
chromium_src-44bbfd8d22cf61e7865f53c2ee9c19ad11c01f65.tar.gz
chromium_src-44bbfd8d22cf61e7865f53c2ee9c19ad11c01f65.tar.bz2
Fix PageLoadTest.Reliability which I broke in my previous checkin to make the
throbber more responsive. The issue is that I changed the meaning of LOAD_START from indicating that the renderer started loading to indicating when the browser told the renderer to start loading. This means it now looks like we started loading "about:crash" whereas before it didn't. I think this change is reasonable and how we could about:crash in this respect isn't important, so I just removed the failing checks. Review URL: http://codereview.chromium.org/99118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14720 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/test/reliability/page_load_test.cc6
1 files changed, 1 insertions, 5 deletions
diff --git a/chrome/test/reliability/page_load_test.cc b/chrome/test/reliability/page_load_test.cc
index 6bb0631..1dc71be 100644
--- a/chrome/test/reliability/page_load_test.cc
+++ b/chrome/test/reliability/page_load_test.cc
@@ -338,17 +338,13 @@ class PageLoadTest : public UITest {
// Go to "about:crash"
NavigateToURLLogResult(GURL(crash_url), log_file, &metrics);
- // Page load crashed and test automation timed out.
- EXPECT_EQ(NAVIGATION_TIME_OUT, metrics.result);
// Found a crash dump
EXPECT_EQ(1, metrics.crash_dump_count) << kFailedNoCrashService;
// Browser did not crash, and exited cleanly.
EXPECT_EQ(true, metrics.browser_clean_exit);
EXPECT_EQ(1, metrics.browser_launch_count);
- // Only starting page was loaded.
- EXPECT_EQ(1, metrics.page_load_count);
+ // Only the renderer should have crashed.
EXPECT_EQ(0, metrics.browser_crash_count);
- // Renderer crashed.
EXPECT_EQ(1, metrics.renderer_crash_count);
EXPECT_EQ(0, metrics.plugin_crash_count);