diff options
| author | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-28 15:24:28 +0000 |
|---|---|---|
| committer | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-28 15:24:28 +0000 |
| commit | 6388155e5f1d771c2b0975af7b86d7965712da8d (patch) | |
| tree | 655e7b48c50a7d90daf9d8ff80adc199d2b64719 | |
| parent | 46d77a16ff5c6617e665ab5ac58217f1f8d0c4cd (diff) | |
| download | chromium_src-6388155e5f1d771c2b0975af7b86d7965712da8d.zip chromium_src-6388155e5f1d771c2b0975af7b86d7965712da8d.tar.gz chromium_src-6388155e5f1d771c2b0975af7b86d7965712da8d.tar.bz2 | |
Use a PDF for the upgrade dot.
BUG=http://crbug.com/49668
TEST=turn up resolution; make sure dot is crisp and clear
Review URL: http://codereview.chromium.org/3066009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53943 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/app/theme/upgrade_dot.pdf | bin | 0 -> 4672 bytes | |||
| -rw-r--r-- | chrome/browser/cocoa/toolbar_controller.mm | 9 | ||||
| -rw-r--r-- | chrome/chrome_dll.gypi | 1 |
3 files changed, 2 insertions, 8 deletions
diff --git a/chrome/app/theme/upgrade_dot.pdf b/chrome/app/theme/upgrade_dot.pdf Binary files differnew file mode 100644 index 0000000..27c54a9 --- /dev/null +++ b/chrome/app/theme/upgrade_dot.pdf diff --git a/chrome/browser/cocoa/toolbar_controller.mm b/chrome/browser/cocoa/toolbar_controller.mm index a2abf32..8d5e684 100644 --- a/chrome/browser/cocoa/toolbar_controller.mm +++ b/chrome/browser/cocoa/toolbar_controller.mm @@ -562,17 +562,10 @@ class NotificationBridge : public NotificationObserver { } - (void)badgeWrenchMenu { - // The wrench menu gets an upgrade dot. This gets ugly because we only have a - // PNG so we need to position it. TODO(avi): Get a PDF version, one ready for - // overlaying. http://crbug.com/49668 - // // In the Windows version, the ball doesn't actually pulsate, and is always // drawn with the inactive image. Why? (We follow suit, though not on the // weird positioning they do that overlaps the button border.) - ThemeProvider* theme_provider = profile_->GetThemeProvider(); - NSImage* badge = theme_provider->GetNSImageNamed(IDR_UPGRADE_DOT_INACTIVE, - true); - + NSImage* badge = nsimage_cache::ImageNamed(@"upgrade_dot.pdf"); NSImage* wrenchImage = nsimage_cache::ImageNamed(kWrenchButtonImageName); NSSize wrenchImageSize = [wrenchImage size]; diff --git a/chrome/chrome_dll.gypi b/chrome/chrome_dll.gypi index 52550f2..10ecae4 100644 --- a/chrome/chrome_dll.gypi +++ b/chrome/chrome_dll.gypi @@ -271,6 +271,7 @@ 'app/theme/reload_Template.pdf', 'app/theme/stop_Template.pdf', 'app/theme/tools_Template.pdf', + 'app/theme/upgrade_dot.pdf', 'browser/cocoa/install.sh', ], 'mac_bundle_resources!': [ |