diff options
| author | fischman@chromium.org <fischman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-30 16:47:56 +0000 |
|---|---|---|
| committer | fischman@chromium.org <fischman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-30 16:47:56 +0000 |
| commit | 7f51e9e8a8ae2cadb278aa5420a4a8ecef1beb70 (patch) | |
| tree | de439871cd417649d427d675ee01924b18a1f235 | |
| parent | 66799ce230d2b7fd194e178bd7821a645865d6b5 (diff) | |
| download | chromium_src-7f51e9e8a8ae2cadb278aa5420a4a8ecef1beb70.zip chromium_src-7f51e9e8a8ae2cadb278aa5420a4a8ecef1beb70.tar.gz chromium_src-7f51e9e8a8ae2cadb278aa5420a4a8ecef1beb70.tar.bz2 | |
Add -Wsign-compare for C++ compilation on linux & friends.
g++ -Wall includes -Wsign-compare on C++ source, but clang++ doesn't.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6771022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79846 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | build/common.gypi | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/build/common.gypi b/build/common.gypi index b911258..475339b 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -1,4 +1,4 @@ -# Copyright (c) 2010 The Chromium Authors. All rights reserved. +# Copyright (c) 2011 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -1033,6 +1033,10 @@ # Make inline functions have hidden visiblity by default. # Surprisingly, not covered by -fvisibility=hidden. '-fvisibility-inlines-hidden', + # GCC turns on -Wsign-compare for C++ under -Wall, but clang doesn't, + # so we specify it explicitly. + # TODO(fischman): remove this if http://b/4187267 obsoletes it. + '-Wsign-compare', ], 'ldflags': [ '-pthread', '-Wl,-z,noexecstack', |