diff options
author | mattm@chromium.org <mattm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-27 23:57:13 +0000 |
---|---|---|
committer | mattm@chromium.org <mattm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-27 23:57:13 +0000 |
commit | 8ec5d5603c0548afdcae306f792a5989eaddf69d (patch) | |
tree | 292652debe6c35e89b8ef652301cdb485730dcb6 | |
parent | 750c19807988816ea4ddc03c73491dc7fc025c83 (diff) | |
download | chromium_src-8ec5d5603c0548afdcae306f792a5989eaddf69d.zip chromium_src-8ec5d5603c0548afdcae306f792a5989eaddf69d.tar.gz chromium_src-8ec5d5603c0548afdcae306f792a5989eaddf69d.tar.bz2 |
Merge 123620 - Set SSLInfo.client_cert_sent when origin bound cert was sent.
BUG=115376
TEST=none
Review URL: http://codereview.chromium.org/9454025
TBR=mattm@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9478016
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@123833 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | net/socket/socket_test_util.cc | 3 | ||||
-rw-r--r-- | net/socket/ssl_client_socket_mac.cc | 4 | ||||
-rw-r--r-- | net/socket/ssl_client_socket_nss.cc | 4 | ||||
-rw-r--r-- | net/socket/ssl_client_socket_openssl.cc | 4 | ||||
-rw-r--r-- | net/socket/ssl_client_socket_win.cc | 4 |
5 files changed, 10 insertions, 9 deletions
diff --git a/net/socket/socket_test_util.cc b/net/socket/socket_test_util.cc index b8ac5ad..46ad9a5 100644 --- a/net/socket/socket_test_util.cc +++ b/net/socket/socket_test_util.cc @@ -1119,7 +1119,8 @@ base::TimeDelta MockSSLClientSocket::GetConnectTimeMicros() const { void MockSSLClientSocket::GetSSLInfo(SSLInfo* ssl_info) { ssl_info->Reset(); ssl_info->cert = data_->cert; - ssl_info->client_cert_sent = data_->client_cert_sent; + ssl_info->client_cert_sent = WasOriginBoundCertSent() || + data_->client_cert_sent; } void MockSSLClientSocket::GetSSLCertRequestInfo( diff --git a/net/socket/ssl_client_socket_mac.cc b/net/socket/ssl_client_socket_mac.cc index 824b447..0b1248d 100644 --- a/net/socket/ssl_client_socket_mac.cc +++ b/net/socket/ssl_client_socket_mac.cc @@ -724,8 +724,8 @@ void SSLClientSocketMac::GetSSLInfo(SSLInfo* ssl_info) { ssl_info->public_key_hashes = server_cert_verify_result_.public_key_hashes; ssl_info->is_issued_by_known_root = server_cert_verify_result_.is_issued_by_known_root; - ssl_info->client_cert_sent = - ssl_config_.send_client_cert && ssl_config_.client_cert; + ssl_info->client_cert_sent = WasOriginBoundCertSent() || + (ssl_config_.send_client_cert && ssl_config_.client_cert); // security info SSLCipherSuite suite; diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc index 6c70615..b171beb 100644 --- a/net/socket/ssl_client_socket_nss.cc +++ b/net/socket/ssl_client_socket_nss.cc @@ -500,8 +500,8 @@ void SSLClientSocketNSS::GetSSLInfo(SSLInfo* ssl_info) { } ssl_info->is_issued_by_known_root = server_cert_verify_result_->is_issued_by_known_root; - ssl_info->client_cert_sent = - ssl_config_.send_client_cert && ssl_config_.client_cert; + ssl_info->client_cert_sent = WasOriginBoundCertSent() || + (ssl_config_.send_client_cert && ssl_config_.client_cert); PRUint16 cipher_suite = SSLConnectionStatusToCipherSuite(ssl_connection_status_); diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc index d308e4c..7aba143 100644 --- a/net/socket/ssl_client_socket_openssl.cc +++ b/net/socket/ssl_client_socket_openssl.cc @@ -587,8 +587,8 @@ void SSLClientSocketOpenSSL::GetSSLInfo(SSLInfo* ssl_info) { server_cert_verify_result_.is_issued_by_known_root; ssl_info->public_key_hashes = server_cert_verify_result_.public_key_hashes; - ssl_info->client_cert_sent = - ssl_config_.send_client_cert && ssl_config_.client_cert; + ssl_info->client_cert_sent = WasOriginBoundCertSent() || + (ssl_config_.send_client_cert && ssl_config_.client_cert); const SSL_CIPHER* cipher = SSL_get_current_cipher(ssl_); CHECK(cipher); diff --git a/net/socket/ssl_client_socket_win.cc b/net/socket/ssl_client_socket_win.cc index e2509f2..9c3c439 100644 --- a/net/socket/ssl_client_socket_win.cc +++ b/net/socket/ssl_client_socket_win.cc @@ -427,8 +427,8 @@ void SSLClientSocketWin::GetSSLInfo(SSLInfo* ssl_info) { ssl_info->public_key_hashes = server_cert_verify_result_.public_key_hashes; ssl_info->is_issued_by_known_root = server_cert_verify_result_.is_issued_by_known_root; - ssl_info->client_cert_sent = - ssl_config_.send_client_cert && ssl_config_.client_cert; + ssl_info->client_cert_sent = WasOriginBoundCertSent() || + (ssl_config_.send_client_cert && ssl_config_.client_cert); SecPkgContext_ConnectionInfo connection_info; SECURITY_STATUS status = QueryContextAttributes( &ctxt_, SECPKG_ATTR_CONNECTION_INFO, &connection_info); |