summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-07-22 22:20:19 +0000
committerjar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-07-22 22:20:19 +0000
commita063c102fd36f61f4a0a01447f4b01ace4ffccdf (patch)
tree801c4319279c82261b9b3a8f4214f79bd5a4767d
parent2f66099544951cddee4f58543a66fe41018e2c02 (diff)
downloadchromium_src-a063c102fd36f61f4a0a01447f4b01ace4ffccdf.zip
chromium_src-a063c102fd36f61f4a0a01447f4b01ace4ffccdf.tar.gz
chromium_src-a063c102fd36f61f4a0a01447f4b01ace4ffccdf.tar.bz2
Change to (quieter) NOTREACHED() rather than (noisy) LOG(DFATAL)
bug=46576 r=thestig Review URL: http://codereview.chromium.org/2884033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53402 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/metrics/metrics_service.cc18
1 files changed, 9 insertions, 9 deletions
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc
index 9a93091..45af9bf 100644
--- a/chrome/browser/metrics/metrics_service.cc
+++ b/chrome/browser/metrics/metrics_service.cc
@@ -653,7 +653,7 @@ void MetricsService::Observe(NotificationType type,
break;
}
default:
- LOG(DFATAL);
+ NOTREACHED();
break;
}
@@ -858,7 +858,7 @@ void MetricsService::ScheduleNextStateSave() {
void MetricsService::SaveLocalState() {
PrefService* pref = g_browser_process->local_state();
if (!pref) {
- LOG(DFATAL);
+ NOTREACHED();
return;
}
@@ -1149,7 +1149,7 @@ void MetricsService::MakePendingLog() {
break;
default:
- LOG(DFATAL);
+ NOTREACHED();
return;
}
@@ -1380,7 +1380,7 @@ static const char* StatusToString(const URLRequestStatus& status) {
return "FAILED";
default:
- LOG(DFATAL);
+ NOTREACHED();
return "Unknown";
}
}
@@ -1442,7 +1442,7 @@ void MetricsService::OnURLFetchComplete(const URLFetcher* source,
break;
default:
- LOG(DFATAL);
+ NOTREACHED();
break;
}
@@ -1684,7 +1684,7 @@ void MetricsService::LogWindowChange(NotificationType type,
break;
default:
- LOG(DFATAL);
+ NOTREACHED();
return;
}
@@ -1778,7 +1778,7 @@ void MetricsService::LogChildProcessChange(
break;
default:
- LOG(DFATAL) << "Unexpected notification type " << type.value;
+ NOTREACHED() << "Unexpected notification type " << type.value;
return;
}
}
@@ -1838,7 +1838,7 @@ void MetricsService::RecordPluginChanges(PrefService* pref) {
for (ListValue::iterator value_iter = plugins->begin();
value_iter != plugins->end(); ++value_iter) {
if (!(*value_iter)->IsType(Value::TYPE_DICTIONARY)) {
- LOG(DFATAL);
+ NOTREACHED();
continue;
}
@@ -1846,7 +1846,7 @@ void MetricsService::RecordPluginChanges(PrefService* pref) {
std::wstring plugin_name;
plugin_dict->GetString(prefs::kStabilityPluginName, &plugin_name);
if (plugin_name.empty()) {
- LOG(DFATAL);
+ NOTREACHED();
continue;
}