summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoraa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-05-08 00:15:24 +0000
committeraa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-05-08 00:15:24 +0000
commitaffcd7de5185a9028284a7070b6c332b12b9cd51 (patch)
treec882caffbb599055c65ac8cc1d12c0fe990b5046
parentdab74db3eac9336a5678ba146bfc9e8ae4aad338 (diff)
downloadchromium_src-affcd7de5185a9028284a7070b6c332b12b9cd51.zip
chromium_src-affcd7de5185a9028284a7070b6c332b12b9cd51.tar.gz
chromium_src-affcd7de5185a9028284a7070b6c332b12b9cd51.tar.bz2
Add the geolocation permission to the extension install dialog.
BUG=43172 Review URL: http://codereview.chromium.org/2044002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46763 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/app/generated_resources.grd3
-rw-r--r--chrome/browser/extensions/extension_install_ui.cc7
2 files changed, 9 insertions, 1 deletions
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 05f29ce..9d843dc 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -3365,6 +3365,9 @@ each locale. -->
<message name="IDS_EXTENSION_PROMPT2_WARNING_BROWSING_HISTORY" desc="Permission string for access to browsing history.">
Your browsing history
</message>
+ <message name="IDS_EXTENSION_PROMPT2_WARNING_GEOLOCATION" desc="Permissin string for access to geolocation.">
+ Your physical location
+ </message>
<!-- Extension error messages -->
<message name="IDS_EXTENSION_DIRECTORY_NO_EXISTS" desc="Warning displayed in pack dialog when the extension directory does not exist.">
diff --git a/chrome/browser/extensions/extension_install_ui.cc b/chrome/browser/extensions/extension_install_ui.cc
index 80648c6..15c12ea 100644
--- a/chrome/browser/extensions/extension_install_ui.cc
+++ b/chrome/browser/extensions/extension_install_ui.cc
@@ -128,7 +128,12 @@ static void GetV2Warnings(Extension* extension,
IDS_EXTENSION_PROMPT2_WARNING_BROWSING_HISTORY));
}
- // TODO(aa): Geolocation, camera/mic, what else?
+ if (extension->HasApiPermission(Extension::kGeolocationPermission)) {
+ warnings->push_back(l10n_util::GetStringUTF16(
+ IDS_EXTENSION_PROMPT2_WARNING_GEOLOCATION));
+ }
+
+ // TODO(aa): camera/mic, what else?
}
} // namespace