diff options
| author | sunandt@google.com <sunandt@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-22 19:57:58 +0000 |
|---|---|---|
| committer | sunandt@google.com <sunandt@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-22 19:57:58 +0000 |
| commit | dc2f9f52ff023f5ef11a1bd1f57403bb96fecd4e (patch) | |
| tree | 7f8839791c6e3b6f09ae3c3f65253c3a7b845bdc | |
| parent | 514f55b8bb5b07ed2f7d887a4b01770225b40a63 (diff) | |
| download | chromium_src-dc2f9f52ff023f5ef11a1bd1f57403bb96fecd4e.zip chromium_src-dc2f9f52ff023f5ef11a1bd1f57403bb96fecd4e.tar.gz chromium_src-dc2f9f52ff023f5ef11a1bd1f57403bb96fecd4e.tar.bz2 | |
Fixing the flakiness in pyauto popup test.
BUG=70659
TEST=popups.PopupsTest.testLaunchBlockedPopup
Review URL: http://codereview.chromium.org/6898015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82698 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/test/functional/popups.py | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/chrome/test/functional/popups.py b/chrome/test/functional/popups.py index 01190af..5c6ceb1 100644 --- a/chrome/test/functional/popups.py +++ b/chrome/test/functional/popups.py @@ -48,7 +48,10 @@ class PopupsTest(pyauto.PyUITest): # Verify that popup window was created self.assertEqual(2, self.GetBrowserWindowCount(), msg='Popup could not be launched'); - self.assertEqual('Popup Success!', self.GetActiveTabTitle(1)) + # Wait until popup title is read correctly. + self.assertTrue(self.WaitUntil(lambda: + self.GetActiveTabTitle(1), expect_retval='Popup Success!'), + msg='Popup title is wrong.') def testPopupBlockerInIncognito(self): """Verify popup blocking is enabled in incognito windows.""" |