diff options
| author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-05 23:54:14 +0000 |
|---|---|---|
| committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-05 23:54:14 +0000 |
| commit | 101eb82d718fad90688b1c0cd0083686f38e879f (patch) | |
| tree | 3c0124da6bf95fc6b732f434dbc86920cd845447 | |
| parent | 7110c8930b89fc05b45029f7751fa5ce06e41f1c (diff) | |
| download | chromium_src-101eb82d718fad90688b1c0cd0083686f38e879f.zip chromium_src-101eb82d718fad90688b1c0cd0083686f38e879f.tar.gz chromium_src-101eb82d718fad90688b1c0cd0083686f38e879f.tar.bz2 | |
Crash using keyboard on a hidden input element
Changes popup display logic to check that input element focused for Autofill is actually visible before populating its popup menu contents. Under specific conditions JavaScript could hide the input element in question and cause crash.
BUG=60522
TEST=Manual, according to bug steps.
Review URL: http://codereview.chromium.org/6010011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70554 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/renderer/autofill_helper.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/renderer/autofill_helper.cc b/chrome/renderer/autofill_helper.cc index d140f94..092555f 100644 --- a/chrome/renderer/autofill_helper.cc +++ b/chrome/renderer/autofill_helper.cc @@ -126,7 +126,7 @@ void AutoFillHelper::SuggestionsReceived(int query_id, } // Send to WebKit for display. - if (!v.empty()) { + if (!v.empty() && autofill_query_node_.hasNonEmptyBoundingBox()) { web_view->applyAutoFillSuggestions( autofill_query_node_, v, l, i, ids, separator_index); } |