diff options
author | sgjesse@chromium.org <sgjesse@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-07 13:50:19 +0000 |
---|---|---|
committer | sgjesse@chromium.org <sgjesse@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-07 13:50:19 +0000 |
commit | 16953001e00d868d671c2fc74ad30618e7900414 (patch) | |
tree | d3d34750efe93f46a3148da0041b97d5a05fd2e3 | |
parent | 3e965a912eb059d826656622c12b0cb2ab42aa88 (diff) | |
download | chromium_src-16953001e00d868d671c2fc74ad30618e7900414.zip chromium_src-16953001e00d868d671c2fc74ad30618e7900414.tar.gz chromium_src-16953001e00d868d671c2fc74ad30618e7900414.tar.bz2 |
Rebaselined the following 6 layout tests.
LayoutTests/http/tests/security/listener/xss-XMLHttpRequest-shortcut.html
LayoutTests/http/tests/security/listener/xss-XMLHttpRequest-addEventListener.html
LayoutTests/http/tests/security/listener/xss-window-onclick-shortcut.html
LayoutTests/http/tests/security/listener/xss-window-onclick-addEventListener.html
LayoutTests/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut.html
LayoutTests/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener.html
In WebKit r33979 all these layout tests had
alert("document.domain: " + window.document.domain);
changed to
try {
alert("document.domain: " + window.document.domain);
} catch(e) {
}
causing the document.domain access error to no longer be reported. Rebaselining the tests does not compromize what they are testing as if window.domain was accessible the output would change causing failures.
Review URL: http://codereview.chromium.org/9691
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4985 0039d316-1c4b-4281-b951-d872f2087c98
7 files changed, 1 insertions, 13 deletions
diff --git a/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt b/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt index 60b0216..f449e44 100644 --- a/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt +++ b/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt @@ -1,6 +1,5 @@ CONSOLE MESSAGE: line 1: Unsafe JavaScript attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe.html from frame with URL http://127.0.0.1:8000/security/listener/resources/childWithButton.html. Domains, protocols and ports must match. -CONSOLE MESSAGE: line 6: Uncaught TypeError: Cannot read property 'domain' of undefined This tests that frame used when setting eventListeners on an EventTarget using addEventListener is the target nodes frame. (rdar://problem/5426142). This test passes if you don't see an alert dialog with the domain of "localhost" in it and an "Unsafe JavaScript" warning is logged to the console. diff --git a/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt b/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt index 2156691..3a16e47 100644 --- a/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt +++ b/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt @@ -1,6 +1,5 @@ CONSOLE MESSAGE: line 1: Unsafe JavaScript attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe.html from frame with URL http://127.0.0.1:8000/security/listener/resources/childWithButton.html. Domains, protocols and ports must match. -CONSOLE MESSAGE: line 6: Uncaught TypeError: Cannot read property 'domain' of undefined This tests that frame used when setting eventListeners on an EventTarget with the shortcut (onclick, etc), is the target nodes frame. (rdar://problem/5426142). This test passes if you don't see an alert dialog with the domain of "localhost" in it and an "Unsafe JavaScript" warning is logged to the console. diff --git a/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt b/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt index d33fed0..1fe6f93 100644 --- a/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt +++ b/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt @@ -1,6 +1,5 @@ CONSOLE MESSAGE: line 1: Unsafe JavaScript attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe.html from frame with URL http://127.0.0.1:8000/security/listener/resources/childWithXMLHttpRequest.html. Domains, protocols and ports must match. -CONSOLE MESSAGE: line 6: Uncaught TypeError: Cannot read property 'domain' of undefined This tests that frame used when setting eventListeners on an XMLHttpRequest using addEventListener, is the requests frame. (rdar://problem/5426142). This test passes if you don't see an alert dialog with the domain of "localhost" in it and an "Unsafe JavaScript" warning is logged to the console. diff --git a/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt b/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt index e60f843..325d3b9 100644 --- a/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt +++ b/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt @@ -1,6 +1,5 @@ CONSOLE MESSAGE: line 1: Unsafe JavaScript attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe.html from frame with URL http://127.0.0.1:8000/security/listener/resources/childWithXMLHttpRequest.html. Domains, protocols and ports must match. -CONSOLE MESSAGE: line 6: Uncaught TypeError: Cannot read property 'domain' of undefined This tests that frame used when setting eventListeners on an XMLHttpRequest with the shortcut (onreadystatechange), is the requests frame. (rdar://problem/5426142). This test passes if you don't see an alert dialog with the domain of "localhost" in it and an "Unsafe JavaScript" warning is logged to the console. diff --git a/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt b/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt index 04f61c5..02f33f2 100644 --- a/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt +++ b/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt @@ -1,6 +1,5 @@ CONSOLE MESSAGE: line 1: Unsafe JavaScript attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe.html from frame with URL http://127.0.0.1:8000/security/listener/resources/childWindow.html. Domains, protocols and ports must match. -CONSOLE MESSAGE: line 6: Uncaught TypeError: Cannot read property 'domain' of undefined This tests that frame used when setting eventListeners on the window using addEventListener is the window's frame. (rdar://problem/5426142). This test passes if you don't see an alert dialog with the domain of "localhost" in it and an "Unsafe JavaScript" warning is logged to the console. diff --git a/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt b/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt index d8f3387..ff90842 100644 --- a/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt +++ b/webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt @@ -1,6 +1,5 @@ CONSOLE MESSAGE: line 1: Unsafe JavaScript attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe.html from frame with URL http://127.0.0.1:8000/security/listener/resources/childWindow.html. Domains, protocols and ports must match. -CONSOLE MESSAGE: line 6: Uncaught TypeError: Cannot read property 'domain' of undefined This tests that frame used when setting eventListeners on the window with the shortcut (onclick, etc), is the window's frame. (rdar://problem/5426142). This test passes if you don't see an alert dialog with the domain of "localhost" in it and an "Unsafe JavaScript" warning is logged to the console. diff --git a/webkit/tools/layout_tests/test_lists/win/tests_fixable.txt b/webkit/tools/layout_tests/test_lists/win/tests_fixable.txt index 70317e4..ad2975f 100644 --- a/webkit/tools/layout_tests/test_lists/win/tests_fixable.txt +++ b/webkit/tools/layout_tests/test_lists/win/tests_fixable.txt @@ -868,7 +868,7 @@ V8 | KJS # LayoutTests/http/tests/misc/acid3.html = FAIL V8 | KJS # DEFER : LayoutTests/http/tests/misc/frame-default-enc-same-domain.html = FAIL V8 | KJS # LayoutTests/http/tests/security/canvas-remote-read-svg-image.html = FAIL V8 | KJS # LayoutTests/http/tests/security/cross-frame-access-object-prototype.html = FAIL | TIMEOUT -V8 | KJS # LayoutTests/http/tests/security/cross-origin-xsl-BLOCKED.html = FAIL +// V8 | KJS # LayoutTests/http/tests/security/cross-origin-xsl-BLOCKED.html = FAIL V8 | KJS # LayoutTests/http/tests/security/xss-DENIED-synchronous-form.html = FAIL | TIMEOUT V8 | KJS # LayoutTests/http/tests/security/xss-eval.html = FAIL | TIMEOUT V8 | KJS # LayoutTests/http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html = FAIL @@ -904,12 +904,6 @@ V8 | KJS # LayoutTests/http/tests/navigation/metaredirect-basic.html = FAIL V8 | KJS # LayoutTests/http/tests/navigation/post-basic.html = FAIL | PASS V8 | KJS # LayoutTests/http/tests/navigation/post-frames.html = FAIL | PASS V8 | KJS # LayoutTests/http/tests/security/cross-frame-access-history-put.html = FAIL | TIMEOUT -V8 | KJS # LayoutTests/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener.html = FAIL -V8 | KJS # LayoutTests/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut.html = FAIL -V8 | KJS # LayoutTests/http/tests/security/listener/xss-XMLHttpRequest-addEventListener.html = FAIL -V8 | KJS # LayoutTests/http/tests/security/listener/xss-XMLHttpRequest-shortcut.html = FAIL -V8 | KJS # LayoutTests/http/tests/security/listener/xss-window-onclick-addEventListener.html = FAIL -V8 | KJS # LayoutTests/http/tests/security/listener/xss-window-onclick-shortcut.html = FAIL V8 | KJS # LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception.html = FAIL | TIMEOUT V8 | KJS # LayoutTests/svg/W3C-SVG-1.1/animate-elem-34-t.svg = FAIL V8 | KJS # LayoutTests/svg/W3C-SVG-1.1/animate-elem-40-t.svg = FAIL |