diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-06 18:32:21 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-06 18:32:21 +0000 |
| commit | 3a6bc9040f96a70e85682033a44f25866bc1a62a (patch) | |
| tree | d851ff55fdf7ff40d3dd00cf69b3f061e2d7ce7d | |
| parent | edb7a3f0bbc8d0de72757c883023d0fcdf180986 (diff) | |
| download | chromium_src-3a6bc9040f96a70e85682033a44f25866bc1a62a.zip chromium_src-3a6bc9040f96a70e85682033a44f25866bc1a62a.tar.gz chromium_src-3a6bc9040f96a70e85682033a44f25866bc1a62a.tar.bz2 | |
Fix up some code not to set off coverity warnings.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19962 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | net/socket/client_socket_pool_base.h | 6 | ||||
| -rw-r--r-- | net/socket/socket_test_util.h | 1 | ||||
| -rw-r--r-- | net/socket/ssl_test_util.cc | 2 |
3 files changed, 6 insertions, 3 deletions
diff --git a/net/socket/client_socket_pool_base.h b/net/socket/client_socket_pool_base.h index b7df105..54e9396 100644 --- a/net/socket/client_socket_pool_base.h +++ b/net/socket/client_socket_pool_base.h @@ -92,7 +92,11 @@ class ClientSocketPoolBase // ERR_IO_PENDING. struct Request { // HostResolver::RequestInfo has no default constructor, so fudge something. - Request() : resolve_info(std::string(), 0) {} + Request() + : handle(NULL), + callback(NULL), + priority(0), + resolve_info(std::string(), 0) {} Request(ClientSocketHandle* handle, CompletionCallback* callback, diff --git a/net/socket/socket_test_util.h b/net/socket/socket_test_util.h index f710820..fc288ad 100644 --- a/net/socket/socket_test_util.h +++ b/net/socket/socket_test_util.h @@ -132,7 +132,6 @@ class DynamicMockSocket : public MockSocket { private: MockRead read_; bool has_read_; - bool consumed_read_; // Max number of bytes we will read at a time. 0 means no limit. int short_read_limit_; diff --git a/net/socket/ssl_test_util.cc b/net/socket/ssl_test_util.cc index 101cbf5..0f012f5 100644 --- a/net/socket/ssl_test_util.cc +++ b/net/socket/ssl_test_util.cc @@ -108,7 +108,7 @@ TestServerLauncher::TestServerLauncher() : process_handle_(NULL) namespace { -void AppendToPythonPath(FilePath dir) { +void AppendToPythonPath(const FilePath& dir) { // Do nothing if dir already on path. #if defined(OS_WIN) |