diff options
author | rsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-17 22:10:21 +0000 |
---|---|---|
committer | rsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-17 22:10:21 +0000 |
commit | 4aeb09b8886afad694c8c2ae1bae9da8456f3d38 (patch) | |
tree | 88450071a829ec3d7b2a3d2191699f579b2b3dca | |
parent | 762323a9effc4e31290a5b350243f46c5728b7ec (diff) | |
download | chromium_src-4aeb09b8886afad694c8c2ae1bae9da8456f3d38.zip chromium_src-4aeb09b8886afad694c8c2ae1bae9da8456f3d38.tar.gz chromium_src-4aeb09b8886afad694c8c2ae1bae9da8456f3d38.tar.bz2 |
Disable password sync integration tests on Mac until MockKeychain is fixed
MockKeychain on Mac only allows for the deletion of passwords from the
end of the store (the last added password). This causes several of the
password sync integration tests to fail.
This patch selectively disables the tests that fail until MockKeychain
is fixed.
BUG=89808
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/7631031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97222 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/test/live_sync/single_client_live_passwords_sync_test.cc | 5 | ||||
-rw-r--r-- | chrome/test/live_sync/two_client_live_passwords_sync_test.cc | 60 |
2 files changed, 65 insertions, 0 deletions
diff --git a/chrome/test/live_sync/single_client_live_passwords_sync_test.cc b/chrome/test/live_sync/single_client_live_passwords_sync_test.cc index 8154e15..870e47f 100644 --- a/chrome/test/live_sync/single_client_live_passwords_sync_test.cc +++ b/chrome/test/live_sync/single_client_live_passwords_sync_test.cc @@ -8,7 +8,12 @@ using webkit_glue::PasswordForm; +// TODO(sync): Enable after MockKeychain is fixed. http://crbug.com/89808. +#if defined(OS_MACOSX) +IN_PROC_BROWSER_TEST_F(SingleClientLivePasswordsSyncTest, DISABLED_Sanity) { +#else IN_PROC_BROWSER_TEST_F(SingleClientLivePasswordsSyncTest, Sanity) { +#endif ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; PasswordForm form = CreateTestPasswordForm(0); diff --git a/chrome/test/live_sync/two_client_live_passwords_sync_test.cc b/chrome/test/live_sync/two_client_live_passwords_sync_test.cc index 6b52c3a..17679fa 100644 --- a/chrome/test/live_sync/two_client_live_passwords_sync_test.cc +++ b/chrome/test/live_sync/two_client_live_passwords_sync_test.cc @@ -13,7 +13,12 @@ using webkit_glue::PasswordForm; static const char* kValidPassphrase = "passphrase!"; // TCM ID - 3732277 +// TODO(sync): Enable after MockKeychain is fixed. http://crbug.com/89808. +#if defined(OS_MACOSX) +IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, DISABLED_Add) { +#else IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, Add) { +#endif ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(AllProfilesContainSamePasswordFormsAsVerifier()); @@ -27,7 +32,12 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, Add) { ASSERT_TRUE(AllProfilesContainSamePasswordFormsAsVerifier()); } +// TODO(sync): Enable after MockKeychain is fixed. http://crbug.com/89808. +#if defined(OS_MACOSX) +IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, DISABLED_Race) { +#else IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, Race) { +#endif ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(AllProfilesContainSamePasswordForms()); @@ -43,7 +53,13 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, Race) { } // TCM ID - 4577932. +// TODO(sync): Enable after MockKeychain is fixed. http://crbug.com/89808. +#if defined(OS_MACOSX) +IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, + DISABLED_DisablePasswords) { +#else IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, DisablePasswords) { +#endif ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(AllProfilesContainSamePasswordFormsAsVerifier()); @@ -65,7 +81,12 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, DisablePasswords) { } // TCM ID - 4649281. +// TODO(sync): Enable after MockKeychain is fixed. http://crbug.com/89808. +#if defined(OS_MACOSX) +IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, DISABLED_DisableSync) { +#else IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, DisableSync) { +#endif ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(AllProfilesContainSamePasswordFormsAsVerifier()); @@ -86,7 +107,13 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, DisableSync) { ASSERT_EQ(1, GetPasswordCount(1)); } +// TODO(sync): Enable after MockKeychain is fixed. http://crbug.com/89808. +#if defined(OS_MACOSX) +IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, + DISABLED_SetPassphrase) { +#else IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, SetPassphrase) { +#endif ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; SetPassphrase(0, kValidPassphrase, true); @@ -98,8 +125,14 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, SetPassphrase) { ASSERT_TRUE(GetClient(1)->AwaitSyncCycleCompletion("Set passphrase.")); } +// TODO(sync): Enable after MockKeychain is fixed. http://crbug.com/89808. +#if defined(OS_MACOSX) +IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, + DISABLED_SetPassphraseAndAddPassword) { +#else IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, SetPassphraseAndAddPassword) { +#endif ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; SetPassphrase(0, kValidPassphrase, true); @@ -118,7 +151,12 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, } // TCM ID - 4603879 +// TODO(sync): Enable after MockKeychain is fixed. http://crbug.com/89808. +#if defined(OS_MACOSX) +IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, DISABLED_Update) { +#else IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, Update) { +#endif ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(AllProfilesContainSamePasswordFormsAsVerifier()); @@ -137,7 +175,12 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, Update) { } // TCM ID - 3719309 +// TODO(sync): Enable after MockKeychain is fixed. http://crbug.com/89808. +#if defined(OS_MACOSX) +IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, DISABLED_Delete) { +#else IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, Delete) { +#endif ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(AllProfilesContainSamePasswordFormsAsVerifier()); @@ -158,7 +201,12 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, Delete) { } // TCM ID - 7573511 +// TODO(sync): Enable after MockKeychain is fixed. http://crbug.com/89808. +#if defined(OS_MACOSX) +IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, DISABLED_DeleteAll) { +#else IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, DeleteAll) { +#endif ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(AllProfilesContainSamePasswordFormsAsVerifier()); @@ -200,8 +248,14 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, FLAKY_Merge) { ASSERT_TRUE(AllProfilesContainSamePasswordFormsAsVerifier()); } +// TODO(sync): Enable after MockKeychain is fixed. http://crbug.com/89808. +#if defined(OS_MACOSX) +IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, + DISABLED_SetPassphraseAndThenSetupSync) { +#else IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, SetPassphraseAndThenSetupSync) { +#endif ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(GetClient(0)->SetupSync()); @@ -223,8 +277,14 @@ IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, ASSERT_EQ(browser_sync::GROUP_PASSWORD, routes[syncable::PASSWORDS]); } +// TODO(sync): Enable after MockKeychain is fixed. http://crbug.com/89808. +#if defined(OS_MACOSX) +IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, + DISABLED_SetPassphraseTwice) { +#else IN_PROC_BROWSER_TEST_F(TwoClientLivePasswordsSyncTest, SetPassphraseTwice) { +#endif ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; SetPassphrase(0, kValidPassphrase, true); |