diff options
| author | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-26 19:38:05 +0000 |
|---|---|---|
| committer | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-26 19:38:05 +0000 |
| commit | 61c2fa1647b7e71f870c280a685082dee49c3d18 (patch) | |
| tree | e439c5016542af938d66ea5f1336383611335f81 | |
| parent | 0d02a5f10d50dee16267a781ddb40aa2df47171f (diff) | |
| download | chromium_src-61c2fa1647b7e71f870c280a685082dee49c3d18.zip chromium_src-61c2fa1647b7e71f870c280a685082dee49c3d18.tar.gz chromium_src-61c2fa1647b7e71f870c280a685082dee49c3d18.tar.bz2 | |
Close the handle to the child process after terminating it. This avoids
calling RegisterWaitForSingleObject with a handle to a process that has
already been terminated. (See the use of ProcessWatcher in the destructor
of BrowserRenderProcessHost.) I'm not sure that this explains why RWFSO
fails, but it seems like a reasonable change anyways. The MSDN docs do
not give any reasons for why RWFSO might fail.
R=maruel
BUG=3782
Review URL: http://codereview.chromium.org/18810
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8651 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/renderer_host/browser_render_process_host.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/renderer_host/browser_render_process_host.cc b/chrome/browser/renderer_host/browser_render_process_host.cc index a93cbbe..823a063 100644 --- a/chrome/browser/renderer_host/browser_render_process_host.cc +++ b/chrome/browser/renderer_host/browser_render_process_host.cc @@ -571,6 +571,7 @@ bool BrowserRenderProcessHost::FastShutdownIfPossible() { // Otherwise, we're allowed to just terminate the process. Using exit code 0 // means that UMA won't treat this as a renderer crash. process_.Terminate(ResultCodes::NORMAL_EXIT); + process_.Close(); return true; } |