diff options
author | nirnimesh@chromium.org <nirnimesh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-30 17:17:23 +0000 |
---|---|---|
committer | nirnimesh@chromium.org <nirnimesh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-30 17:17:23 +0000 |
commit | 63514afa2ee674c9edf20f5f78acda206708f721 (patch) | |
tree | 2c6de850313b87ab4ba5db0d022dfde53c21d751 | |
parent | bd9337ce8f7afe8dda38ee3afe3dd260507f7c2c (diff) | |
download | chromium_src-63514afa2ee674c9edf20f5f78acda206708f721.zip chromium_src-63514afa2ee674c9edf20f5f78acda206708f721.tar.gz chromium_src-63514afa2ee674c9edf20f5f78acda206708f721.tar.bz2 |
Port some omnibox provider methods to Mac.
Well, I didn't really port. I just uncommented out some methods marked
UNIMPLEMENTED(). They seem to work just fine.
TEST=ui_tests --gtest_filter=OmniboxTest.* --run_omnibox_test
Review URL: http://codereview.chromium.org/1513003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43094 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/browser/automation/automation_provider.cc | 5 | ||||
-rw-r--r-- | chrome/browser/automation/automation_provider_mac.mm | 32 | ||||
-rw-r--r-- | chrome/chrome_tests.gypi | 1 |
3 files changed, 1 insertions, 37 deletions
diff --git a/chrome/browser/automation/automation_provider.cc b/chrome/browser/automation/automation_provider.cc index 9fb9c9d..0c264a28 100644 --- a/chrome/browser/automation/automation_provider.cc +++ b/chrome/browser/automation/automation_provider.cc @@ -1638,7 +1638,6 @@ void AutomationProvider::GetWindowForBrowser(int browser_handle, } } -#if !defined(OS_MACOSX) void AutomationProvider::GetAutocompleteEditForBrowser( int browser_handle, bool* success, @@ -1655,7 +1654,6 @@ void AutomationProvider::GetAutocompleteEditForBrowser( *success = true; } } -#endif // !defined(OS_MACOSX) void AutomationProvider::ShowInterstitialPage(int tab_handle, const std::string& html_text, @@ -1901,8 +1899,6 @@ void AutomationProvider::SavePage(int tab_handle, *success = true; } -#if !defined(OS_MACOSX) -// TODO(port): Enable these. void AutomationProvider::GetAutocompleteEditText(int autocomplete_edit_handle, bool* success, std::wstring* text) { @@ -1953,6 +1949,7 @@ void AutomationProvider::AutocompleteEditIsQueryInProgress( } } +#if !defined(OS_MACOSX) void AutomationProvider::OnMessageFromExternalHost(int handle, const std::string& message, const std::string& origin, diff --git a/chrome/browser/automation/automation_provider_mac.mm b/chrome/browser/automation/automation_provider_mac.mm index f58b7a8..8dff5f7 100644 --- a/chrome/browser/automation/automation_provider_mac.mm +++ b/chrome/browser/automation/automation_provider_mac.mm @@ -74,32 +74,6 @@ void AutomationProvider::PrintAsync(int tab_handle) { NOTIMPLEMENTED(); } -void AutomationProvider::GetAutocompleteEditText( - int autocomplete_edit_handle, bool* success, std::wstring* text) { - *success = false; - NOTIMPLEMENTED(); -} - -void AutomationProvider::SetAutocompleteEditText(int autocomplete_edit_handle, - const std::wstring& text, - bool* success) { - *success = false; - NOTIMPLEMENTED(); -} - -void AutomationProvider::AutocompleteEditIsQueryInProgress( - int autocomplete_edit_handle, bool* success, bool* query_in_progress) { - *success = false; - NOTIMPLEMENTED(); -} - -void AutomationProvider::AutocompleteEditGetMatches( - int autocomplete_edit_handle, bool* success, - std::vector<AutocompleteMatchData>* matches) { - *success = false; - NOTIMPLEMENTED(); -} - void AutomationProvider::OnMessageFromExternalHost(int handle, const std::string& message, const std::string& origin, @@ -107,12 +81,6 @@ void AutomationProvider::OnMessageFromExternalHost(int handle, NOTIMPLEMENTED(); } -void AutomationProvider::GetAutocompleteEditForBrowser( - int browser_handle, bool* success, int* autocomplete_edit_handle) { - *success = false; - NOTIMPLEMENTED(); -} - void AutomationProvider::SetInitialFocus(const IPC::Message& message, int handle, bool reverse) { NOTIMPLEMENTED(); diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index 28dbacb..ecaa251 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -364,7 +364,6 @@ 'common/logging_chrome_uitest.cc', 'test/ui/fast_shutdown_uitest.cc', 'test/ui/layout_plugin_uitest.cc', - 'test/ui/omnibox_uitest.cc', ], }], ['OS=="win"', { |