diff options
| author | dkegel@google.com <dkegel@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-20 22:30:49 +0000 |
|---|---|---|
| committer | dkegel@google.com <dkegel@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-20 22:30:49 +0000 |
| commit | 76b13e3705e0d1e7f8ec21a7ef4fdf2290eea417 (patch) | |
| tree | e7b027c379877cd433a5b50742bb0578f047234a | |
| parent | d2c9135c11fd6643beed43ec37e35cfd34e8b25a (diff) | |
| download | chromium_src-76b13e3705e0d1e7f8ec21a7ef4fdf2290eea417.zip chromium_src-76b13e3705e0d1e7f8ec21a7ef4fdf2290eea417.tar.gz chromium_src-76b13e3705e0d1e7f8ec21a7ef4fdf2290eea417.tar.bz2 | |
Don't expect unit tests to free root cert
Review URL: http://codereview.chromium.org/42425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12223 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | net/base/ssl_test_util.cc | 4 | ||||
| -rw-r--r-- | tools/valgrind/suppressions.txt | 7 |
2 files changed, 10 insertions, 1 deletions
diff --git a/net/base/ssl_test_util.cc b/net/base/ssl_test_util.cc index 2cb309e..04731b5e7 100644 --- a/net/base/ssl_test_util.cc +++ b/net/base/ssl_test_util.cc @@ -312,6 +312,10 @@ bool TestServerLauncher::LoadTestRootCert() { return true; // TODO(dkegel): figure out how to get this to only happen once? + + // This currently leaks a little memory. + // TODO(dkegel): fix the leak and remove the entry in + // tools/valgrind/suppressions.txt cert_ = reinterpret_cast<PrivateCERTCertificate*>( LoadTemporaryCert(GetRootCertPath())); DCHECK(cert_); diff --git a/tools/valgrind/suppressions.txt b/tools/valgrind/suppressions.txt index a9328fc..1897aa0 100644 --- a/tools/valgrind/suppressions.txt +++ b/tools/valgrind/suppressions.txt @@ -118,4 +118,9 @@ ... fun:_ZN7logging11InitLoggingEPKcNS_18LoggingDestinationENS_15LogLockingStateENS_20OldFileDeletionStateE } - +{ + Linux tests don't bother to undo net::TestServerLauncher::LoadTestRootCert(). + Memcheck:Leak + ... + fun:_ZN3net18TestServerLauncher16LoadTestRootCertEv +} |