diff options
| author | dkegel@google.com <dkegel@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-20 02:59:59 +0000 |
|---|---|---|
| committer | dkegel@google.com <dkegel@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-20 02:59:59 +0000 |
| commit | 9d0984aadf39ed588efe90334bff43559d536d11 (patch) | |
| tree | 1fe943fd023f118b2ea25144465a27fae1fad093 | |
| parent | c1ced8ea3b177e7d8847676e1745261679ec02f3 (diff) | |
| download | chromium_src-9d0984aadf39ed588efe90334bff43559d536d11.zip chromium_src-9d0984aadf39ed588efe90334bff43559d536d11.tar.gz chromium_src-9d0984aadf39ed588efe90334bff43559d536d11.tar.bz2 | |
Implement --verbose in valgrind_test.py to make chrome_tests.py -v happy
Also log the two environment variables we set
Review URL: http://codereview.chromium.org/42428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12183 0039d316-1c4b-4281-b951-d872f2087c98
| -rwxr-xr-x | tools/valgrind/valgrind_test.py | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/tools/valgrind/valgrind_test.py b/tools/valgrind/valgrind_test.py index 4306d29..4afb714 100755 --- a/tools/valgrind/valgrind_test.py +++ b/tools/valgrind/valgrind_test.py @@ -21,6 +21,8 @@ import common import valgrind_analyze +import google.logging_utils + rmtree = shutil.rmtree class Valgrind(object): @@ -57,6 +59,8 @@ class Valgrind(object): self._parser.add_option("", "--generate_suppressions", action="store_true", default=False, help="Skip analysis and generate suppressions") + self._parser.add_option("-v", "--verbose", action="store_true", default=False, + help="verbose output - enable debug log messages") self._parser.description = __doc__ def ParseArgv(self): @@ -68,6 +72,11 @@ class Valgrind(object): self._source_dir = self._options.source_dir if self._options.gtest_filter != "": self._args.append("--gtest_filter=%s" % self._options.gtest_filter) + if self._options.verbose: + google.logging_utils.config_root(logging.DEBUG) + else: + google.logging_utils.config_root() + return True def Setup(self): @@ -85,7 +94,9 @@ class Valgrind(object): proc = self.ValgrindCommand() os.putenv("G_SLICE", "always-malloc") + logging.info("export G_SLICE=always-malloc"); os.putenv("NSS_DISABLE_ARENA_FREE_LIST", "1") + logging.info("export NSS_DISABLE_ARENA_FREE_LIST=1"); common.RunSubprocess(proc, self._timeout) |