diff options
| author | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-28 09:51:37 +0000 |
|---|---|---|
| committer | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-28 09:51:37 +0000 |
| commit | b41ee89e63e49bd66962777b7d6e94c5530d22e8 (patch) | |
| tree | 914d595fc01ccfe073de22cd6930d3e9b648721b | |
| parent | 9b1622661700d08d617b387514ef44899efc354d (diff) | |
| download | chromium_src-b41ee89e63e49bd66962777b7d6e94c5530d22e8.zip chromium_src-b41ee89e63e49bd66962777b7d6e94c5530d22e8.tar.gz chromium_src-b41ee89e63e49bd66962777b7d6e94c5530d22e8.tar.bz2 | |
Update TSan suppressions and ignores to be greener on local runs
a) Suppress races on tracked_birth::Birth (they don't affect production)
b) Ignore accesses below gaih_inet - there are reports from third_party
TBR=kinuko
BUG=61179,75589
Review URL: http://codereview.chromium.org/6735008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79538 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | tools/valgrind/tsan/ignores.txt | 8 | ||||
| -rw-r--r-- | tools/valgrind/tsan/suppressions.txt | 11 |
2 files changed, 11 insertions, 8 deletions
diff --git a/tools/valgrind/tsan/ignores.txt b/tools/valgrind/tsan/ignores.txt index 7322ed7..1fb5857 100644 --- a/tools/valgrind/tsan/ignores.txt +++ b/tools/valgrind/tsan/ignores.txt @@ -3,8 +3,6 @@ # See http://code.google.com/p/data-race-test/wiki/ThreadSanitizerIgnores. # ignore these libraries -obj:*/ld-2* -obj:*/libpthread-* obj:*/libfreetype* obj:*/libdbus* @@ -27,8 +25,6 @@ fun_r:random_r fun_r:random fun_r:rand fun_r:srand -fun:__lll_mutex_unlock_wake -fun:__cxa_atexit fun:__new_exitfn fun:_dl_* fun:__dl_* @@ -39,7 +35,6 @@ fun:sys_* # ignore libc's printf functions fun_r:_IO_* -fun:vfprintf fun:fwrite fun:fflush @@ -143,6 +138,9 @@ fun_r:mbsrtowcs # https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/59449 fun_r:gethostbyname2_r* +# TODO(timurrrr): remove this when TSan is updated past r3232 +fun_r:gaih_inet + # Strange reports below _IO_getline, every time in "Concurrent access". # Probably the reports are there since we're missing the libc internal locks fun_r:_IO_getline* diff --git a/tools/valgrind/tsan/suppressions.txt b/tools/valgrind/tsan/suppressions.txt index 668f579..5aed9cce 100644 --- a/tools/valgrind/tsan/suppressions.txt +++ b/tools/valgrind/tsan/suppressions.txt @@ -1,6 +1,5 @@ ############################ -# Chromium - +# Real races in Chromium { bug_23433 ThreadSanitizer:Race @@ -150,7 +149,13 @@ } ############################ -# Benign races +# Benign races in Chromium +{ + bug_61179 [benign race on tracked_objects::Births] + ThreadSanitizer:Race + fun:tracked_objects::Births::*Birth* +} + { bug_62694 [benign races in Histogram in CookieMonster] ThreadSanitizer:Race |