diff options
| author | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-22 16:49:41 +0000 |
|---|---|---|
| committer | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-22 16:49:41 +0000 |
| commit | eae8081acbe5261ab9fecabe975c787c4df8d1bf (patch) | |
| tree | 92f1381c5c941b9766d86424b9070d0d1cbb60b1 | |
| parent | ea1cc2cd3e4abc83475a3b92956fc036c14444f4 (diff) | |
| download | chromium_src-eae8081acbe5261ab9fecabe975c787c4df8d1bf.zip chromium_src-eae8081acbe5261ab9fecabe975c787c4df8d1bf.tar.gz chromium_src-eae8081acbe5261ab9fecabe975c787c4df8d1bf.tar.bz2 | |
Re-enable positive OOB write tests under Dr. Memory and add the suppression for these tests.
TEST=DrM bot shouldn't be affected after landing this. Before DrM r175 it would crash
BUG=http://code.google.com/p/drmemory/issues/detail?id=51
TBR=bruening
Review URL: http://codereview.chromium.org/6538092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75598 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | base/tools_sanity_unittest.cc | 8 | ||||
| -rw-r--r-- | tools/valgrind/drmemory/suppressions.txt | 10 |
2 files changed, 10 insertions, 8 deletions
diff --git a/base/tools_sanity_unittest.cc b/base/tools_sanity_unittest.cc index 779c236..e1e41a6 100644 --- a/base/tools_sanity_unittest.cc +++ b/base/tools_sanity_unittest.cc @@ -61,16 +61,8 @@ void MakeSomeErrors(char *ptr, size_t size) { ReadUninitializedValue(ptr); ReadValueOutOfArrayBoundsLeft(ptr); ReadValueOutOfArrayBoundsRight(ptr, size); - - // We execute this function only under memory checking tools - - // Valgrind on Linux and Mac, Dr. Memory on Windows. - // Currently writing values out-of-bounds makes Dr. Memory a bit crazy when - // this code is linked with /MTd, so skip these writes on Windows. - // See http://code.google.com/p/drmemory/issues/detail?id=51 -#if !defined(OS_WIN) WriteValueOutOfArrayBoundsLeft(ptr); WriteValueOutOfArrayBoundsRight(ptr, size); -#endif } } // namespace diff --git a/tools/valgrind/drmemory/suppressions.txt b/tools/valgrind/drmemory/suppressions.txt index 394bd5c..c5ac944 100644 --- a/tools/valgrind/drmemory/suppressions.txt +++ b/tools/valgrind/drmemory/suppressions.txt @@ -426,6 +426,16 @@ base_unittests.exe!*ReadValueOutOfArrayBoundsRight base_unittests.exe!*MakeSomeErrors base_unittests.exe!base::ToolsSanityTest_AccessesToNewMemory_Test::TestBody +UNADDRESSABLE ACCESS +base_unittests.exe!*WriteValueOutOfArrayBoundsLeft +base_unittests.exe!*MakeSomeErrors +base_unittests.exe!base::ToolsSanityTest_AccessesToNewMemory_Test::TestBody + +UNADDRESSABLE ACCESS +base_unittests.exe!*WriteValueOutOfArrayBoundsRight +base_unittests.exe!*MakeSomeErrors +base_unittests.exe!base::ToolsSanityTest_AccessesToNewMemory_Test::TestBody + UNINITIALIZED READ base_unittests.exe!*ReadUninitializedValue base_unittests.exe!*MakeSomeErrors |