diff options
| author | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-23 23:26:15 +0000 |
|---|---|---|
| committer | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-23 23:26:15 +0000 |
| commit | 4efbbb309336c744c0b86ccb71729b711c5743a0 (patch) | |
| tree | 3b5914f92a2a528e143695601ef33c2e48c50d10 | |
| parent | 910c2d8853a583b1d9f8424399c96743ff33b578 (diff) | |
| download | chromium_src-4efbbb309336c744c0b86ccb71729b711c5743a0.zip chromium_src-4efbbb309336c744c0b86ccb71729b711c5743a0.tar.gz chromium_src-4efbbb309336c744c0b86ccb71729b711c5743a0.tar.bz2 | |
Merge 138394 - gdata: Fix a bug that caused histograms on gdata files to be skewed.
We shouldn't record the histograms when processing delta feeds.
BUG=129248
TEST=manually confirmed by chrome://histograms
Review URL: https://chromiumcodereview.appspot.com/10416049
TBR=satorux@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10436011
git-svn-id: svn://svn.chromium.org/chrome/branches/1132/src@138662 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/chromeos/gdata/gdata_file_system.cc | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system.cc b/chrome/browser/chromeos/gdata/gdata_file_system.cc index e091b63..dac2e37 100644 --- a/chrome/browser/chromeos/gdata/gdata_file_system.cc +++ b/chrome/browser/chromeos/gdata/gdata_file_system.cc @@ -3650,11 +3650,14 @@ base::PlatformFileError GDataFileSystem::UpdateFromFeed( if (should_notify_initial_load) NotifyInitialLoadFinished(); - const int num_total_files = num_hosted_documents + num_regular_files; - UMA_HISTOGRAM_COUNTS("GData.NumberOfRegularFiles", num_regular_files); - UMA_HISTOGRAM_COUNTS("GData.NumberOfHostedDocuments", - num_hosted_documents); - UMA_HISTOGRAM_COUNTS("GData.NumberOfTotalFiles", num_total_files); + // Shouldn't record histograms when processing delta feeds. + if (!is_delta_feed) { + const int num_total_files = num_hosted_documents + num_regular_files; + UMA_HISTOGRAM_COUNTS("GData.NumberOfRegularFiles", num_regular_files); + UMA_HISTOGRAM_COUNTS("GData.NumberOfHostedDocuments", + num_hosted_documents); + UMA_HISTOGRAM_COUNTS("GData.NumberOfTotalFiles", num_total_files); + } return base::PLATFORM_FILE_OK; } |