summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-10 00:54:52 +0000
committerevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-10 00:54:52 +0000
commit0686afadc3d6567975ff2571e4f26efd08197476 (patch)
treebff7f3ab6e36970f1884f97ccea52b6a1708d613
parent5f26b8b841d65db70e83529fc27c60329d814af0 (diff)
downloadchromium_src-0686afadc3d6567975ff2571e4f26efd08197476.zip
chromium_src-0686afadc3d6567975ff2571e4f26efd08197476.tar.gz
chromium_src-0686afadc3d6567975ff2571e4f26efd08197476.tar.bz2
Bumped the version of the seccomp sandbox. In particular, we want this
change: This bug was causing problems with running unittests on the buildbots. In particular, the code that patched the signature of the restorer function was corrupting the FPU state. And we couldn't debug this problem easily, because the missing NX support then broke signal handling. Evan helped with finding a reproducible test scenario in a Hardy VM, and after applying this change the unittest (e.g. Chrome's browser_tests) succeeds. Description: On older 32bit kernels (e.g. Ubuntu Hardy), the seccomp sandbox fails to handle signals correctly. This is primarily a result of the kernel not supporting non-executable data segments. But it also runs into problems because the format of the signal frame is subtly different and does not appear to always include a "magic restorer function". This changelist removes all dependencies on NX support from the 32bit version of the code. And it eliminates the code that patches the restorer function. Both of these features were originally added to make it easier for gdb to debug code that runs inside of a signal handler. But given the observed problems with this approach, it does not seem worth the effort. 64bit code seems unaffected by all of these problems -- presumably because that architecture is a lot more recent. So, we'll not make any changes to it. BUG=http://code.google.com/p/seccompsandbox/issues/detail?id=5 TEST=make test Review URL: http://codereview.chromium.org/4732004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65608 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--DEPS2
1 files changed, 1 insertions, 1 deletions
diff --git a/DEPS b/DEPS
index 4b4eb9a..db8ba27 100644
--- a/DEPS
+++ b/DEPS
@@ -25,7 +25,7 @@ deps = {
(Var("googlecode_url") % "google-url") + "/trunk@149",
"src/seccompsandbox":
- (Var("googlecode_url") % "seccompsandbox") + "/trunk@141",
+ (Var("googlecode_url") % "seccompsandbox") + "/trunk@147",
"src/sdch/open-vcdiff":
(Var("googlecode_url") % "open-vcdiff") + "/trunk@28",