diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-24 06:38:58 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-24 06:38:58 +0000 |
| commit | 112f72bb04df73ac5757dc5f0530159f4a2329e5 (patch) | |
| tree | 3a60919b0fa226e14b0feb69b68ec18134773ade | |
| parent | 420ae012547bd2a176a0e0f5de27bc540b28a255 (diff) | |
| download | chromium_src-112f72bb04df73ac5757dc5f0530159f4a2329e5.zip chromium_src-112f72bb04df73ac5757dc5f0530159f4a2329e5.tar.gz chromium_src-112f72bb04df73ac5757dc5f0530159f4a2329e5.tar.bz2 | |
The previous behavior of not focusing the HWND when focusing a checkbox/radio-button was preventing focus to work as expected on these controls. It would leave the previous HWND focused, causing problems.
BUG=10856
TEST=Open the Option dialog. Click the "Show home button..." checkbox. The close button should lose focus, the checkbox should get focus. Press space, the checkbox state should change. Click on a radio-button, it should become selected and get focused. Press the up/down arrow. The next/previous radio-button should get selected and focused.
Review URL: http://codereview.chromium.org/93114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14417 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/views/controls/button/native_button_win.cc | 5 | ||||
| -rw-r--r-- | chrome/views/controls/button/native_button_win.h | 1 |
2 files changed, 0 insertions, 6 deletions
diff --git a/chrome/views/controls/button/native_button_win.cc b/chrome/views/controls/button/native_button_win.cc index 61d3b58..a6cf075 100644 --- a/chrome/views/controls/button/native_button_win.cc +++ b/chrome/views/controls/button/native_button_win.cc @@ -148,11 +148,6 @@ void NativeCheckboxWin::SetPushed(bool pushed) { SendMessage(GetHWND(), BM_SETSTATE, pushed, 0); } -void NativeCheckboxWin::SetFocus() { - // The focus should stay on the views::Checkbox (more precisely, on the - // label, which is a view). -} - bool NativeCheckboxWin::OnKeyDown(int vkey) { // Override the NativeButtonWin behavior which triggers the button on enter // key presses when focused. diff --git a/chrome/views/controls/button/native_button_win.h b/chrome/views/controls/button/native_button_win.h index 0a1a572..f9dbcaf 100644 --- a/chrome/views/controls/button/native_button_win.h +++ b/chrome/views/controls/button/native_button_win.h @@ -65,7 +65,6 @@ class NativeCheckboxWin : public NativeButtonWin { virtual bool OnKeyDown(int vkey); // Overridden from NativeControlWin: - virtual void SetFocus(); virtual bool ProcessMessage(UINT message, WPARAM w_param, LPARAM l_param, |