diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-17 21:28:37 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-17 21:28:37 +0000 |
commit | 169a332888f222ad509bd516e0ed7ae670898816 (patch) | |
tree | eaed21ad75b5a780cafc6faea648c2a5d89d5176 | |
parent | cef87438fe8dbdb000db143e72f99ba374f12d37 (diff) | |
download | chromium_src-169a332888f222ad509bd516e0ed7ae670898816.zip chromium_src-169a332888f222ad509bd516e0ed7ae670898816.tar.gz chromium_src-169a332888f222ad509bd516e0ed7ae670898816.tar.bz2 |
Rebaseline numeric-conversions per ager's advice.
The expected files expect a FAIL line because I can't change the upstream test. Copying the test to the platform/directories doesn't help because the test is actually in a resources/xxx.js file and there seem to be problems with paths in that case.
Review URL: http://codereview.chromium.org/15201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7163 0039d316-1c4b-4281-b951-d872f2087c98
3 files changed, 50 insertions, 4 deletions
diff --git a/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/numeric-conversion-expected.txt b/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/numeric-conversion-expected.txt new file mode 100644 index 0000000..ec732d9 --- /dev/null +++ b/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/numeric-conversion-expected.txt @@ -0,0 +1,25 @@ +This test checks for accuracy in numeric conversions, particularly with large or infinite values. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS Number(1152921504606847105).toString() is '1152921504606847200' +PASS parseInt('1152921504606847105').toString() is '1152921504606847200' +PASS (- (- '1152921504606847105')).toString() is '1152921504606847200' +PASS Number(0x1000000000000081).toString(16) is '1000000000000100' +PASS parseInt('0x1000000000000081', 16).toString(16) is '1000000000000100' +PASS (- (- '0x1000000000000081')).toString(16) is '1000000000000100' +PASS Number(0100000000000000000201).toString(8) is '100000000000000000400' +PASS parseInt('100000000000000000201', 8).toString(8) is '100000000000000000400' +PASS (- 'infinity').toString() is 'NaN' +PASS parseInt('1000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000').toString() is 'Infinity' +PASS parseInt('0x100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000', 16).toString() is 'Infinity' +PASS parseInt('100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000', 8).toString() is 'Infinity' +PASS parseInt('9007199254740992e2000').toString() is '9007199254740992' +PASS parseInt('9007199254740992.0e2000').toString() is '9007199254740992' +FAIL parseInt(NaN) should be 0. Was NaN. +FAIL parseInt(-Infinity) should be 0. Was NaN. +FAIL parseInt(Infinity) should be 0. Was NaN. +PASS successfullyParsed is true + +TEST COMPLETE diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/numeric-conversion-expected.txt b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/numeric-conversion-expected.txt new file mode 100644 index 0000000..ec732d9 --- /dev/null +++ b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/numeric-conversion-expected.txt @@ -0,0 +1,25 @@ +This test checks for accuracy in numeric conversions, particularly with large or infinite values. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS Number(1152921504606847105).toString() is '1152921504606847200' +PASS parseInt('1152921504606847105').toString() is '1152921504606847200' +PASS (- (- '1152921504606847105')).toString() is '1152921504606847200' +PASS Number(0x1000000000000081).toString(16) is '1000000000000100' +PASS parseInt('0x1000000000000081', 16).toString(16) is '1000000000000100' +PASS (- (- '0x1000000000000081')).toString(16) is '1000000000000100' +PASS Number(0100000000000000000201).toString(8) is '100000000000000000400' +PASS parseInt('100000000000000000201', 8).toString(8) is '100000000000000000400' +PASS (- 'infinity').toString() is 'NaN' +PASS parseInt('1000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000').toString() is 'Infinity' +PASS parseInt('0x100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000', 16).toString() is 'Infinity' +PASS parseInt('100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000', 8).toString() is 'Infinity' +PASS parseInt('9007199254740992e2000').toString() is '9007199254740992' +PASS parseInt('9007199254740992.0e2000').toString() is '9007199254740992' +FAIL parseInt(NaN) should be 0. Was NaN. +FAIL parseInt(-Infinity) should be 0. Was NaN. +FAIL parseInt(Infinity) should be 0. Was NaN. +PASS successfullyParsed is true + +TEST COMPLETE diff --git a/webkit/tools/layout_tests/test_lists/tests_fixable.txt b/webkit/tools/layout_tests/test_lists/tests_fixable.txt index 1459ace..ec52ebf 100644 --- a/webkit/tools/layout_tests/test_lists/tests_fixable.txt +++ b/webkit/tools/layout_tests/test_lists/tests_fixable.txt @@ -1027,10 +1027,6 @@ LINUX : LayoutTests/fast/forms/8250.html = FAIL // printed if that property is on a button. This is either a small problem in // test shell or a big problem in V8. LayoutTests/fast/forms/selection-functions.html = FAIL -// I suspect the test itself is really wrong here. Full of nonsense like "FAIL -// parseInt(NaN) should be 0. Was NaN." and "FAIL parseInt(Infinity) should be -// 0. Was NaN." -LayoutTests/fast/js/numeric-conversion.html = FAIL LINUX WIN : LayoutTests/svg/W3C-SVG-1.1/animate-elem-03-t.svg = FAIL LINUX WIN : LayoutTests/svg/W3C-SVG-1.1/animate-elem-11-t.svg = FAIL LINUX WIN : LayoutTests/svg/W3C-SVG-1.1/animate-elem-24-t.svg = FAIL |