diff options
| author | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-06 20:04:46 +0000 |
|---|---|---|
| committer | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-06 20:04:46 +0000 |
| commit | 23e040a98019974f182caf3183ae8f0654122fc7 (patch) | |
| tree | f34edbe4cf41d97da118701d2f2769e86d73219c | |
| parent | eae61a6fc6e0e68b3da1d68b50b1f0c359682cc1 (diff) | |
| download | chromium_src-23e040a98019974f182caf3183ae8f0654122fc7.zip chromium_src-23e040a98019974f182caf3183ae8f0654122fc7.tar.gz chromium_src-23e040a98019974f182caf3183ae8f0654122fc7.tar.bz2 | |
Explain in a comment what was explained in the review, so that people who look at the code don't cringe.
CID=11235
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3543013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61696 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/views/extensions/extension_popup.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/browser/views/extensions/extension_popup.cc b/chrome/browser/views/extensions/extension_popup.cc index 2f21254..0db98f6 100644 --- a/chrome/browser/views/extensions/extension_popup.cc +++ b/chrome/browser/views/extensions/extension_popup.cc @@ -415,6 +415,8 @@ void ExtensionPopup::Release() { ExtensionPopup::Observer* observer = observer_; delete this; + // |this| is passed only as a 'cookie'. The observer API explicitly takes a + // void* argument to emphasize this. if (observer) observer->ExtensionPopupClosed(this); } |