diff options
author | dpranke@chromium.org <dpranke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-13 00:30:05 +0000 |
---|---|---|
committer | dpranke@chromium.org <dpranke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-13 00:30:05 +0000 |
commit | 4c9bf655e22186fa89798b72d6f3ecc5ad118b24 (patch) | |
tree | 6b65c3e84e880bc16194d2d32fc815fd3b9c1a4a | |
parent | d24938d6ba2f7e5088a8d0d12ae037d07e558ae2 (diff) | |
download | chromium_src-4c9bf655e22186fa89798b72d6f3ecc5ad118b24.zip chromium_src-4c9bf655e22186fa89798b72d6f3ecc5ad118b24.tar.gz chromium_src-4c9bf655e22186fa89798b72d6f3ecc5ad118b24.tar.bz2 |
extract out removal of the g_log_bug53991 global.
This global is referenced across content and chrome, and would need
to be exported for the content.dll build. It appears to be off by
default and was added for a bug last touched a year ago, so I'm thinking
it's safe to remove it and it can be readded back in as necessary.
R=mpcomplete@chromium.org
BUG=53991,90442
TEST=none
Review URL: http://codereview.chromium.org/7833004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100817 0039d316-1c4b-4281-b951-d872f2087c98
4 files changed, 0 insertions, 21 deletions
diff --git a/chrome/browser/extensions/extension_process_manager.cc b/chrome/browser/extensions/extension_process_manager.cc index b5290f7..08764e1 100644 --- a/chrome/browser/extensions/extension_process_manager.cc +++ b/chrome/browser/extensions/extension_process_manager.cc @@ -76,8 +76,6 @@ static void CreateBackgroundHostsForProfileStartup( } // namespace -extern bool g_log_bug53991; - // // ExtensionProcessManager // @@ -111,7 +109,6 @@ ExtensionProcessManager::ExtensionProcessManager(Profile* profile) } ExtensionProcessManager::~ExtensionProcessManager() { - VLOG_IF(1, g_log_bug53991) << "~ExtensionProcessManager: " << this; CloseBackgroundHosts(); DCHECK(background_hosts_.empty()); } @@ -375,7 +372,6 @@ void ExtensionProcessManager::OnExtensionHostCreated(ExtensionHost* host, } void ExtensionProcessManager::CloseBackgroundHosts() { - VLOG_IF(1, g_log_bug53991) << "CloseBackgroundHosts: " << this; for (ExtensionHostSet::iterator iter = background_hosts_.begin(); iter != background_hosts_.end(); ) { ExtensionHostSet::iterator current = iter++; diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc index 2656ae1..a933cd8 100644 --- a/chrome/browser/ui/browser.cc +++ b/chrome/browser/ui/browser.cc @@ -240,8 +240,6 @@ bool HasInternalURL(const NavigationEntry* entry) { } // namespace -extern bool g_log_bug53991; - //////////////////////////////////////////////////////////////////////////////// // Browser, CreateParams: @@ -369,10 +367,6 @@ Browser::Browser(Type type, Profile* profile) } Browser::~Browser() { - VLOG_IF(1, g_log_bug53991) << "~Browser: " << profile_->IsOffTheRecord() - << "; stillActive=" - << BrowserList::IsOffTheRecordSessionActive(); - if (profile_->GetProfileSyncService()) profile_->GetProfileSyncService()->RemoveObserver(this); diff --git a/content/browser/renderer_host/browser_render_process_host.cc b/content/browser/renderer_host/browser_render_process_host.cc index 67e180d..e863591 100644 --- a/content/browser/renderer_host/browser_render_process_host.cc +++ b/content/browser/renderer_host/browser_render_process_host.cc @@ -98,10 +98,6 @@ #include "third_party/skia/include/core/SkBitmap.h" -// TODO(mpcomplete): Remove this after fixing -// http://code.google.com/p/chromium/issues/detail?id=53991 -bool g_log_bug53991 = false; - // This class creates the IO thread for the renderer when running in // single-process mode. It's not used in multi-process mode. class RendererMainThread : public base::Thread { @@ -236,8 +232,6 @@ BrowserRenderProcessHost::BrowserRenderProcessHost( } BrowserRenderProcessHost::~BrowserRenderProcessHost() { - VLOG_IF(1, g_log_bug53991) << "~BrowserRenderProcessHost: " << this; - ChildProcessSecurityPolicy::GetInstance()->Remove(id()); // We may have some unsent messages at this point, but that's OK. diff --git a/content/browser/renderer_host/render_process_host.cc b/content/browser/renderer_host/render_process_host.cc index ec097de..44e52231 100644 --- a/content/browser/renderer_host/render_process_host.cc +++ b/content/browser/renderer_host/render_process_host.cc @@ -82,8 +82,6 @@ IDMap<RenderProcessHost> all_hosts; } // namespace -extern bool g_log_bug53991; - // static bool RenderProcessHost::run_renderer_in_process_ = false; @@ -120,13 +118,10 @@ bool RenderProcessHost::HasConnection() const { void RenderProcessHost::Attach(IPC::Channel::Listener* listener, int routing_id) { - VLOG_IF(1, g_log_bug53991) << "AddListener: (" << this << "): " << routing_id; listeners_.AddWithID(listener, routing_id); } void RenderProcessHost::Release(int listener_id) { - VLOG_IF(1, g_log_bug53991) << "RemListener: (" << this << "): " - << listener_id; DCHECK(listeners_.Lookup(listener_id) != NULL); listeners_.Remove(listener_id); |