diff options
author | sail@chromium.org <sail@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-13 04:16:41 +0000 |
---|---|---|
committer | sail@chromium.org <sail@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-13 04:16:41 +0000 |
commit | 5bfeb5683378809d5fae8c008e1ebf02076299c9 (patch) | |
tree | 4553ac02174390b867707fed1e6e482ff2c27df0 | |
parent | 2cc98cdf4fbb622f1d88d4ab6246479fcaa1cf6c (diff) | |
download | chromium_src-5bfeb5683378809d5fae8c008e1ebf02076299c9.zip chromium_src-5bfeb5683378809d5fae8c008e1ebf02076299c9.tar.gz chromium_src-5bfeb5683378809d5fae8c008e1ebf02076299c9.tar.bz2 |
Fix layout of global error bubble view on windows
The global error bubble view had two problems on windows:
- the title didn't fill the width of the parent so you could only see a few characters of the title
- there wasn't enough space between the title and the icon
This change fixes both problems. I tested this on Windows and Linux views and verified that it looks good on both.
BUG=95146
TEST=
Review URL: http://codereview.chromium.org/7874009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100856 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/browser/ui/views/global_error_bubble_view.cc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/chrome/browser/ui/views/global_error_bubble_view.cc b/chrome/browser/ui/views/global_error_bubble_view.cc index fa4ebc5..4a9efdd 100644 --- a/chrome/browser/ui/views/global_error_bubble_view.cc +++ b/chrome/browser/ui/views/global_error_bubble_view.cc @@ -25,6 +25,9 @@ enum { const int kBubbleViewWidth = 262; +// The horizontal padding between the title and the icon. +const int kTitleHorizontalPadding = 3; + // The vertical offset of the wrench bubble from the wrench menu button. const int kWrenchBubblePointOffsetY = 6; @@ -71,7 +74,8 @@ GlobalErrorBubbleView::GlobalErrorBubbleView(Browser* browser, views::ColumnSet* cs = layout->AddColumnSet(0); cs->AddColumn(views::GridLayout::LEADING, views::GridLayout::LEADING, 0, views::GridLayout::USE_PREF, 0, 0); - cs->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, + cs->AddPaddingColumn(0, kTitleHorizontalPadding); + cs->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 1, views::GridLayout::USE_PREF, 0, 0); // Middle row, message label. |