diff options
| author | mkwst@chromium.org <mkwst@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-23 11:09:17 +0000 |
|---|---|---|
| committer | mkwst@chromium.org <mkwst@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-23 11:09:17 +0000 |
| commit | 5ed5b929b32848b4bed3aa3029672b7807011343 (patch) | |
| tree | cb0f0db4d1a02f09c478417d194dc7dbda396ec5 | |
| parent | 3cd3bce4c48e0a55263777da45e405ad217708a8 (diff) | |
| download | chromium_src-5ed5b929b32848b4bed3aa3029672b7807011343.zip chromium_src-5ed5b929b32848b4bed3aa3029672b7807011343.tar.gz chromium_src-5ed5b929b32848b4bed3aa3029672b7807011343.tar.bz2 | |
Style changes to automation_provider_observers to make clang happy.
It looks like http://codereview.chromium.org/7865026 introduced two slight style problems that Clang's chromium-style plugin doesn't appreciate: the destructor isn't virtual, and it's inlined. This CL changes both.
BUG=
TEST=Does Chrome compile with clang/chromium-style?
Review URL: http://codereview.chromium.org/8018001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102476 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/automation/automation_provider_observers.cc | 2 | ||||
| -rw-r--r-- | chrome/browser/automation/automation_provider_observers.h | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/chrome/browser/automation/automation_provider_observers.cc b/chrome/browser/automation/automation_provider_observers.cc index 2916b15..be65a44 100644 --- a/chrome/browser/automation/automation_provider_observers.cc +++ b/chrome/browser/automation/automation_provider_observers.cc @@ -2760,6 +2760,8 @@ ProcessInfoObserver::ProcessInfoObserver( : automation_(automation->AsWeakPtr()), reply_message_(reply_message) {} +ProcessInfoObserver::~ProcessInfoObserver() {} + void ProcessInfoObserver::OnDetailsAvailable() { scoped_ptr<DictionaryValue> return_value(new DictionaryValue); ListValue* browser_proc_list = new ListValue(); diff --git a/chrome/browser/automation/automation_provider_observers.h b/chrome/browser/automation/automation_provider_observers.h index 039fa06..14973c22 100644 --- a/chrome/browser/automation/automation_provider_observers.h +++ b/chrome/browser/automation/automation_provider_observers.h @@ -1718,7 +1718,7 @@ class ProcessInfoObserver : public MemoryDetails { virtual void OnDetailsAvailable() OVERRIDE; private: - ~ProcessInfoObserver() {} + virtual ~ProcessInfoObserver(); base::WeakPtr<AutomationProvider> automation_; scoped_ptr<IPC::Message> reply_message_; |