summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-11-30 18:23:13 +0000
committermbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-11-30 18:23:13 +0000
commit6572f12401c12d3bae74df88cd4477fc063ffca3 (patch)
tree8e6a139bc574047b966718c05944d4200f90719c
parente83ba1c4aecdd8bbcdf43c3d8f5581321418ab0e (diff)
downloadchromium_src-6572f12401c12d3bae74df88cd4477fc063ffca3.zip
chromium_src-6572f12401c12d3bae74df88cd4477fc063ffca3.tar.gz
chromium_src-6572f12401c12d3bae74df88cd4477fc063ffca3.tar.bz2
Fix leak when we get an error during a write. We
were forgetting to release the in_flight_write, which holds a reference to the FlipStream. BUG=none TEST=WriteError (coming) Review URL: http://codereview.chromium.org/453005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33299 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--net/flip/flip_session.cc1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/flip/flip_session.cc b/net/flip/flip_session.cc
index 8b62c50..aa19f7a 100644
--- a/net/flip/flip_session.cc
+++ b/net/flip/flip_session.cc
@@ -487,6 +487,7 @@ void FlipSession::OnWriteComplete(int result) {
// message loop).
WriteSocketLater();
} else {
+ in_flight_write_.release();
// The stream is now errored. Close it down.
CloseAllStreams(static_cast<net::Error>(result));
// TODO(mbelshe): we need to cleanup the session here as well.