summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-11 19:50:05 +0000
committerjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-11 19:50:05 +0000
commit76d8b628a14b4958646c9ea9c22232fe80de8ca1 (patch)
tree2bbc45dd1f52f9bbbddb66b5e8ad5c8a53c82b13
parentf67bf6081a4e05d8b7e33b1aec71c3aec04ae3db (diff)
downloadchromium_src-76d8b628a14b4958646c9ea9c22232fe80de8ca1.zip
chromium_src-76d8b628a14b4958646c9ea9c22232fe80de8ca1.tar.gz
chromium_src-76d8b628a14b4958646c9ea9c22232fe80de8ca1.tar.bz2
Crash fix: Don't use const-ref parameter for an async callback.
BUG=62739 TEST=none Review URL: http://codereview.chromium.org/4708007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65836 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/download/download_manager.cc2
-rw-r--r--chrome/browser/download/download_manager.h2
-rw-r--r--chrome/browser/history/history.h2
3 files changed, 3 insertions, 3 deletions
diff --git a/chrome/browser/download/download_manager.cc b/chrome/browser/download/download_manager.cc
index 5100236..7dc9a11 100644
--- a/chrome/browser/download/download_manager.cc
+++ b/chrome/browser/download/download_manager.cc
@@ -899,7 +899,7 @@ void DownloadManager::OnQueryDownloadEntriesComplete(
// service, we associate the DownloadItem with the db handle, update our
// 'downloads_' map and inform observers.
void DownloadManager::OnCreateDownloadEntryComplete(
- const DownloadCreateInfo& info,
+ DownloadCreateInfo info,
int64 db_handle) {
DownloadMap::iterator it = in_progress_.find(info.download_id);
DCHECK(it != in_progress_.end());
diff --git a/chrome/browser/download/download_manager.h b/chrome/browser/download/download_manager.h
index 2d8bf15..a6cdd90 100644
--- a/chrome/browser/download/download_manager.h
+++ b/chrome/browser/download/download_manager.h
@@ -168,7 +168,7 @@ class DownloadManager
void OnQueryDownloadEntriesComplete(
std::vector<DownloadCreateInfo>* entries);
void OnCreateDownloadEntryComplete(
- const DownloadCreateInfo& info, int64 db_handle);
+ DownloadCreateInfo info, int64 db_handle);
// Display a new download in the appropriate browser UI.
void ShowDownloadInBrowser(const DownloadCreateInfo& info,
diff --git a/chrome/browser/history/history.h b/chrome/browser/history/history.h
index 9d2fd20..3fe34ba 100644
--- a/chrome/browser/history/history.h
+++ b/chrome/browser/history/history.h
@@ -408,7 +408,7 @@ class HistoryService : public CancelableRequestProvider,
// Implemented by the caller of 'CreateDownload' below, and is called when the
// history service has created a new entry for a download in the history db.
- typedef Callback2<const DownloadCreateInfo&, int64>::Type
+ typedef Callback2<DownloadCreateInfo, int64>::Type
DownloadCreateCallback;
// Begins a history request to create a new persistent entry for a download.