diff options
| author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-26 21:20:41 +0000 |
|---|---|---|
| committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-26 21:20:41 +0000 |
| commit | 78fb0befb7193b3a1093f9470686d755b623015f (patch) | |
| tree | 81b35ab8973ce04d027164f49c42c23923eeda8f | |
| parent | 6594358eb6ec8a2a2d2f3f304a303b22b99a50a6 (diff) | |
| download | chromium_src-78fb0befb7193b3a1093f9470686d755b623015f.zip chromium_src-78fb0befb7193b3a1093f9470686d755b623015f.tar.gz chromium_src-78fb0befb7193b3a1093f9470686d755b623015f.tar.bz2 | |
.gyp(i) changes to put "Cobwerks" into the right place(s) on Linux and Mac.
BUG=none
TEST=everything should still build
Review URL: http://codereview.chromium.org/1409003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42819 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/chrome_exe.gypi | 13 | ||||
| -rw-r--r-- | third_party/adobe/flash/flash_player.gyp | 45 |
2 files changed, 37 insertions, 21 deletions
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi index 570357d4..90421e3 100644 --- a/chrome/chrome_exe.gypi +++ b/chrome/chrome_exe.gypi @@ -130,6 +130,11 @@ 'variables': { 'chrome_exe_target': 1, }, + 'dependencies': [ + # Copy a Flash Player binary to PRODUCT_DIR if applicable. + # Let the .gyp file decide what to do on a per-OS basis. + '../third_party/adobe/flash/flash_player.gyp:flash_player', + ], 'conditions': [ ['OS=="linux" or OS=="freebsd" or OS=="openbsd"', { 'actions': [ @@ -385,6 +390,13 @@ 'files': [ '<(PRODUCT_DIR)/<(mac_product_name) Helper.app', ], + 'conditions': [ + [ 'branding == "Chrome"', { + 'files': [ + '<(PRODUCT_DIR)/Flash Player Plugin for Chrome.plugin', + ], + }], + ], }, ], 'postbuilds': [ @@ -470,7 +482,6 @@ '../breakpad/breakpad.gyp:breakpad_handler', '../breakpad/breakpad.gyp:breakpad_sender', '../sandbox/sandbox.gyp:sandbox', - '../third_party/adobe/flash/flash_player.gyp:flash_player', 'app/locales/locales.gyp:*', ], 'msvs_settings': { diff --git a/third_party/adobe/flash/flash_player.gyp b/third_party/adobe/flash/flash_player.gyp index a09b351..76807bd 100644 --- a/third_party/adobe/flash/flash_player.gyp +++ b/third_party/adobe/flash/flash_player.gyp @@ -3,27 +3,32 @@ # found in the LICENSE file. { - 'conditions': [ - [ 'OS == "win"', { - 'targets': [ - { - 'target_name': 'flash_player', - 'type': 'none', - 'conditions': [ - ['branding == "Chrome"', { - 'copies': [ - { - 'destination': '<(PRODUCT_DIR)', - 'files': [ - 'binaries/win/gcswf32.dll', - ], - }, - ], - }], - ], - }, + # Always provide a target, so we can put the logic about whether there's + # anything to be done in this file (instead of a higher-level .gyp file). + 'targets': [ + { + 'target_name': 'flash_player', + 'type': 'none', + 'conditions': [ + [ 'branding == "Chrome"', { + 'copies': [{ + 'destination': '<(PRODUCT_DIR)', + 'conditions': [ + [ 'OS == "linux" and target_arch == "ia32"', { + 'files': [ 'binaries/linux/libgcflashplayer.so' ] + }], + [ 'OS == "mac"', { + 'files': + [ 'binaries/mac/Flash Player Plugin for Chrome.plugin' ] + }], + [ 'OS == "win"', { + 'files': [ 'binaries/win/gcswf32.dll' ] + }], + ], + }], + }], ], - }], + }, ], } |