diff options
author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-27 21:39:50 +0000 |
---|---|---|
committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-27 21:39:50 +0000 |
commit | 825cae38c869a24ef26a8fb2ea66381ee9f9aac1 (patch) | |
tree | 0278e6ce234d63288573902d54fd417982f35d94 | |
parent | f611825664faf17014e7f9c940e7d33247ad583a (diff) | |
download | chromium_src-825cae38c869a24ef26a8fb2ea66381ee9f9aac1.zip chromium_src-825cae38c869a24ef26a8fb2ea66381ee9f9aac1.tar.gz chromium_src-825cae38c869a24ef26a8fb2ea66381ee9f9aac1.tar.bz2 |
Disabling a number of failing chrome frame tests on Vista with IE7. Most of these failures
appear related to WebBrowser2::Navigate for the new window disposition opening up the popup
in a new tab thus causing the tests to fail. A couple of failures are unrelated and need
investigation.
Bug=60987
TBR=amit
Review URL: http://codereview.chromium.org/4143004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64153 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome_frame/test/navigation_test.cc | 24 | ||||
-rw-r--r-- | chrome_frame/test/test_with_web_server.cc | 15 | ||||
-rw-r--r-- | chrome_frame/test/ui_test.cc | 37 |
3 files changed, 76 insertions, 0 deletions
diff --git a/chrome_frame/test/navigation_test.cc b/chrome_frame/test/navigation_test.cc index 99bb62c..b760857 100644 --- a/chrome_frame/test/navigation_test.cc +++ b/chrome_frame/test/navigation_test.cc @@ -6,6 +6,7 @@ #include "base/scoped_comptr_win.h" #include "base/test/test_file_util.h" +#include "base/win/windows_version.h" #include "chrome_frame/test/chrome_frame_test_utils.h" #include "chrome_frame/test/chrome_frame_ui_test_utils.h" #include "chrome_frame/test/mock_ie_event_sink_actions.h" @@ -380,6 +381,14 @@ TEST_P(FullTabNavigationTest, DISABLED_JavascriptWindowOpenDifferentDomain) { // Tests that the parent window can successfully close its popup through // the javascript close method. TEST_P(FullTabNavigationTest, JavascriptWindowOpenCanClose) { + // Please see http://code.google.com/p/chromium/issues/detail?id=60987 + // for more information on why this test is disabled for Vista with IE7. + if (base::win::GetVersion() == base::win::VERSION_VISTA && + GetInstalledIEVersion() == IE_7) { + LOG(INFO) << "Not running test on Vista with IE7"; + return; + } + std::wstring parent_url = GetTestUrl(L"window_open.html?simple.html"); MockAccEventObserver acc_observer; MockIEEventSink new_window_mock; @@ -467,6 +476,14 @@ INSTANTIATE_TEST_CASE_P( // Test window.open calls. TEST_P(NavigationTransitionTest, JavascriptWindowOpen) { + // Please see http://code.google.com/p/chromium/issues/detail?id=60987 + // for more information on why this test is disabled for Vista with IE7. + if (base::win::GetVersion() == base::win::VERSION_VISTA && + GetInstalledIEVersion() == IE_7) { + LOG(INFO) << "Not running test on Vista with IE7"; + return; + } + std::wstring parent_url = GetTestUrl(L"window_open.html?simple.html"); std::wstring new_window_url = GetSimplePageUrl(); MockAccEventObserver acc_observer; @@ -741,6 +758,13 @@ void CloseWindow(HWND* window) { // We bring up the Save dialog via accessibility and save the file // and validate that all is well. TEST_F(FullTabDownloadTest, CF_DownloadFileFromPost) { + // Please see http://code.google.com/p/chromium/issues/detail?id=60987 + // for more information on why this test is disabled for Vista with IE7. + if (base::win::GetVersion() == base::win::VERSION_VISTA && + GetInstalledIEVersion() == IE_7) { + LOG(INFO) << "Not running test on Vista with IE7"; + return; + } chrome_frame_test::MockWindowObserver download_watcher; download_watcher.WatchWindow("File Download", ""); diff --git a/chrome_frame/test/test_with_web_server.cc b/chrome_frame/test/test_with_web_server.cc index 99643e0..c3bce42 100644 --- a/chrome_frame/test/test_with_web_server.cc +++ b/chrome_frame/test/test_with_web_server.cc @@ -1022,10 +1022,25 @@ const wchar_t kWindowCloseTestUrl[] = L"window_close.html"; TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_WindowClose) { + // Please see http://code.google.com/p/chromium/issues/detail?id=60987 + // for more information on why this test is disabled for Vista with IE7. + if (base::win::GetVersion() == base::win::VERSION_VISTA && + chrome_frame_test::GetInstalledIEVersion() == IE_7) { + LOG(INFO) << "Not running test on Vista with IE7"; + return; + } + SimpleBrowserTest(IE, kWindowCloseTestUrl); } TEST_F(ChromeFrameTestWithWebServer, FullTabModeFF_WindowClose) { + // Please see http://code.google.com/p/chromium/issues/detail?id=60987 + // for more information on why this test is disabled for Vista with IE7. + if (base::win::GetVersion() == base::win::VERSION_VISTA && + chrome_frame_test::GetInstalledIEVersion() == IE_7) { + LOG(INFO) << "Not running test on Vista with IE7"; + return; + } SimpleBrowserTest(FIREFOX, kWindowCloseTestUrl); } diff --git a/chrome_frame/test/ui_test.cc b/chrome_frame/test/ui_test.cc index 3c4d78a..a355d0e 100644 --- a/chrome_frame/test/ui_test.cc +++ b/chrome_frame/test/ui_test.cc @@ -9,6 +9,7 @@ #include "base/utf_string_conversions.h" #include "base/win/scoped_bstr.h" #include "base/win/scoped_variant.h" +#include "base/win/windows_version.h" #include "chrome/common/url_constants.h" #include "chrome_frame/test/chrome_frame_test_utils.h" #include "chrome_frame/test/chrome_frame_ui_test_utils.h" @@ -222,6 +223,14 @@ TEST_P(FullTabUITest, RendererHasFocus) { // Tests that view source works. TEST_P(FullTabUITest, ViewSource) { + // Please see http://code.google.com/p/chromium/issues/detail?id=60987 + // for more information on why this test is disabled for Vista with IE7. + if (base::win::GetVersion() == base::win::VERSION_VISTA && + GetInstalledIEVersion() == IE_7) { + LOG(INFO) << "Not running test on Vista with IE7"; + return; + } + bool in_cf = GetParam().invokes_cf(); if (!in_cf) { LOG(ERROR) << "Test not implemented for this configuration."; @@ -414,6 +423,13 @@ TEST_F(ContextMenuTest, CFReload) { // Test view source from the context menu. TEST_F(ContextMenuTest, CFViewSource) { + // Please see http://code.google.com/p/chromium/issues/detail?id=60987 + // for more information on why this test is disabled for Vista with IE7. + if (base::win::GetVersion() == base::win::VERSION_VISTA && + GetInstalledIEVersion() == IE_7) { + LOG(INFO) << "Not running test on Vista with IE7"; + return; + } server_mock_.ExpectAndServeAnyRequests(CFInvocation::MetaTag()); MockIEEventSink view_source_mock; view_source_mock.ExpectAnyNavigations(); @@ -500,15 +516,36 @@ TEST_F(ContextMenuTest, CFInspector) { } TEST_F(ContextMenuTest, CFSavePageAs) { + // Please see http://code.google.com/p/chromium/issues/detail?id=60987 + // for more information on why this test is disabled for Vista with IE7. + if (base::win::GetVersion() == base::win::VERSION_VISTA && + GetInstalledIEVersion() == IE_7) { + LOG(INFO) << "Not running test on Vista with IE7"; + return; + } ASSERT_NO_FATAL_FAILURE(DoSaveAsTest(L"", L"Save as...", L".html")); } TEST_F(ContextMenuTest, CFSaveLinkAs) { + // Please see http://code.google.com/p/chromium/issues/detail?id=60987 + // for more information on why this test is disabled for Vista with IE7. + if (base::win::GetVersion() == base::win::VERSION_VISTA && + GetInstalledIEVersion() == IE_7) { + LOG(INFO) << "Not running test on Vista with IE7"; + return; + } ASSERT_NO_FATAL_FAILURE(DoSaveAsTest(L"link", L"Save link as...", L".zip")); } // This tests that the about:version page can be opened via the CF context menu. TEST_F(ContextMenuTest, CFAboutVersionLoads) { + // Please see http://code.google.com/p/chromium/issues/detail?id=60987 + // for more information on why this test is disabled for Vista with IE7. + if (base::win::GetVersion() == base::win::VERSION_VISTA && + GetInstalledIEVersion() == IE_7) { + LOG(INFO) << "Not running test on Vista with IE7"; + return; + } server_mock_.ExpectAndServeAnyRequests(CFInvocation::MetaTag()); const wchar_t* kAboutVersionUrl = L"gcf:about:version"; const wchar_t* kAboutVersionWithoutProtoUrl = L"about:version"; |