summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorxhwang@chromium.org <xhwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-12-28 20:18:21 +0000
committerxhwang@chromium.org <xhwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-12-28 20:18:21 +0000
commita47fccd356705a7d92cc83b03150c9782167f8c4 (patch)
treec91168ff6b25eeab818db0571d4e84d8ddcad612
parentdd8ba224cd407d5962f42d05aff0ba96c526fdbf (diff)
downloadchromium_src-a47fccd356705a7d92cc83b03150c9782167f8c4.zip
chromium_src-a47fccd356705a7d92cc83b03150c9782167f8c4.tar.gz
chromium_src-a47fccd356705a7d92cc83b03150c9782167f8c4.tar.bz2
Add CHECK to investigate the root cause of issue 103957.
New evidence suggests that the root cause of issue 103957 may be that the plugin failed to load (see comments of issue 103957). Adding new CHECKs to confirm this. Will remove the CHECK after this is confirmed. BUG=none TEST=none Review URL: http://codereview.chromium.org/9044010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115913 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--content/ppapi_plugin/ppapi_thread.cc3
1 files changed, 3 insertions, 0 deletions
diff --git a/content/ppapi_plugin/ppapi_thread.cc b/content/ppapi_plugin/ppapi_thread.cc
index 31c8275..94e27dd 100644
--- a/content/ppapi_plugin/ppapi_thread.cc
+++ b/content/ppapi_plugin/ppapi_thread.cc
@@ -246,6 +246,9 @@ void PpapiThread::OnMsgCreateChannel(base::ProcessHandle host_process_handle,
if (!library_.is_valid() || // Plugin couldn't be loaded.
!SetupRendererChannel(host_process_handle, renderer_id,
&channel_handle)) {
+ // Add CHECK to investigate the root cause of crbug.com/103957. Will remove
+ // after the bug is fixed.
+ CHECK(library_.is_valid());
Send(new PpapiHostMsg_ChannelCreated(IPC::ChannelHandle()));
return;
}