diff options
author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-07 15:37:39 +0000 |
---|---|---|
committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-07 15:37:39 +0000 |
commit | b0be612aea5fa64e03c883b85a5e69ed595aadaa (patch) | |
tree | e2d6b043b6b115133f1e615c9c119992cdcaed03 | |
parent | aa48f23afd2a93fbac319a1d19d9fa937b2976b1 (diff) | |
download | chromium_src-b0be612aea5fa64e03c883b85a5e69ed595aadaa.zip chromium_src-b0be612aea5fa64e03c883b85a5e69ed595aadaa.tar.gz chromium_src-b0be612aea5fa64e03c883b85a5e69ed595aadaa.tar.bz2 |
Makes instant not supress infobars. As part of this I'm removing
unnecessary overrides in instant's TabContentsDelegate implementation.
BUG=68540
TEST=see bug
Review URL: http://codereview.chromium.org/6152001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70739 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/browser/instant/instant_loader.cc | 53 |
1 files changed, 0 insertions, 53 deletions
diff --git a/chrome/browser/instant/instant_loader.cc b/chrome/browser/instant/instant_loader.cc index 1fe0390..3d8189d 100644 --- a/chrome/browser/instant/instant_loader.cc +++ b/chrome/browser/instant/instant_loader.cc @@ -296,10 +296,6 @@ class InstantLoader::TabContentsDelegateImpl : public TabContentsDelegate { virtual void LoadingStateChanged(TabContents* source) {} virtual void CloseContents(TabContents* source) {} virtual void MoveContents(TabContents* source, const gfx::Rect& pos) {} - virtual void DetachContents(TabContents* source) {} - virtual bool IsPopup(const TabContents* source) const { - return false; - } virtual bool ShouldFocusConstrainedWindow() { // Return false so that constrained windows are not initially focused. If // we did otherwise the preview would prematurely get committed when focus @@ -317,15 +313,6 @@ class InstantLoader::TabContentsDelegateImpl : public TabContentsDelegate { virtual void ToolbarSizeChanged(TabContents* source, bool is_animating) {} virtual void URLStarredChanged(TabContents* source, bool starred) {} virtual void UpdateTargetURL(TabContents* source, const GURL& url) {} - virtual void ContentsMouseEvent( - TabContents* source, const gfx::Point& location, bool motion) {} - virtual void ContentsZoomChange(bool zoom_in) {} - virtual void OnContentSettingsChange(TabContents* source) {} - virtual bool IsApplication() const { return false; } - virtual void ConvertContentsToApplication(TabContents* source) {} - virtual bool CanReloadContents(TabContents* source) const { return true; } - virtual void ShowHtmlDialog(HtmlDialogUIDelegate* delegate, - gfx::NativeWindow parent_window) {} virtual bool ShouldSuppressDialogs() { // Any message shown during instant cancels instant, so we suppress them. return true; @@ -333,48 +320,18 @@ class InstantLoader::TabContentsDelegateImpl : public TabContentsDelegate { virtual void BeforeUnloadFired(TabContents* tab, bool proceed, bool* proceed_to_fire_unload) {} - virtual void ForwardMessageToExternalHost(const std::string& message, - const std::string& origin, - const std::string& target) {} - virtual bool IsExternalTabContainer() const { return false; } virtual void SetFocusToLocationBar(bool select_all) {} virtual bool ShouldFocusPageAfterCrash() { return false; } - virtual void RenderWidgetShowing() {} - virtual bool TakeFocus(bool reverse) { return false; } virtual void LostCapture() { CommitFromMouseReleaseIfNecessary(); } - virtual void SetTabContentBlocked(TabContents* contents, bool blocked) {} - virtual void TabContentsFocused(TabContents* tab_content) { - } - virtual int GetExtraRenderViewHeight() const { return 0; } virtual bool CanDownload(int request_id) { return false; } - virtual void OnStartDownload(DownloadItem* download, TabContents* tab) {} - virtual bool HandleContextMenu(const ContextMenuParams& params) { - return false; - } - virtual bool ExecuteContextMenuCommand(int command) { - return false; - } - virtual void ConfirmAddSearchProvider(const TemplateURL* template_url, - Profile* profile) {} - virtual void ShowPageInfo(Profile* profile, - const GURL& url, - const NavigationEntry::SSLStatus& ssl, - bool show_history) {} - virtual bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event, - bool* is_keyboard_shortcut) { - return false; - } virtual void HandleMouseUp() { CommitFromMouseReleaseIfNecessary(); } virtual void HandleMouseActivate() { is_mouse_down_from_activate_ = true; } - virtual void ShowRepostFormWarningDialog(TabContents* tab_contents) {} - virtual void ShowContentSettingsWindow(ContentSettingsType content_type) {} - virtual void ShowCollectedCookiesDialog(TabContents* tab_contents) {} virtual bool OnGoToEntryOffset(int offset) { return false; } virtual bool ShouldAddNavigationToHistory( const history::HistoryAddPageArgs& add_page_args, @@ -388,16 +345,6 @@ class InstantLoader::TabContentsDelegateImpl : public TabContentsDelegate { } return false; } - virtual void OnDidGetApplicationInfo(TabContents* tab_contents, - int32 page_id) {} - virtual gfx::NativeWindow GetFrameNativeWindow() { - return NULL; - } - virtual void TabContentsCreated(TabContents* new_contents) {} - virtual bool infobars_enabled() { return false; } - virtual bool ShouldEnablePreferredSizeNotifications() { return false; } - virtual void UpdatePreferredSize(const gfx::Size& pref_size) {} - virtual void ContentTypeChanged(TabContents* source) {} virtual void OnSetSuggestions(int32 page_id, const std::vector<std::string>& suggestions) { |