summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsaintlou@chromium.org <saintlou@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-07-20 23:17:19 +0000
committersaintlou@chromium.org <saintlou@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-07-20 23:17:19 +0000
commitb5eb0e91a4733f9806814e41b9470209b91d0aaf (patch)
treed6424be3ecfee4941fa75c6bd6ae2795f83ba519
parent8b788e3e23b32d6bc49256d42314a2f6c6ea78f1 (diff)
downloadchromium_src-b5eb0e91a4733f9806814e41b9470209b91d0aaf.zip
chromium_src-b5eb0e91a4733f9806814e41b9470209b91d0aaf.tar.gz
chromium_src-b5eb0e91a4733f9806814e41b9470209b91d0aaf.tar.bz2
Dup of Issue 7465011: Larger Combo box Hit Targets for TOUCH_UI
BUG=none TEST=none Review URL: http://codereview.chromium.org/7465012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93279 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--ui/gfx/native_theme.h2
-rw-r--r--ui/gfx/native_theme_chromeos.cc8
-rw-r--r--ui/gfx/native_theme_chromeos.h2
-rw-r--r--webkit/glue/webthemeengine_impl_linux.cc5
-rw-r--r--webkit/glue/webthemeengine_impl_linux.h3
5 files changed, 19 insertions, 1 deletions
diff --git a/ui/gfx/native_theme.h b/ui/gfx/native_theme.h
index 2f1ba70..ceab5c3 100644
--- a/ui/gfx/native_theme.h
+++ b/ui/gfx/native_theme.h
@@ -205,6 +205,8 @@ class UI_API NativeTheme {
const gfx::Rect& rect,
const ExtraParams& extra) const = 0;
+ virtual int GetPopupListBoxMinimumRowHeight() const { return 0; }
+
// Supports theme specific colors.
void SetScrollbarColors(unsigned inactive_color,
unsigned active_color,
diff --git a/ui/gfx/native_theme_chromeos.cc b/ui/gfx/native_theme_chromeos.cc
index a12b45f..22e6bbe 100644
--- a/ui/gfx/native_theme_chromeos.cc
+++ b/ui/gfx/native_theme_chromeos.cc
@@ -301,6 +301,14 @@ gfx::Size NativeThemeChromeos::GetPartSize(Part part,
return gfx::Size(width, height);
}
+int NativeThemeChromeos::GetPopupListBoxMinimumRowHeight() const {
+#if defined(TOUCH_UI)
+ return 60;
+#else
+ return 0;
+#endif
+}
+
void NativeThemeChromeos::PaintScrollbarTrack(
SkCanvas* canvas,
Part part,
diff --git a/ui/gfx/native_theme_chromeos.h b/ui/gfx/native_theme_chromeos.h
index 1e1b84f..609ecd7 100644
--- a/ui/gfx/native_theme_chromeos.h
+++ b/ui/gfx/native_theme_chromeos.h
@@ -22,6 +22,8 @@ class NativeThemeChromeos : public gfx::NativeThemeLinux {
State state,
const ExtraParams& extra) const OVERRIDE;
+ virtual int GetPopupListBoxMinimumRowHeight() const OVERRIDE;
+
// NativeThemeLinux overrides
virtual void PaintScrollbarTrack(SkCanvas* canvas,
Part part, State state,
diff --git a/webkit/glue/webthemeengine_impl_linux.cc b/webkit/glue/webthemeengine_impl_linux.cc
index 6726158..fd1bdd8 100644
--- a/webkit/glue/webthemeengine_impl_linux.cc
+++ b/webkit/glue/webthemeengine_impl_linux.cc
@@ -182,4 +182,9 @@ void WebThemeEngineImpl::paint(
WebRectToRect(rect),
native_theme_extra_params);
}
+
+int WebThemeEngineImpl::getPopupListBoxMinimumRowHeight() const {
+ return gfx::NativeTheme::instance()->GetPopupListBoxMinimumRowHeight();
+}
+
} // namespace webkit_glue
diff --git a/webkit/glue/webthemeengine_impl_linux.h b/webkit/glue/webthemeengine_impl_linux.h
index 3dcba6d..717d691 100644
--- a/webkit/glue/webthemeengine_impl_linux.h
+++ b/webkit/glue/webthemeengine_impl_linux.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -19,6 +19,7 @@ class WebThemeEngineImpl : public WebKit::WebThemeEngine {
WebKit::WebThemeEngine::State,
const WebKit::WebRect&,
const WebKit::WebThemeEngine::ExtraParams*);
+ virtual int getPopupListBoxMinimumRowHeight() const;
};
} // namespace webkit_glue