summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorakalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-04-02 13:47:01 +0000
committerakalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-04-02 13:47:01 +0000
commitd2106bc916c93d388c87327fd390ef35a85ec991 (patch)
treed7d38cd5bfd49d1e0672086ea04daa5e98871d68
parent40cb8e0cc19c8b2d192a1d62389cc0da34725fea (diff)
downloadchromium_src-d2106bc916c93d388c87327fd390ef35a85ec991.zip
chromium_src-d2106bc916c93d388c87327fd390ef35a85ec991.tar.gz
chromium_src-d2106bc916c93d388c87327fd390ef35a85ec991.tar.bz2
Move URLFetcherImpl::Core into its own class and file
This is the first step of moving URLFetcher to net. This turns URLFetcherImpl into a wrapper around URLFetcherCore. Remove some unused functions. Make URLFetcher::GetExtraRequestHeaders() const. BUG=118220 TEST= Review URL: http://codereview.chromium.org/9838031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130119 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--content/common/net/url_fetcher_core.cc923
-rw-r--r--content/common/net/url_fetcher_core.h387
-rw-r--r--content/common/net/url_fetcher_impl.cc1163
-rw-r--r--content/common/net/url_fetcher_impl.h31
-rw-r--r--content/content_common.gypi2
-rw-r--r--content/public/common/url_fetcher.h3
-rw-r--r--content/test/test_url_fetcher_factory.cc3
-rw-r--r--content/test/test_url_fetcher_factory.h2
8 files changed, 1363 insertions, 1151 deletions
diff --git a/content/common/net/url_fetcher_core.cc b/content/common/net/url_fetcher_core.cc
new file mode 100644
index 0000000..deaa864
--- /dev/null
+++ b/content/common/net/url_fetcher_core.cc
@@ -0,0 +1,923 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/common/net/url_fetcher_core.h"
+
+#include "base/bind.h"
+#include "base/file_util_proxy.h"
+#include "base/logging.h"
+#include "base/message_loop_proxy.h"
+#include "base/metrics/histogram.h"
+#include "base/stl_util.h"
+#include "base/tracked_objects.h"
+#include "content/common/net/url_request_user_data.h"
+#include "content/public/common/url_fetcher_delegate.h"
+#include "net/base/io_buffer.h"
+#include "net/base/load_flags.h"
+#include "net/base/net_errors.h"
+#include "net/http/http_response_headers.h"
+#include "net/url_request/url_request_context_getter.h"
+#include "net/url_request/url_request_throttler_manager.h"
+
+namespace content {
+
+static const int kBufferSize = 4096;
+static const int kUploadProgressTimerInterval = 100;
+
+URLFetcherCore::Registry::Registry() {}
+URLFetcherCore::Registry::~Registry() {}
+
+void URLFetcherCore::Registry::AddURLFetcherCore(URLFetcherCore* core) {
+ DCHECK(!ContainsKey(fetchers_, core));
+ fetchers_.insert(core);
+}
+
+void URLFetcherCore::Registry::RemoveURLFetcherCore(URLFetcherCore* core) {
+ DCHECK(ContainsKey(fetchers_, core));
+ fetchers_.erase(core);
+}
+
+void URLFetcherCore::Registry::CancelAll() {
+ while (!fetchers_.empty())
+ (*fetchers_.begin())->CancelURLRequest();
+}
+
+// static
+base::LazyInstance<URLFetcherCore::Registry>
+ URLFetcherCore::g_registry = LAZY_INSTANCE_INITIALIZER;
+
+URLFetcherCore::FileWriter::FileWriter(
+ URLFetcherCore* core,
+ scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy)
+ : core_(core),
+ error_code_(base::PLATFORM_FILE_OK),
+ ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)),
+ file_message_loop_proxy_(file_message_loop_proxy),
+ file_handle_(base::kInvalidPlatformFileValue) {
+}
+
+URLFetcherCore::FileWriter::~FileWriter() {
+ RemoveFile();
+}
+
+void URLFetcherCore::FileWriter::CreateFileAtPath(
+ const FilePath& file_path) {
+ DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
+ DCHECK(file_message_loop_proxy_.get());
+ base::FileUtilProxy::CreateOrOpen(
+ file_message_loop_proxy_,
+ file_path,
+ base::PLATFORM_FILE_CREATE_ALWAYS | base::PLATFORM_FILE_WRITE,
+ base::Bind(&URLFetcherCore::FileWriter::DidCreateFile,
+ weak_factory_.GetWeakPtr(),
+ file_path));
+}
+
+void URLFetcherCore::FileWriter::CreateTempFile() {
+ DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
+ DCHECK(file_message_loop_proxy_.get());
+ base::FileUtilProxy::CreateTemporary(
+ file_message_loop_proxy_,
+ 0, // No additional file flags.
+ base::Bind(&URLFetcherCore::FileWriter::DidCreateTempFile,
+ weak_factory_.GetWeakPtr()));
+}
+
+void URLFetcherCore::FileWriter::WriteBuffer(int num_bytes) {
+ DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
+
+ // Start writing to the file by setting the initial state
+ // of |pending_bytes_| and |buffer_offset_| to indicate that the
+ // entire buffer has not yet been written.
+ pending_bytes_ = num_bytes;
+ buffer_offset_ = 0;
+ ContinueWrite(base::PLATFORM_FILE_OK, 0);
+}
+
+void URLFetcherCore::FileWriter::ContinueWrite(
+ base::PlatformFileError error_code,
+ int bytes_written) {
+ DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
+
+ if (file_handle_ == base::kInvalidPlatformFileValue) {
+ // While a write was being done on the file thread, a request
+ // to close or disown the file occured on the IO thread. At
+ // this point a request to close the file is pending on the
+ // file thread.
+ return;
+ }
+
+ // Every code path that resets |core_->request_| should reset
+ // |core->file_writer_| or cause the file writer to disown the file. In the
+ // former case, this callback can not be called, because the weak pointer to
+ // |this| will be NULL. In the latter case, the check of |file_handle_| at the
+ // start of this method ensures that we can not reach this point.
+ CHECK(core_->request_.get());
+
+ if (base::PLATFORM_FILE_OK != error_code) {
+ error_code_ = error_code;
+ RemoveFile();
+ core_->delegate_loop_proxy_->PostTask(
+ FROM_HERE,
+ base::Bind(&URLFetcherCore::InformDelegateFetchIsComplete, core_));
+ return;
+ }
+
+ total_bytes_written_ += bytes_written;
+ buffer_offset_ += bytes_written;
+ pending_bytes_ -= bytes_written;
+
+ if (pending_bytes_ > 0) {
+ base::FileUtilProxy::Write(
+ file_message_loop_proxy_, file_handle_,
+ total_bytes_written_, // Append to the end
+ (core_->buffer_->data() + buffer_offset_), pending_bytes_,
+ base::Bind(&URLFetcherCore::FileWriter::ContinueWrite,
+ weak_factory_.GetWeakPtr()));
+ } else {
+ // Finished writing core_->buffer_ to the file. Read some more.
+ core_->ReadResponse();
+ }
+}
+
+void URLFetcherCore::FileWriter::DisownFile() {
+ DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
+
+ // Disowning is done by the delegate's OnURLFetchComplete method.
+ // The file should be closed by the time that method is called.
+ DCHECK(file_handle_ == base::kInvalidPlatformFileValue);
+
+ // Forget about any file by reseting the path.
+ file_path_.clear();
+}
+
+void URLFetcherCore::FileWriter::CloseFileAndCompleteRequest() {
+ DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
+
+ if (file_handle_ != base::kInvalidPlatformFileValue) {
+ base::FileUtilProxy::Close(
+ file_message_loop_proxy_, file_handle_,
+ base::Bind(&URLFetcherCore::FileWriter::DidCloseFile,
+ weak_factory_.GetWeakPtr()));
+ file_handle_ = base::kInvalidPlatformFileValue;
+ }
+}
+
+void URLFetcherCore::FileWriter::DidCreateFile(
+ const FilePath& file_path,
+ base::PlatformFileError error_code,
+ base::PassPlatformFile file_handle,
+ bool created) {
+ DidCreateFileInternal(file_path, error_code, file_handle);
+}
+
+void URLFetcherCore::FileWriter::DidCreateTempFile(
+ base::PlatformFileError error_code,
+ base::PassPlatformFile file_handle,
+ const FilePath& file_path) {
+ DidCreateFileInternal(file_path, error_code, file_handle);
+}
+
+void URLFetcherCore::FileWriter::DidCreateFileInternal(
+ const FilePath& file_path,
+ base::PlatformFileError error_code,
+ base::PassPlatformFile file_handle) {
+ DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
+
+ if (base::PLATFORM_FILE_OK != error_code) {
+ error_code_ = error_code;
+ RemoveFile();
+ core_->delegate_loop_proxy_->PostTask(
+ FROM_HERE,
+ base::Bind(&URLFetcherCore::InformDelegateFetchIsComplete, core_));
+ return;
+ }
+
+ file_path_ = file_path;
+ file_handle_ = file_handle.ReleaseValue();
+ total_bytes_written_ = 0;
+
+ core_->io_message_loop_proxy_->PostTask(
+ FROM_HERE,
+ base::Bind(&URLFetcherCore::StartURLRequestWhenAppropriate, core_));
+}
+
+void URLFetcherCore::FileWriter::DidCloseFile(
+ base::PlatformFileError error_code) {
+ DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
+
+ if (base::PLATFORM_FILE_OK != error_code) {
+ error_code_ = error_code;
+ RemoveFile();
+ core_->delegate_loop_proxy_->PostTask(
+ FROM_HERE,
+ base::Bind(&URLFetcherCore::InformDelegateFetchIsComplete, core_));
+ return;
+ }
+
+ // If the file was successfully closed, then the URL request is complete.
+ core_->RetryOrCompleteUrlFetch();
+}
+
+void URLFetcherCore::FileWriter::RemoveFile() {
+ DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
+
+ // Close the file if it is open.
+ if (file_handle_ != base::kInvalidPlatformFileValue) {
+ base::FileUtilProxy::Close(
+ file_message_loop_proxy_, file_handle_,
+ base::FileUtilProxy::StatusCallback()); // No callback: Ignore errors.
+ file_handle_ = base::kInvalidPlatformFileValue;
+ }
+
+ if (!file_path_.empty()) {
+ base::FileUtilProxy::Delete(
+ file_message_loop_proxy_, file_path_,
+ false, // No need to recurse, as the path is to a file.
+ base::FileUtilProxy::StatusCallback()); // No callback: Ignore errors.
+ DisownFile();
+ }
+}
+
+static bool g_interception_enabled = false;
+
+URLFetcherCore::URLFetcherCore(URLFetcher* fetcher,
+ const GURL& original_url,
+ URLFetcher::RequestType request_type,
+ content::URLFetcherDelegate* d)
+ : fetcher_(fetcher),
+ original_url_(original_url),
+ request_type_(request_type),
+ delegate_(d),
+ delegate_loop_proxy_(
+ base::MessageLoopProxy::current()),
+ request_(NULL),
+ load_flags_(net::LOAD_NORMAL),
+ response_code_(URLFetcher::RESPONSE_CODE_INVALID),
+ buffer_(new net::IOBuffer(kBufferSize)),
+ render_process_id_(-1),
+ render_view_id_(-1),
+ was_fetched_via_proxy_(false),
+ is_chunked_upload_(false),
+ num_retries_(0),
+ was_cancelled_(false),
+ response_destination_(STRING),
+ automatically_retry_on_5xx_(true),
+ max_retries_(0),
+ current_upload_bytes_(-1),
+ current_response_bytes_(0),
+ total_response_bytes_(-1) {
+}
+
+URLFetcherCore::~URLFetcherCore() {
+ // |request_| should be NULL. If not, it's unsafe to delete it here since we
+ // may not be on the IO thread.
+ DCHECK(!request_.get());
+}
+
+void URLFetcherCore::Start() {
+ DCHECK(delegate_loop_proxy_);
+ DCHECK(request_context_getter_) << "We need an URLRequestContext!";
+ if (io_message_loop_proxy_) {
+ DCHECK_EQ(io_message_loop_proxy_,
+ request_context_getter_->GetIOMessageLoopProxy());
+ } else {
+ io_message_loop_proxy_ = request_context_getter_->GetIOMessageLoopProxy();
+ }
+ DCHECK(io_message_loop_proxy_.get()) << "We need an IO message loop proxy";
+
+ io_message_loop_proxy_->PostTask(
+ FROM_HERE, base::Bind(&URLFetcherCore::StartOnIOThread, this));
+}
+
+void URLFetcherCore::StartOnIOThread() {
+ DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
+
+ switch (response_destination_) {
+ case STRING:
+ StartURLRequestWhenAppropriate();
+ break;
+
+ case PERMANENT_FILE:
+ case TEMP_FILE:
+ DCHECK(file_message_loop_proxy_.get())
+ << "Need to set the file message loop proxy.";
+
+ file_writer_.reset(new FileWriter(this, file_message_loop_proxy_));
+
+ // If the file is successfully created,
+ // URLFetcherCore::StartURLRequestWhenAppropriate() will be called.
+ switch (response_destination_) {
+ case PERMANENT_FILE:
+ file_writer_->CreateFileAtPath(response_destination_file_path_);
+ break;
+ case TEMP_FILE:
+ file_writer_->CreateTempFile();
+ break;
+ default:
+ NOTREACHED();
+ }
+ break;
+
+ default:
+ NOTREACHED();
+ }
+}
+
+void URLFetcherCore::Stop() {
+ if (delegate_loop_proxy_) // May be NULL in tests.
+ DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
+
+ delegate_ = NULL;
+ fetcher_ = NULL;
+ if (io_message_loop_proxy_.get()) {
+ io_message_loop_proxy_->PostTask(
+ FROM_HERE, base::Bind(&URLFetcherCore::CancelURLRequest, this));
+ }
+}
+
+void URLFetcherCore::SetUploadData(const std::string& upload_content_type,
+ const std::string& upload_content) {
+ DCHECK(!is_chunked_upload_);
+ upload_content_type_ = upload_content_type;
+ upload_content_ = upload_content;
+}
+
+void URLFetcherCore::SetChunkedUpload(const std::string& content_type) {
+ DCHECK(is_chunked_upload_ ||
+ (upload_content_type_.empty() &&
+ upload_content_.empty()));
+ upload_content_type_ = content_type;
+ upload_content_.clear();
+ is_chunked_upload_ = true;
+}
+
+void URLFetcherCore::AppendChunkToUpload(const std::string& content,
+ bool is_last_chunk) {
+ DCHECK(delegate_loop_proxy_);
+ DCHECK(io_message_loop_proxy_.get());
+ io_message_loop_proxy_->PostTask(
+ FROM_HERE,
+ base::Bind(&URLFetcherCore::CompleteAddingUploadDataChunk, this, content,
+ is_last_chunk));
+}
+
+void URLFetcherCore::SetLoadFlags(int load_flags) {
+ load_flags_ = load_flags;
+}
+
+int URLFetcherCore::GetLoadFlags() const {
+ return load_flags_;
+}
+
+void URLFetcherCore::SetReferrer(const std::string& referrer) {
+ referrer_ = referrer;
+}
+
+void URLFetcherCore::SetExtraRequestHeaders(
+ const std::string& extra_request_headers) {
+ extra_request_headers_.Clear();
+ extra_request_headers_.AddHeadersFromString(extra_request_headers);
+}
+
+void URLFetcherCore::AddExtraRequestHeader(const std::string& header_line) {
+ extra_request_headers_.AddHeaderFromString(header_line);
+}
+
+void URLFetcherCore::GetExtraRequestHeaders(
+ net::HttpRequestHeaders* headers) const {
+ headers->CopyFrom(extra_request_headers_);
+}
+
+void URLFetcherCore::SetRequestContext(
+ net::URLRequestContextGetter* request_context_getter) {
+ DCHECK(!request_context_getter_);
+ request_context_getter_ = request_context_getter;
+}
+
+void URLFetcherCore::AssociateWithRenderView(
+ const GURL& first_party_for_cookies,
+ int render_process_id,
+ int render_view_id) {
+ DCHECK(first_party_for_cookies_.is_empty());
+ DCHECK_EQ(render_process_id_, -1);
+ DCHECK_EQ(render_view_id_, -1);
+ DCHECK_GE(render_process_id, 0);
+ DCHECK_GE(render_view_id, 0);
+ first_party_for_cookies_ = first_party_for_cookies;
+ render_process_id_ = render_process_id;
+ render_view_id_ = render_view_id;
+}
+
+void URLFetcherCore::SetAutomaticallyRetryOn5xx(bool retry) {
+ automatically_retry_on_5xx_ = retry;
+}
+
+void URLFetcherCore::SetMaxRetries(int max_retries) {
+ max_retries_ = max_retries;
+}
+
+int URLFetcherCore::GetMaxRetries() const {
+ return max_retries_;
+}
+
+
+base::TimeDelta URLFetcherCore::GetBackoffDelay() const {
+ return backoff_delay_;
+}
+
+void URLFetcherCore::SaveResponseToFileAtPath(
+ const FilePath& file_path,
+ scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy) {
+ DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
+ file_message_loop_proxy_ = file_message_loop_proxy;
+ response_destination_ = content::URLFetcherCore::PERMANENT_FILE;
+ response_destination_file_path_ = file_path;
+}
+
+void URLFetcherCore::SaveResponseToTemporaryFile(
+ scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy) {
+ DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
+ file_message_loop_proxy_ = file_message_loop_proxy;
+ response_destination_ = content::URLFetcherCore::TEMP_FILE;
+}
+
+net::HttpResponseHeaders* URLFetcherCore::GetResponseHeaders() const {
+ return response_headers_;
+}
+
+// TODO(panayiotis): socket_address_ is written in the IO thread,
+// if this is accessed in the UI thread, this could result in a race.
+// Same for response_headers_ above and was_fetched_via_proxy_ below.
+net::HostPortPair URLFetcherCore::GetSocketAddress() const {
+ return socket_address_;
+}
+
+bool URLFetcherCore::WasFetchedViaProxy() const {
+ return was_fetched_via_proxy_;
+}
+
+const GURL& URLFetcherCore::GetOriginalURL() const {
+ return original_url_;
+}
+
+const GURL& URLFetcherCore::GetURL() const {
+ return url_;
+}
+
+const net::URLRequestStatus& URLFetcherCore::GetStatus() const {
+ return status_;
+}
+
+int URLFetcherCore::GetResponseCode() const {
+ return response_code_;
+}
+
+const net::ResponseCookies& URLFetcherCore::GetCookies() const {
+ return cookies_;
+}
+
+bool URLFetcherCore::FileErrorOccurred(
+ base::PlatformFileError* out_error_code) const {
+
+ // Can't have a file error if no file is being created or written to.
+ if (!file_writer_.get())
+ return false;
+
+ base::PlatformFileError error_code = file_writer_->error_code();
+ if (error_code == base::PLATFORM_FILE_OK)
+ return false;
+
+ *out_error_code = error_code;
+ return true;
+}
+
+void URLFetcherCore::ReceivedContentWasMalformed() {
+ DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
+ if (io_message_loop_proxy_.get()) {
+ io_message_loop_proxy_->PostTask(
+ FROM_HERE, base::Bind(&URLFetcherCore::NotifyMalformedContent, this));
+ }
+}
+
+bool URLFetcherCore::GetResponseAsString(
+ std::string* out_response_string) const {
+ if (response_destination_ != content::URLFetcherCore::STRING)
+ return false;
+
+ *out_response_string = data_;
+ UMA_HISTOGRAM_MEMORY_KB("UrlFetcher.StringResponseSize",
+ (data_.length() / 1024));
+
+ return true;
+}
+
+bool URLFetcherCore::GetResponseAsFilePath(bool take_ownership,
+ FilePath* out_response_path) {
+ DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
+ const bool destination_is_file =
+ response_destination_ == content::URLFetcherCore::TEMP_FILE ||
+ response_destination_ == content::URLFetcherCore::PERMANENT_FILE;
+ if (!destination_is_file || !file_writer_.get())
+ return false;
+
+ *out_response_path = file_writer_->file_path();
+
+ if (take_ownership) {
+ io_message_loop_proxy_->PostTask(
+ FROM_HERE,
+ base::Bind(&content::URLFetcherCore::DisownFile, this));
+ }
+ return true;
+}
+
+void URLFetcherCore::CancelAll() {
+ g_registry.Get().CancelAll();
+}
+
+int URLFetcherCore::GetNumFetcherCores() {
+ return g_registry.Get().size();
+}
+
+void URLFetcherCore::SetEnableInterceptionForTests(bool enabled) {
+ g_interception_enabled = enabled;
+}
+
+void URLFetcherCore::OnResponseStarted(net::URLRequest* request) {
+ DCHECK_EQ(request, request_.get());
+ DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
+ if (request_->status().is_success()) {
+ response_code_ = request_->GetResponseCode();
+ response_headers_ = request_->response_headers();
+ socket_address_ = request_->GetSocketAddress();
+ was_fetched_via_proxy_ = request_->was_fetched_via_proxy();
+ total_response_bytes_ = request_->GetExpectedContentSize();
+ }
+
+ ReadResponse();
+}
+
+void URLFetcherCore::CompleteAddingUploadDataChunk(
+ const std::string& content, bool is_last_chunk) {
+ DCHECK(is_chunked_upload_);
+ DCHECK(request_.get());
+ DCHECK(!content.empty());
+ request_->AppendChunkToUpload(content.data(),
+ static_cast<int>(content.length()),
+ is_last_chunk);
+}
+
+// Return true if the write was done and reading may continue.
+// Return false if the write is pending, and the next read will
+// be done later.
+bool URLFetcherCore::WriteBuffer(int num_bytes) {
+ bool write_complete = false;
+ switch (response_destination_) {
+ case STRING:
+ data_.append(buffer_->data(), num_bytes);
+ write_complete = true;
+ break;
+
+ case PERMANENT_FILE:
+ case TEMP_FILE:
+ file_writer_->WriteBuffer(num_bytes);
+ // WriteBuffer() sends a request the file thread.
+ // The write is not done yet.
+ write_complete = false;
+ break;
+
+ default:
+ NOTREACHED();
+ }
+ return write_complete;
+}
+
+void URLFetcherCore::OnReadCompleted(net::URLRequest* request,
+ int bytes_read) {
+ DCHECK(request == request_);
+ DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
+
+ url_ = request->url();
+ url_throttler_entry_ =
+ net::URLRequestThrottlerManager::GetInstance()->RegisterRequestUrl(url_);
+
+ bool waiting_on_write = false;
+ do {
+ if (!request_->status().is_success() || bytes_read <= 0)
+ break;
+
+ current_response_bytes_ += bytes_read;
+ InformDelegateDownloadProgress();
+
+ if (!WriteBuffer(bytes_read)) {
+ // If WriteBuffer() returns false, we have a pending write to
+ // wait on before reading further.
+ waiting_on_write = true;
+ break;
+ }
+ } while (request_->Read(buffer_, kBufferSize, &bytes_read));
+
+ const net::URLRequestStatus status = request_->status();
+
+ if (status.is_success())
+ request_->GetResponseCookies(&cookies_);
+
+ // See comments re: HEAD requests in ReadResponse().
+ if ((!status.is_io_pending() && !waiting_on_write) ||
+ (request_type_ == URLFetcher::HEAD)) {
+ status_ = status;
+ ReleaseRequest();
+
+ // If a file is open, close it.
+ if (file_writer_.get()) {
+ // If the file is open, close it. After closing the file,
+ // RetryOrCompleteUrlFetch() will be called.
+ file_writer_->CloseFileAndCompleteRequest();
+ } else {
+ // Otherwise, complete or retry the URL request directly.
+ RetryOrCompleteUrlFetch();
+ }
+ }
+}
+
+void URLFetcherCore::RetryOrCompleteUrlFetch() {
+ DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
+ base::TimeDelta backoff_delay;
+
+ // Checks the response from server.
+ if (response_code_ >= 500 ||
+ status_.error() == net::ERR_TEMPORARILY_THROTTLED) {
+ // When encountering a server error, we will send the request again
+ // after backoff time.
+ ++num_retries_;
+
+ // Note that backoff_delay may be 0 because (a) the URLRequestThrottler
+ // code does not necessarily back off on the first error, and (b) it
+ // only backs off on some of the 5xx status codes.
+ base::TimeTicks backoff_release_time = GetBackoffReleaseTime();
+ backoff_delay = backoff_release_time - base::TimeTicks::Now();
+ if (backoff_delay < base::TimeDelta())
+ backoff_delay = base::TimeDelta();
+
+ if (automatically_retry_on_5xx_ && num_retries_ <= max_retries_) {
+ StartOnIOThread();
+ return;
+ }
+ } else {
+ backoff_delay = base::TimeDelta();
+ }
+ request_context_getter_ = NULL;
+ render_process_id_ = -1;
+ render_view_id_ = -1;
+ first_party_for_cookies_ = GURL();
+ bool posted = delegate_loop_proxy_->PostTask(
+ FROM_HERE,
+ base::Bind(&URLFetcherCore::OnCompletedURLRequest, this, backoff_delay));
+
+ // If the delegate message loop does not exist any more, then the delegate
+ // should be gone too.
+ DCHECK(posted || !delegate_);
+}
+
+void URLFetcherCore::ReadResponse() {
+ // Some servers may treat HEAD requests as GET requests. To free up the
+ // network connection as soon as possible, signal that the request has
+ // completed immediately, without trying to read any data back (all we care
+ // about is the response code and headers, which we already have).
+ int bytes_read = 0;
+ if (request_->status().is_success() && (request_type_ != URLFetcher::HEAD))
+ request_->Read(buffer_, kBufferSize, &bytes_read);
+ OnReadCompleted(request_.get(), bytes_read);
+}
+
+void URLFetcherCore::DisownFile() {
+ file_writer_->DisownFile();
+}
+
+void URLFetcherCore::StartURLRequest() {
+ DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
+
+ if (was_cancelled_) {
+ // Since StartURLRequest() is posted as a *delayed* task, it may
+ // run after the URLFetcher was already stopped.
+ return;
+ }
+
+ DCHECK(request_context_getter_);
+ DCHECK(!request_.get());
+
+ g_registry.Get().AddURLFetcherCore(this);
+ current_response_bytes_ = 0;
+ request_.reset(new net::URLRequest(original_url_, this));
+ int flags = request_->load_flags() | load_flags_;
+ if (!g_interception_enabled)
+ flags = flags | net::LOAD_DISABLE_INTERCEPT;
+
+ if (is_chunked_upload_)
+ request_->EnableChunkedUpload();
+ request_->set_load_flags(flags);
+ request_->set_context(request_context_getter_->GetURLRequestContext());
+ request_->set_referrer(referrer_);
+ request_->set_first_party_for_cookies(first_party_for_cookies_.is_empty() ?
+ original_url_ : first_party_for_cookies_);
+ if (render_process_id_ != -1 && render_view_id_ != -1) {
+ request_->SetUserData(
+ URLRequestUserData::kUserDataKey,
+ new URLRequestUserData(render_process_id_, render_view_id_));
+ }
+
+ switch (request_type_) {
+ case URLFetcher::GET:
+ break;
+
+ case URLFetcher::POST:
+ case URLFetcher::PUT:
+ DCHECK(!upload_content_.empty() || is_chunked_upload_);
+ DCHECK(!upload_content_type_.empty());
+
+ request_->set_method(request_type_ == URLFetcher::POST ? "POST" : "PUT");
+ extra_request_headers_.SetHeader(net::HttpRequestHeaders::kContentType,
+ upload_content_type_);
+ if (!upload_content_.empty()) {
+ request_->AppendBytesToUpload(
+ upload_content_.data(), static_cast<int>(upload_content_.length()));
+ }
+
+ current_upload_bytes_ = -1;
+ // TODO(kinaba): http://crbug.com/118103. Implement upload callback in the
+ // net:: layer and avoid using timer here.
+ upload_progress_checker_timer_.reset(
+ new base::RepeatingTimer<URLFetcherCore>());
+ upload_progress_checker_timer_->Start(
+ FROM_HERE,
+ base::TimeDelta::FromMilliseconds(kUploadProgressTimerInterval),
+ this,
+ &URLFetcherCore::InformDelegateUploadProgress);
+ break;
+
+ case URLFetcher::HEAD:
+ request_->set_method("HEAD");
+ break;
+
+ case URLFetcher::DELETE_REQUEST:
+ request_->set_method("DELETE");
+ break;
+
+ default:
+ NOTREACHED();
+ }
+
+ if (!extra_request_headers_.IsEmpty())
+ request_->SetExtraRequestHeaders(extra_request_headers_);
+
+ // There might be data left over from a previous request attempt.
+ data_.clear();
+
+ // If we are writing the response to a file, the only caller
+ // of this function should have created it and not written yet.
+ DCHECK(!file_writer_.get() || file_writer_->total_bytes_written() == 0);
+
+ request_->Start();
+}
+
+void URLFetcherCore::StartURLRequestWhenAppropriate() {
+ DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
+
+ if (was_cancelled_)
+ return;
+
+ if (original_url_throttler_entry_ == NULL) {
+ original_url_throttler_entry_ =
+ net::URLRequestThrottlerManager::GetInstance()->RegisterRequestUrl(
+ original_url_);
+ }
+
+ int64 delay = original_url_throttler_entry_->ReserveSendingTimeForNextRequest(
+ GetBackoffReleaseTime());
+ if (delay == 0) {
+ StartURLRequest();
+ } else {
+ MessageLoop::current()->PostDelayedTask(
+ FROM_HERE, base::Bind(&URLFetcherCore::StartURLRequest, this),
+ base::TimeDelta::FromMilliseconds(delay));
+ }
+}
+
+void URLFetcherCore::CancelURLRequest() {
+ DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
+
+ if (request_.get()) {
+ request_->Cancel();
+ ReleaseRequest();
+ }
+ // Release the reference to the request context. There could be multiple
+ // references to URLFetcher::Core at this point so it may take a while to
+ // delete the object, but we cannot delay the destruction of the request
+ // context.
+ request_context_getter_ = NULL;
+ render_process_id_ = -1;
+ render_view_id_ = -1;
+ first_party_for_cookies_ = GURL();
+ was_cancelled_ = true;
+ file_writer_.reset();
+}
+
+void URLFetcherCore::OnCompletedURLRequest(
+ base::TimeDelta backoff_delay) {
+ DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
+
+ // Save the status and backoff_delay so that delegates can read it.
+ if (delegate_) {
+ backoff_delay_ = backoff_delay;
+ InformDelegateFetchIsComplete();
+ }
+}
+
+void URLFetcherCore::InformDelegateUploadProgress() {
+ DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
+ if (request_.get()) {
+ int64 current = request_->GetUploadProgress();
+ if (current_upload_bytes_ != current) {
+ current_upload_bytes_ = current;
+ int64 total = -1;
+ if (!is_chunked_upload_)
+ total = static_cast<int64>(upload_content_.size());
+ delegate_loop_proxy_->PostTask(
+ FROM_HERE,
+ base::Bind(
+ &URLFetcherCore::InformDelegateUploadProgressInDelegateThread,
+ this, current, total));
+ }
+ }
+}
+
+void URLFetcherCore::InformDelegateUploadProgressInDelegateThread(
+ int64 current, int64 total) {
+ DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
+ if (delegate_)
+ delegate_->OnURLFetchUploadProgress(fetcher_, current, total);
+}
+
+void URLFetcherCore::InformDelegateDownloadProgress() {
+ DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
+ delegate_loop_proxy_->PostTask(
+ FROM_HERE,
+ base::Bind(
+ &URLFetcherCore::InformDelegateDownloadProgressInDelegateThread,
+ this, current_response_bytes_, total_response_bytes_));
+}
+
+void URLFetcherCore::InformDelegateDownloadProgressInDelegateThread(
+ int64 current, int64 total) {
+ DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
+ if (delegate_)
+ delegate_->OnURLFetchDownloadProgress(fetcher_, current, total);
+}
+
+void URLFetcherCore::InformDelegateFetchIsComplete() {
+ DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
+ if (delegate_)
+ delegate_->OnURLFetchComplete(fetcher_);
+}
+
+void URLFetcherCore::NotifyMalformedContent() {
+ DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
+ if (url_throttler_entry_ != NULL) {
+ int status_code = response_code_;
+ if (status_code == URLFetcher::RESPONSE_CODE_INVALID) {
+ // The status code will generally be known by the time clients
+ // call the |ReceivedContentWasMalformed()| function (which ends up
+ // calling the current function) but if it's not, we need to assume
+ // the response was successful so that the total failure count
+ // used to calculate exponential back-off goes up.
+ status_code = 200;
+ }
+ url_throttler_entry_->ReceivedContentWasMalformed(status_code);
+ }
+}
+
+void URLFetcherCore::ReleaseRequest() {
+ upload_progress_checker_timer_.reset();
+ request_.reset();
+ g_registry.Get().RemoveURLFetcherCore(this);
+}
+
+base::TimeTicks URLFetcherCore::GetBackoffReleaseTime() {
+ DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
+ DCHECK(original_url_throttler_entry_ != NULL);
+
+ base::TimeTicks original_url_backoff =
+ original_url_throttler_entry_->GetExponentialBackoffReleaseTime();
+ base::TimeTicks destination_url_backoff;
+ if (url_throttler_entry_ != NULL &&
+ original_url_throttler_entry_ != url_throttler_entry_) {
+ destination_url_backoff =
+ url_throttler_entry_->GetExponentialBackoffReleaseTime();
+ }
+
+ return original_url_backoff > destination_url_backoff ?
+ original_url_backoff : destination_url_backoff;
+}
+
+} // namespace content
diff --git a/content/common/net/url_fetcher_core.h b/content/common/net/url_fetcher_core.h
new file mode 100644
index 0000000..8fe0116
--- /dev/null
+++ b/content/common/net/url_fetcher_core.h
@@ -0,0 +1,387 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_COMMON_NET_URL_FETCHER_CORE_H_
+#define CONTENT_COMMON_NET_URL_FETCHER_CORE_H_
+#pragma once
+
+#include <set>
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "base/file_path.h"
+#include "base/lazy_instance.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
+#include "base/platform_file.h"
+#include "base/timer.h"
+#include "content/public/common/url_fetcher.h"
+#include "googleurl/src/gurl.h"
+#include "net/base/host_port_pair.h"
+#include "net/http/http_request_headers.h"
+#include "net/url_request/url_request.h"
+#include "net/url_request/url_request_status.h"
+
+namespace base {
+class MessageLoopProxy;
+} // namespace base
+
+namespace net {
+class HttpResponseHeaders;
+class IOBuffer;
+class URLRequestContextGetter;
+class URLRequestThrottlerEntryInterface;
+} // namespace net
+
+namespace content {
+
+class URLFetcherDelegate;
+
+class URLFetcherCore
+ : public base::RefCountedThreadSafe<URLFetcherCore>,
+ public net::URLRequest::Delegate {
+ public:
+ URLFetcherCore(URLFetcher* fetcher,
+ const GURL& original_url,
+ URLFetcher::RequestType request_type,
+ URLFetcherDelegate* d);
+
+ // Starts the load. It's important that this not happen in the constructor
+ // because it causes the IO thread to begin AddRef()ing and Release()ing
+ // us. If our caller hasn't had time to fully construct us and take a
+ // reference, the IO thread could interrupt things, run a task, Release()
+ // us, and destroy us, leaving the caller with an already-destroyed object
+ // when construction finishes.
+ void Start();
+
+ // Stops any in-progress load and ensures no callback will happen. It is
+ // safe to call this multiple times.
+ void Stop();
+
+ // URLFetcher-like functions.
+
+ // For POST requests, set |content_type| to the MIME type of the
+ // content and set |content| to the data to upload.
+ void SetUploadData(const std::string& upload_content_type,
+ const std::string& upload_content);
+ void SetChunkedUpload(const std::string& upload_content_type);
+ // Adds a block of data to be uploaded in a POST body. This can only be
+ // called after Start().
+ void AppendChunkToUpload(const std::string& data, bool is_last_chunk);
+ // |flags| are flags to apply to the load operation--these should be
+ // one or more of the LOAD_* flags defined in net/base/load_flags.h.
+ void SetLoadFlags(int load_flags);
+ int GetLoadFlags() const;
+ void SetReferrer(const std::string& referrer);
+ void SetExtraRequestHeaders(const std::string& extra_request_headers);
+ void AddExtraRequestHeader(const std::string& header_line);
+ void GetExtraRequestHeaders(net::HttpRequestHeaders* headers) const;
+ void SetRequestContext(net::URLRequestContextGetter* request_context_getter);
+ // TODO(akalin): When we move this class to net/, this has to stay
+ // in content/ somehow.
+ void AssociateWithRenderView(const GURL& first_party_for_cookies,
+ int render_process_id,
+ int render_view_id);
+ void SetAutomaticallyRetryOn5xx(bool retry);
+ void SetMaxRetries(int max_retries);
+ int GetMaxRetries() const;
+ base::TimeDelta GetBackoffDelay() const;
+ void SaveResponseToFileAtPath(
+ const FilePath& file_path,
+ scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy);
+ void SaveResponseToTemporaryFile(
+ scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy);
+ net::HttpResponseHeaders* GetResponseHeaders() const;
+ net::HostPortPair GetSocketAddress() const;
+ bool WasFetchedViaProxy() const;
+ const GURL& GetOriginalURL() const;
+ const GURL& GetURL() const;
+ const net::URLRequestStatus& GetStatus() const;
+ int GetResponseCode() const;
+ const net::ResponseCookies& GetCookies() const;
+ bool FileErrorOccurred(base::PlatformFileError* out_error_code) const;
+ // Reports that the received content was malformed (i.e. failed parsing
+ // or validation). This makes the throttling logic that does exponential
+ // back-off when servers are having problems treat the current request as
+ // a failure. Your call to this method will be ignored if your request is
+ // already considered a failure based on the HTTP response code or response
+ // headers.
+ void ReceivedContentWasMalformed();
+ bool GetResponseAsString(std::string* out_response_string) const;
+ bool GetResponseAsFilePath(bool take_ownership,
+ FilePath* out_response_path);
+
+ // Overridden from net::URLRequest::Delegate:
+ virtual void OnResponseStarted(
+ net::URLRequest* request) OVERRIDE;
+ virtual void OnReadCompleted(
+ net::URLRequest* request, int bytes_read) OVERRIDE;
+
+ URLFetcherDelegate* delegate() const { return delegate_; }
+ static void CancelAll();
+ static int GetNumFetcherCores();
+ static void SetEnableInterceptionForTests(bool enabled);
+
+ private:
+ friend class base::RefCountedThreadSafe<URLFetcherCore>;
+
+ // How should the response be stored?
+ enum ResponseDestinationType {
+ STRING, // Default: In a std::string
+ PERMANENT_FILE, // Write to a permanent file.
+ TEMP_FILE, // Write to a temporary file.
+ };
+
+ class Registry {
+ public:
+ Registry();
+ ~Registry();
+
+ void AddURLFetcherCore(URLFetcherCore* core);
+ void RemoveURLFetcherCore(URLFetcherCore* core);
+
+ void CancelAll();
+
+ int size() const {
+ return fetchers_.size();
+ }
+
+ private:
+ std::set<URLFetcherCore*> fetchers_;
+
+ DISALLOW_COPY_AND_ASSIGN(Registry);
+ };
+
+ // Class FileWriter encapsulates all state involved in writing
+ // response bytes to a file. It is only used if
+ // |URLFetcherCore::response_destination_| == TEMP_FILE ||
+ // |URLFetcherCore::response_destination_| == PERMANENT_FILE. Each
+ // instance of FileWriter is owned by a URLFetcherCore, which
+ // manages its lifetime and never transfers ownership. While
+ // writing to a file, all function calls happen on the IO thread.
+ class FileWriter {
+ public:
+ FileWriter(URLFetcherCore* core,
+ scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy);
+
+ ~FileWriter();
+ void CreateFileAtPath(const FilePath& file_path);
+ void CreateTempFile();
+
+ // Record |num_bytes_| response bytes in |core_->buffer_| to the file.
+ void WriteBuffer(int num_bytes);
+
+ // Called when a write has been done. Continues writing if there are
+ // any more bytes to write. Otherwise, initiates a read in core_.
+ void ContinueWrite(base::PlatformFileError error_code, int bytes_written);
+
+ // Drop ownership of the file at |file_path_|.
+ // This class will not delete it or write to it again.
+ void DisownFile();
+
+ // Close the file if it is open.
+ void CloseFileAndCompleteRequest();
+
+ // Remove the file if we have created one.
+ void RemoveFile();
+
+ const FilePath& file_path() const { return file_path_; }
+ int64 total_bytes_written() { return total_bytes_written_; }
+ base::PlatformFileError error_code() const { return error_code_; }
+
+ private:
+ // Callback which gets the result of a permanent file creation.
+ void DidCreateFile(const FilePath& file_path,
+ base::PlatformFileError error_code,
+ base::PassPlatformFile file_handle,
+ bool created);
+ // Callback which gets the result of a temporary file creation.
+ void DidCreateTempFile(base::PlatformFileError error_code,
+ base::PassPlatformFile file_handle,
+ const FilePath& file_path);
+ // This method is used to implement DidCreateFile and DidCreateTempFile.
+ void DidCreateFileInternal(const FilePath& file_path,
+ base::PlatformFileError error_code,
+ base::PassPlatformFile file_handle);
+
+ // Callback which gets the result of closing the file.
+ void DidCloseFile(base::PlatformFileError error);
+
+ // The URLFetcherCore which instantiated this class.
+ URLFetcherCore* core_;
+
+ // The last error encountered on a file operation. base::PLATFORM_FILE_OK
+ // if no error occurred.
+ base::PlatformFileError error_code_;
+
+ // Callbacks are created for use with base::FileUtilProxy.
+ base::WeakPtrFactory<URLFetcherCore::FileWriter> weak_factory_;
+
+ // Message loop on which file operations should happen.
+ scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy_;
+
+ // Path to the file. This path is empty when there is no file.
+ FilePath file_path_;
+
+ // Handle to the file.
+ base::PlatformFile file_handle_;
+
+ // We always append to the file. Track the total number of bytes
+ // written, so that writes know the offset to give.
+ int64 total_bytes_written_;
+
+ // How many bytes did the last Write() try to write? Needed so
+ // that if not all the bytes get written on a Write(), we can
+ // call Write() again with the rest.
+ int pending_bytes_;
+
+ // When writing, how many bytes from the buffer have been successfully
+ // written so far?
+ int buffer_offset_;
+ };
+
+ virtual ~URLFetcherCore();
+
+ // Wrapper functions that allow us to ensure actions happen on the right
+ // thread.
+ void StartOnIOThread();
+ void StartURLRequest();
+ void StartURLRequestWhenAppropriate();
+ void CancelURLRequest();
+ void OnCompletedURLRequest(base::TimeDelta backoff_delay);
+ void InformDelegateFetchIsComplete();
+ void NotifyMalformedContent();
+ void RetryOrCompleteUrlFetch();
+
+ // Deletes the request, removes it from the registry, and removes the
+ // destruction observer.
+ void ReleaseRequest();
+
+ // Returns the max value of exponential back-off release time for
+ // |original_url_| and |url_|.
+ base::TimeTicks GetBackoffReleaseTime();
+
+ void CompleteAddingUploadDataChunk(const std::string& data,
+ bool is_last_chunk);
+
+ // Store the response bytes in |buffer_| in the container indicated by
+ // |response_destination_|. Return true if the write has been
+ // done, and another read can overwrite |buffer_|. If this function
+ // returns false, it will post a task that will read more bytes once the
+ // write is complete.
+ bool WriteBuffer(int num_bytes);
+
+ // Read response bytes from the request.
+ void ReadResponse();
+
+ // Drop ownership of any file managed by |file_path_|.
+ void DisownFile();
+
+ // Notify Delegate about the progress of upload/download.
+ void InformDelegateUploadProgress();
+ void InformDelegateUploadProgressInDelegateThread(int64 current, int64 total);
+ void InformDelegateDownloadProgress();
+ void InformDelegateDownloadProgressInDelegateThread(int64 current,
+ int64 total);
+
+ URLFetcher* fetcher_; // Corresponding fetcher object
+ GURL original_url_; // The URL we were asked to fetch
+ GURL url_; // The URL we eventually wound up at
+ URLFetcher::RequestType request_type_; // What type of request is this?
+ net::URLRequestStatus status_; // Status of the request
+ URLFetcherDelegate* delegate_; // Object to notify on completion
+ scoped_refptr<base::MessageLoopProxy> delegate_loop_proxy_;
+ // Message loop proxy of the creating
+ // thread.
+ scoped_refptr<base::MessageLoopProxy> io_message_loop_proxy_;
+ // The message loop proxy for the thread
+ // on which the request IO happens.
+ scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy_;
+ // The message loop proxy for the thread
+ // on which file access happens.
+ scoped_ptr<net::URLRequest> request_; // The actual request this wraps
+ int load_flags_; // Flags for the load operation
+ int response_code_; // HTTP status code for the request
+ std::string data_; // Results of the request, when we are
+ // storing the response as a string.
+ scoped_refptr<net::IOBuffer> buffer_;
+ // Read buffer
+ scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
+ // Cookie/cache info for the request
+ int render_process_id_; // The RenderView associated with the
+ int render_view_id_; // request
+ GURL first_party_for_cookies_; // The first party URL for the request
+ net::ResponseCookies cookies_; // Response cookies
+ net::HttpRequestHeaders extra_request_headers_;
+ scoped_refptr<net::HttpResponseHeaders> response_headers_;
+ bool was_fetched_via_proxy_;
+ net::HostPortPair socket_address_;
+
+ std::string upload_content_; // HTTP POST payload
+ std::string upload_content_type_; // MIME type of POST payload
+ std::string referrer_; // HTTP Referer header value
+ bool is_chunked_upload_; // True if using chunked transfer encoding
+
+ // Used to determine how long to wait before making a request or doing a
+ // retry.
+ // Both of them can only be accessed on the IO thread.
+ // We need not only the throttler entry for |original_URL|, but also the one
+ // for |url|. For example, consider the case that URL A redirects to URL B,
+ // for which the server returns a 500 response. In this case, the exponential
+ // back-off release time of URL A won't increase. If we retry without
+ // considering the back-off constraint of URL B, we may send out too many
+ // requests for URL A in a short period of time.
+ scoped_refptr<net::URLRequestThrottlerEntryInterface>
+ original_url_throttler_entry_;
+ scoped_refptr<net::URLRequestThrottlerEntryInterface> url_throttler_entry_;
+
+ // |num_retries_| indicates how many times we've failed to successfully
+ // fetch this URL. Once this value exceeds the maximum number of retries
+ // specified by the owner URLFetcher instance, we'll give up.
+ int num_retries_;
+
+ // True if the URLFetcher has been cancelled.
+ bool was_cancelled_;
+
+ // If writing results to a file, |file_writer_| will manage creation,
+ // writing, and destruction of that file.
+ scoped_ptr<FileWriter> file_writer_;
+
+ // Where should responses be saved?
+ ResponseDestinationType response_destination_;
+
+ // Path to the file where the response is written.
+ FilePath response_destination_file_path_;
+
+ // If |automatically_retry_on_5xx_| is false, 5xx responses will be
+ // propagated to the observer, if it is true URLFetcher will automatically
+ // re-execute the request, after the back-off delay has expired.
+ // true by default.
+ bool automatically_retry_on_5xx_;
+ // Maximum retries allowed.
+ int max_retries_;
+ // Back-off time delay. 0 by default.
+ base::TimeDelta backoff_delay_;
+
+ // Timer to poll the progress of uploading for POST and PUT requests.
+ // When crbug.com/119629 is fixed, scoped_ptr is not necessary here.
+ scoped_ptr<base::RepeatingTimer<URLFetcherCore> >
+ upload_progress_checker_timer_;
+ // Number of bytes sent so far.
+ int64 current_upload_bytes_;
+ // Number of bytes received so far.
+ int64 current_response_bytes_;
+ // Total expected bytes to receive (-1 if it cannot be determined).
+ int64 total_response_bytes_;
+
+ static base::LazyInstance<Registry> g_registry;
+
+ DISALLOW_COPY_AND_ASSIGN(URLFetcherCore);
+};
+
+} // namespace content
+
+#endif // CONTENT_COMMON_NET_URL_FETCHER_CORE_H_
diff --git a/content/common/net/url_fetcher_impl.cc b/content/common/net/url_fetcher_impl.cc
index 0e87c51..a441435d 100644
--- a/content/common/net/url_fetcher_impl.cc
+++ b/content/common/net/url_fetcher_impl.cc
@@ -4,546 +4,11 @@
#include "content/common/net/url_fetcher_impl.h"
-#include <set>
-
-#include "base/bind.h"
-#include "base/compiler_specific.h"
-#include "base/file_path.h"
-#include "base/file_util_proxy.h"
-#include "base/lazy_instance.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/memory/weak_ptr.h"
#include "base/message_loop_proxy.h"
-#include "base/metrics/histogram.h"
-#include "base/platform_file.h"
-#include "base/stl_util.h"
-#include "base/string_util.h"
-#include "base/threading/thread.h"
-#include "base/timer.h"
-#include "content/common/net/url_request_user_data.h"
-#include "content/public/common/url_fetcher_delegate.h"
+#include "content/common/net/url_fetcher_core.h"
#include "content/public/common/url_fetcher_factory.h"
-#include "googleurl/src/gurl.h"
-#include "net/base/host_port_pair.h"
-#include "net/base/io_buffer.h"
-#include "net/base/load_flags.h"
-#include "net/base/net_errors.h"
-#include "net/http/http_request_headers.h"
-#include "net/http/http_response_headers.h"
-#include "net/url_request/url_request.h"
-#include "net/url_request/url_request_context.h"
-#include "net/url_request/url_request_context_getter.h"
-#include "net/url_request/url_request_throttler_manager.h"
-
-static const int kBufferSize = 4096;
-static const int kUploadProgressTimerInterval = 100;
-
-class URLFetcherImpl::Core
- : public base::RefCountedThreadSafe<URLFetcherImpl::Core>,
- public net::URLRequest::Delegate {
- public:
- // For POST requests, set |content_type| to the MIME type of the content
- // and set |content| to the data to upload. |flags| are flags to apply to
- // the load operation--these should be one or more of the LOAD_* flags
- // defined in net/base/load_flags.h.
- Core(URLFetcherImpl* fetcher,
- const GURL& original_url,
- RequestType request_type,
- content::URLFetcherDelegate* d);
-
- // Starts the load. It's important that this not happen in the constructor
- // because it causes the IO thread to begin AddRef()ing and Release()ing
- // us. If our caller hasn't had time to fully construct us and take a
- // reference, the IO thread could interrupt things, run a task, Release()
- // us, and destroy us, leaving the caller with an already-destroyed object
- // when construction finishes.
- void Start();
-
- // Stops any in-progress load and ensures no callback will happen. It is
- // safe to call this multiple times.
- void Stop();
-
- // Reports that the received content was malformed (i.e. failed parsing
- // or validation). This makes the throttling logic that does exponential
- // back-off when servers are having problems treat the current request as
- // a failure. Your call to this method will be ignored if your request is
- // already considered a failure based on the HTTP response code or response
- // headers.
- void ReceivedContentWasMalformed();
-
- // Overridden from net::URLRequest::Delegate:
- virtual void OnResponseStarted(net::URLRequest* request);
- virtual void OnReadCompleted(net::URLRequest* request, int bytes_read);
-
- content::URLFetcherDelegate* delegate() const { return delegate_; }
- static void CancelAll();
-
- private:
- friend class base::RefCountedThreadSafe<URLFetcherImpl::Core>;
-
- class Registry {
- public:
- Registry();
- ~Registry();
-
- void AddURLFetcherCore(Core* core);
- void RemoveURLFetcherCore(Core* core);
-
- void CancelAll();
-
- int size() const {
- return fetchers_.size();
- }
-
- private:
- std::set<Core*> fetchers_;
-
- DISALLOW_COPY_AND_ASSIGN(Registry);
- };
-
- // Class FileWriter encapsulates all state involved in writing response bytes
- // to a file. It is only used if |Core::response_destination_| == TEMP_FILE ||
- // |Core::response_destination_| == PERMANENT_FILE.
- // Each instance of FileWriter is owned by a URLFetcher::Core, which manages
- // its lifetime and never transfers ownership. While writing to
- // a file, all function calls happen on the IO thread.
- class FileWriter {
- public:
- FileWriter(URLFetcherImpl::Core* core,
- scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy);
-
- ~FileWriter();
- void CreateFileAtPath(const FilePath& file_path);
- void CreateTempFile();
-
- // Record |num_bytes_| response bytes in |core_->buffer_| to the file.
- void WriteBuffer(int num_bytes);
-
- // Called when a write has been done. Continues writing if there are
- // any more bytes to write. Otherwise, initiates a read in core_.
- void ContinueWrite(base::PlatformFileError error_code, int bytes_written);
-
- // Drop ownership of the file at |file_path_|.
- // This class will not delete it or write to it again.
- void DisownFile();
-
- // Close the file if it is open.
- void CloseFileAndCompleteRequest();
-
- // Remove the file if we have created one.
- void RemoveFile();
-
- const FilePath& file_path() const { return file_path_; }
- int64 total_bytes_written() { return total_bytes_written_; }
- base::PlatformFileError error_code() const { return error_code_; }
-
- private:
- // Callback which gets the result of a permanent file creation.
- void DidCreateFile(const FilePath& file_path,
- base::PlatformFileError error_code,
- base::PassPlatformFile file_handle,
- bool created);
- // Callback which gets the result of a temporary file creation.
- void DidCreateTempFile(base::PlatformFileError error_code,
- base::PassPlatformFile file_handle,
- const FilePath& file_path);
- // This method is used to implement DidCreateFile and DidCreateTempFile.
- void DidCreateFileInternal(const FilePath& file_path,
- base::PlatformFileError error_code,
- base::PassPlatformFile file_handle);
-
- // Callback which gets the result of closing the file.
- void DidCloseFile(base::PlatformFileError error);
-
- // The URLFetcherImpl::Core which instantiated this class.
- URLFetcherImpl::Core* core_;
-
- // The last error encountered on a file operation. base::PLATFORM_FILE_OK
- // if no error occurred.
- base::PlatformFileError error_code_;
-
- // Callbacks are created for use with base::FileUtilProxy.
- base::WeakPtrFactory<URLFetcherImpl::Core::FileWriter> weak_factory_;
-
- // Message loop on which file operations should happen.
- scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy_;
-
- // Path to the file. This path is empty when there is no file.
- FilePath file_path_;
-
- // Handle to the file.
- base::PlatformFile file_handle_;
-
- // We always append to the file. Track the total number of bytes
- // written, so that writes know the offset to give.
- int64 total_bytes_written_;
-
- // How many bytes did the last Write() try to write? Needed so
- // that if not all the bytes get written on a Write(), we can
- // call Write() again with the rest.
- int pending_bytes_;
-
- // When writing, how many bytes from the buffer have been successfully
- // written so far?
- int buffer_offset_;
- };
-
- virtual ~Core();
-
- // Wrapper functions that allow us to ensure actions happen on the right
- // thread.
- void StartOnIOThread();
- void StartURLRequest();
- void StartURLRequestWhenAppropriate();
- void CancelURLRequest();
- void OnCompletedURLRequest(base::TimeDelta backoff_delay);
- void InformDelegateFetchIsComplete();
- void NotifyMalformedContent();
- void RetryOrCompleteUrlFetch();
-
- // Deletes the request, removes it from the registry, and removes the
- // destruction observer.
- void ReleaseRequest();
-
- // Returns the max value of exponential back-off release time for
- // |original_url_| and |url_|.
- base::TimeTicks GetBackoffReleaseTime();
-
- void CompleteAddingUploadDataChunk(const std::string& data,
- bool is_last_chunk);
-
- // Adds a block of data to be uploaded in a POST body. This can only be
- // called after Start().
- void AppendChunkToUpload(const std::string& data, bool is_last_chunk);
-
- // Store the response bytes in |buffer_| in the container indicated by
- // |response_destination_|. Return true if the write has been
- // done, and another read can overwrite |buffer_|. If this function
- // returns false, it will post a task that will read more bytes once the
- // write is complete.
- bool WriteBuffer(int num_bytes);
-
- // Read response bytes from the request.
- void ReadResponse();
-
- // Drop ownership of any file managed by |file_path_|.
- void DisownFile();
-
- // Notify Delegate about the progress of upload/download.
- void InformDelegateUploadProgress();
- void InformDelegateUploadProgressInDelegateThread(int64 current, int64 total);
- void InformDelegateDownloadProgress();
- void InformDelegateDownloadProgressInDelegateThread(int64 current,
- int64 total);
-
- URLFetcherImpl* fetcher_; // Corresponding fetcher object
- GURL original_url_; // The URL we were asked to fetch
- GURL url_; // The URL we eventually wound up at
- RequestType request_type_; // What type of request is this?
- net::URLRequestStatus status_; // Status of the request
- content::URLFetcherDelegate* delegate_; // Object to notify on completion
- scoped_refptr<base::MessageLoopProxy> delegate_loop_proxy_;
- // Message loop proxy of the creating
- // thread.
- scoped_refptr<base::MessageLoopProxy> io_message_loop_proxy_;
- // The message loop proxy for the thread
- // on which the request IO happens.
- scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy_;
- // The message loop proxy for the thread
- // on which file access happens.
- scoped_ptr<net::URLRequest> request_; // The actual request this wraps
- int load_flags_; // Flags for the load operation
- int response_code_; // HTTP status code for the request
- std::string data_; // Results of the request, when we are
- // storing the response as a string.
- scoped_refptr<net::IOBuffer> buffer_;
- // Read buffer
- scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
- // Cookie/cache info for the request
- int render_process_id_; // The RenderView associated with the
- int render_view_id_; // request
- GURL first_party_for_cookies_; // The first party URL for the request
- net::ResponseCookies cookies_; // Response cookies
- net::HttpRequestHeaders extra_request_headers_;
- scoped_refptr<net::HttpResponseHeaders> response_headers_;
- bool was_fetched_via_proxy_;
- net::HostPortPair socket_address_;
-
- std::string upload_content_; // HTTP POST payload
- std::string upload_content_type_; // MIME type of POST payload
- std::string referrer_; // HTTP Referer header value
- bool is_chunked_upload_; // True if using chunked transfer encoding
-
- // Used to determine how long to wait before making a request or doing a
- // retry.
- // Both of them can only be accessed on the IO thread.
- // We need not only the throttler entry for |original_URL|, but also the one
- // for |url|. For example, consider the case that URL A redirects to URL B,
- // for which the server returns a 500 response. In this case, the exponential
- // back-off release time of URL A won't increase. If we retry without
- // considering the back-off constraint of URL B, we may send out too many
- // requests for URL A in a short period of time.
- scoped_refptr<net::URLRequestThrottlerEntryInterface>
- original_url_throttler_entry_;
- scoped_refptr<net::URLRequestThrottlerEntryInterface> url_throttler_entry_;
-
- // |num_retries_| indicates how many times we've failed to successfully
- // fetch this URL. Once this value exceeds the maximum number of retries
- // specified by the owner URLFetcher instance, we'll give up.
- int num_retries_;
-
- // True if the URLFetcher has been cancelled.
- bool was_cancelled_;
-
- // If writing results to a file, |file_writer_| will manage creation,
- // writing, and destruction of that file.
- scoped_ptr<FileWriter> file_writer_;
-
- // Where should responses be saved?
- ResponseDestinationType response_destination_;
-
- // Path to the file where the response is written.
- FilePath response_destination_file_path_;
-
- // If |automatically_retry_on_5xx_| is false, 5xx responses will be
- // propagated to the observer, if it is true URLFetcher will automatically
- // re-execute the request, after the back-off delay has expired.
- // true by default.
- bool automatically_retry_on_5xx_;
- // Maximum retries allowed.
- int max_retries_;
- // Back-off time delay. 0 by default.
- base::TimeDelta backoff_delay_;
-
- // Timer to poll the progress of uploading for POST and PUT requests.
- // When crbug.com/119629 is fixed, scoped_ptr is not necessary here.
- scoped_ptr<base::RepeatingTimer<Core> > upload_progress_checker_timer_;
- // Number of bytes sent so far.
- int64 current_upload_bytes_;
- // Number of bytes received so far.
- int64 current_response_bytes_;
- // Total expected bytes to receive (-1 if it cannot be determined).
- int64 total_response_bytes_;
-
- static base::LazyInstance<Registry> g_registry;
-
- friend class URLFetcherImpl;
- DISALLOW_COPY_AND_ASSIGN(Core);
-};
-
-URLFetcherImpl::Core::Registry::Registry() {}
-URLFetcherImpl::Core::Registry::~Registry() {}
-
-void URLFetcherImpl::Core::Registry::AddURLFetcherCore(Core* core) {
- DCHECK(!ContainsKey(fetchers_, core));
- fetchers_.insert(core);
-}
-
-void URLFetcherImpl::Core::Registry::RemoveURLFetcherCore(Core* core) {
- DCHECK(ContainsKey(fetchers_, core));
- fetchers_.erase(core);
-}
-
-void URLFetcherImpl::Core::Registry::CancelAll() {
- while (!fetchers_.empty())
- (*fetchers_.begin())->CancelURLRequest();
-}
-
-// static
-base::LazyInstance<URLFetcherImpl::Core::Registry>
- URLFetcherImpl::Core::g_registry = LAZY_INSTANCE_INITIALIZER;
-
-URLFetcherImpl::Core::FileWriter::FileWriter(
- URLFetcherImpl::Core* core,
- scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy)
- : core_(core),
- error_code_(base::PLATFORM_FILE_OK),
- ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)),
- file_message_loop_proxy_(file_message_loop_proxy),
- file_handle_(base::kInvalidPlatformFileValue) {
-}
-
-URLFetcherImpl::Core::FileWriter::~FileWriter() {
- RemoveFile();
-}
-
-void URLFetcherImpl::Core::FileWriter::CreateFileAtPath(
- const FilePath& file_path) {
- DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
- DCHECK(file_message_loop_proxy_.get());
- base::FileUtilProxy::CreateOrOpen(
- file_message_loop_proxy_,
- file_path,
- base::PLATFORM_FILE_CREATE_ALWAYS | base::PLATFORM_FILE_WRITE,
- base::Bind(&URLFetcherImpl::Core::FileWriter::DidCreateFile,
- weak_factory_.GetWeakPtr(),
- file_path));
-}
-
-void URLFetcherImpl::Core::FileWriter::CreateTempFile() {
- DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
- DCHECK(file_message_loop_proxy_.get());
- base::FileUtilProxy::CreateTemporary(
- file_message_loop_proxy_,
- 0, // No additional file flags.
- base::Bind(&URLFetcherImpl::Core::FileWriter::DidCreateTempFile,
- weak_factory_.GetWeakPtr()));
-}
-
-void URLFetcherImpl::Core::FileWriter::WriteBuffer(int num_bytes) {
- DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
-
- // Start writing to the file by setting the initial state
- // of |pending_bytes_| and |buffer_offset_| to indicate that the
- // entire buffer has not yet been written.
- pending_bytes_ = num_bytes;
- buffer_offset_ = 0;
- ContinueWrite(base::PLATFORM_FILE_OK, 0);
-}
-
-void URLFetcherImpl::Core::FileWriter::ContinueWrite(
- base::PlatformFileError error_code,
- int bytes_written) {
- DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
-
- if (file_handle_ == base::kInvalidPlatformFileValue) {
- // While a write was being done on the file thread, a request
- // to close or disown the file occured on the IO thread. At
- // this point a request to close the file is pending on the
- // file thread.
- return;
- }
-
- // Every code path that resets |core_->request_| should reset
- // |core->file_writer_| or cause the file writer to disown the file. In the
- // former case, this callback can not be called, because the weak pointer to
- // |this| will be NULL. In the latter case, the check of |file_handle_| at the
- // start of this method ensures that we can not reach this point.
- CHECK(core_->request_.get());
-
- if (base::PLATFORM_FILE_OK != error_code) {
- error_code_ = error_code;
- RemoveFile();
- core_->delegate_loop_proxy_->PostTask(
- FROM_HERE, base::Bind(&Core::InformDelegateFetchIsComplete, core_));
- return;
- }
-
- total_bytes_written_ += bytes_written;
- buffer_offset_ += bytes_written;
- pending_bytes_ -= bytes_written;
-
- if (pending_bytes_ > 0) {
- base::FileUtilProxy::Write(
- file_message_loop_proxy_, file_handle_,
- total_bytes_written_, // Append to the end
- (core_->buffer_->data() + buffer_offset_), pending_bytes_,
- base::Bind(&URLFetcherImpl::Core::FileWriter::ContinueWrite,
- weak_factory_.GetWeakPtr()));
- } else {
- // Finished writing core_->buffer_ to the file. Read some more.
- core_->ReadResponse();
- }
-}
-
-void URLFetcherImpl::Core::FileWriter::DisownFile() {
- DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
-
- // Disowning is done by the delegate's OnURLFetchComplete method.
- // The file should be closed by the time that method is called.
- DCHECK(file_handle_ == base::kInvalidPlatformFileValue);
-
- // Forget about any file by reseting the path.
- file_path_.clear();
-}
-
-void URLFetcherImpl::Core::FileWriter::CloseFileAndCompleteRequest() {
- DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
-
- if (file_handle_ != base::kInvalidPlatformFileValue) {
- base::FileUtilProxy::Close(
- file_message_loop_proxy_, file_handle_,
- base::Bind(&URLFetcherImpl::Core::FileWriter::DidCloseFile,
- weak_factory_.GetWeakPtr()));
- file_handle_ = base::kInvalidPlatformFileValue;
- }
-}
-
-void URLFetcherImpl::Core::FileWriter::DidCreateFile(
- const FilePath& file_path,
- base::PlatformFileError error_code,
- base::PassPlatformFile file_handle,
- bool created) {
- DidCreateFileInternal(file_path, error_code, file_handle);
-}
-
-void URLFetcherImpl::Core::FileWriter::DidCreateTempFile(
- base::PlatformFileError error_code,
- base::PassPlatformFile file_handle,
- const FilePath& file_path) {
- DidCreateFileInternal(file_path, error_code, file_handle);
-}
-
-void URLFetcherImpl::Core::FileWriter::DidCreateFileInternal(
- const FilePath& file_path,
- base::PlatformFileError error_code,
- base::PassPlatformFile file_handle) {
- DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
-
- if (base::PLATFORM_FILE_OK != error_code) {
- error_code_ = error_code;
- RemoveFile();
- core_->delegate_loop_proxy_->PostTask(
- FROM_HERE, base::Bind(&Core::InformDelegateFetchIsComplete, core_));
- return;
- }
-
- file_path_ = file_path;
- file_handle_ = file_handle.ReleaseValue();
- total_bytes_written_ = 0;
-
- core_->io_message_loop_proxy_->PostTask(
- FROM_HERE, base::Bind(&Core::StartURLRequestWhenAppropriate, core_));
-}
-
-void URLFetcherImpl::Core::FileWriter::DidCloseFile(
- base::PlatformFileError error_code) {
- DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
-
- if (base::PLATFORM_FILE_OK != error_code) {
- error_code_ = error_code;
- RemoveFile();
- core_->delegate_loop_proxy_->PostTask(
- FROM_HERE, base::Bind(&Core::InformDelegateFetchIsComplete, core_));
- return;
- }
-
- // If the file was successfully closed, then the URL request is complete.
- core_->RetryOrCompleteUrlFetch();
-}
-
-void URLFetcherImpl::Core::FileWriter::RemoveFile() {
- DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
-
- // Close the file if it is open.
- if (file_handle_ != base::kInvalidPlatformFileValue) {
- base::FileUtilProxy::Close(
- file_message_loop_proxy_, file_handle_,
- base::FileUtilProxy::StatusCallback()); // No callback: Ignore errors.
- file_handle_ = base::kInvalidPlatformFileValue;
- }
-
- if (!file_path_.empty()) {
- base::FileUtilProxy::Delete(
- file_message_loop_proxy_, file_path_,
- false, // No need to recurse, as the path is to a file.
- base::FileUtilProxy::StatusCallback()); // No callback: Ignore errors.
- DisownFile();
- }
-}
static content::URLFetcherFactory* g_factory = NULL;
-static bool g_interception_enabled = false;
// static
content::URLFetcher* content::URLFetcher::Create(
@@ -570,7 +35,7 @@ void content::URLFetcher::CancelAll() {
// static
void content::URLFetcher::SetEnableInterceptionForTests(bool enabled) {
- g_interception_enabled = enabled;
+ URLFetcherCore::SetEnableInterceptionForTests(enabled);
}
@@ -578,516 +43,20 @@ URLFetcherImpl::URLFetcherImpl(const GURL& url,
RequestType request_type,
content::URLFetcherDelegate* d)
: ALLOW_THIS_IN_INITIALIZER_LIST(
- core_(new Core(this, url, request_type, d))) {
+ core_(new content::URLFetcherCore(this, url, request_type, d))) {
}
URLFetcherImpl::~URLFetcherImpl() {
core_->Stop();
}
-URLFetcherImpl::Core::Core(URLFetcherImpl* fetcher,
- const GURL& original_url,
- RequestType request_type,
- content::URLFetcherDelegate* d)
- : fetcher_(fetcher),
- original_url_(original_url),
- request_type_(request_type),
- delegate_(d),
- delegate_loop_proxy_(
- base::MessageLoopProxy::current()),
- request_(NULL),
- load_flags_(net::LOAD_NORMAL),
- response_code_(RESPONSE_CODE_INVALID),
- buffer_(new net::IOBuffer(kBufferSize)),
- render_process_id_(-1),
- render_view_id_(-1),
- was_fetched_via_proxy_(false),
- is_chunked_upload_(false),
- num_retries_(0),
- was_cancelled_(false),
- response_destination_(STRING),
- automatically_retry_on_5xx_(true),
- max_retries_(0),
- current_upload_bytes_(-1),
- current_response_bytes_(0),
- total_response_bytes_(-1) {
-}
-
-URLFetcherImpl::Core::~Core() {
- // |request_| should be NULL. If not, it's unsafe to delete it here since we
- // may not be on the IO thread.
- DCHECK(!request_.get());
-}
-
-void URLFetcherImpl::Core::Start() {
- DCHECK(delegate_loop_proxy_);
- DCHECK(request_context_getter_) << "We need an URLRequestContext!";
- if (io_message_loop_proxy_) {
- DCHECK_EQ(io_message_loop_proxy_,
- request_context_getter_->GetIOMessageLoopProxy());
- } else {
- io_message_loop_proxy_ = request_context_getter_->GetIOMessageLoopProxy();
- }
- DCHECK(io_message_loop_proxy_.get()) << "We need an IO message loop proxy";
-
- io_message_loop_proxy_->PostTask(
- FROM_HERE, base::Bind(&Core::StartOnIOThread, this));
-}
-
-void URLFetcherImpl::Core::StartOnIOThread() {
- DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
-
- switch (response_destination_) {
- case STRING:
- StartURLRequestWhenAppropriate();
- break;
-
- case PERMANENT_FILE:
- case TEMP_FILE:
- DCHECK(file_message_loop_proxy_.get())
- << "Need to set the file message loop proxy.";
-
- file_writer_.reset(new FileWriter(this, file_message_loop_proxy_));
-
- // If the file is successfully created,
- // Core::StartURLRequestWhenAppropriate() will be called.
- switch (response_destination_) {
- case PERMANENT_FILE:
- file_writer_->CreateFileAtPath(response_destination_file_path_);
- break;
- case TEMP_FILE:
- file_writer_->CreateTempFile();
- break;
- default:
- NOTREACHED();
- }
- break;
-
- default:
- NOTREACHED();
- }
-}
-
-void URLFetcherImpl::Core::Stop() {
- if (delegate_loop_proxy_) // May be NULL in tests.
- DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
-
- delegate_ = NULL;
- fetcher_ = NULL;
- if (io_message_loop_proxy_.get()) {
- io_message_loop_proxy_->PostTask(
- FROM_HERE, base::Bind(&Core::CancelURLRequest, this));
- }
-}
-
-void URLFetcherImpl::Core::ReceivedContentWasMalformed() {
- DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
- if (io_message_loop_proxy_.get()) {
- io_message_loop_proxy_->PostTask(
- FROM_HERE, base::Bind(&Core::NotifyMalformedContent, this));
- }
-}
-
-void URLFetcherImpl::Core::CancelAll() {
- g_registry.Get().CancelAll();
-}
-
-void URLFetcherImpl::Core::OnResponseStarted(net::URLRequest* request) {
- DCHECK_EQ(request, request_.get());
- DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
- if (request_->status().is_success()) {
- response_code_ = request_->GetResponseCode();
- response_headers_ = request_->response_headers();
- socket_address_ = request_->GetSocketAddress();
- was_fetched_via_proxy_ = request_->was_fetched_via_proxy();
- total_response_bytes_ = request_->GetExpectedContentSize();
- }
-
- ReadResponse();
-}
-
-void URLFetcherImpl::Core::CompleteAddingUploadDataChunk(
- const std::string& content, bool is_last_chunk) {
- DCHECK(is_chunked_upload_);
- DCHECK(request_.get());
- DCHECK(!content.empty());
- request_->AppendChunkToUpload(content.data(),
- static_cast<int>(content.length()),
- is_last_chunk);
-}
-
-void URLFetcherImpl::Core::AppendChunkToUpload(const std::string& content,
- bool is_last_chunk) {
- DCHECK(delegate_loop_proxy_);
- DCHECK(io_message_loop_proxy_.get());
- io_message_loop_proxy_->PostTask(
- FROM_HERE,
- base::Bind(&Core::CompleteAddingUploadDataChunk, this, content,
- is_last_chunk));
-}
-
-// Return true if the write was done and reading may continue.
-// Return false if the write is pending, and the next read will
-// be done later.
-bool URLFetcherImpl::Core::WriteBuffer(int num_bytes) {
- bool write_complete = false;
- switch (response_destination_) {
- case STRING:
- data_.append(buffer_->data(), num_bytes);
- write_complete = true;
- break;
-
- case PERMANENT_FILE:
- case TEMP_FILE:
- file_writer_->WriteBuffer(num_bytes);
- // WriteBuffer() sends a request the file thread.
- // The write is not done yet.
- write_complete = false;
- break;
-
- default:
- NOTREACHED();
- }
- return write_complete;
-}
-
-void URLFetcherImpl::Core::OnReadCompleted(net::URLRequest* request,
- int bytes_read) {
- DCHECK(request == request_);
- DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
-
- url_ = request->url();
- url_throttler_entry_ =
- net::URLRequestThrottlerManager::GetInstance()->RegisterRequestUrl(url_);
-
- bool waiting_on_write = false;
- do {
- if (!request_->status().is_success() || bytes_read <= 0)
- break;
-
- current_response_bytes_ += bytes_read;
- InformDelegateDownloadProgress();
-
- if (!WriteBuffer(bytes_read)) {
- // If WriteBuffer() returns false, we have a pending write to
- // wait on before reading further.
- waiting_on_write = true;
- break;
- }
- } while (request_->Read(buffer_, kBufferSize, &bytes_read));
-
- const net::URLRequestStatus status = request_->status();
-
- if (status.is_success())
- request_->GetResponseCookies(&cookies_);
-
- // See comments re: HEAD requests in ReadResponse().
- if ((!status.is_io_pending() && !waiting_on_write) ||
- (request_type_ == HEAD)) {
- status_ = status;
- ReleaseRequest();
-
- // If a file is open, close it.
- if (file_writer_.get()) {
- // If the file is open, close it. After closing the file,
- // RetryOrCompleteUrlFetch() will be called.
- file_writer_->CloseFileAndCompleteRequest();
- } else {
- // Otherwise, complete or retry the URL request directly.
- RetryOrCompleteUrlFetch();
- }
- }
-}
-
-void URLFetcherImpl::Core::RetryOrCompleteUrlFetch() {
- DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
- base::TimeDelta backoff_delay;
-
- // Checks the response from server.
- if (response_code_ >= 500 ||
- status_.error() == net::ERR_TEMPORARILY_THROTTLED) {
- // When encountering a server error, we will send the request again
- // after backoff time.
- ++num_retries_;
-
- // Note that backoff_delay may be 0 because (a) the URLRequestThrottler
- // code does not necessarily back off on the first error, and (b) it
- // only backs off on some of the 5xx status codes.
- base::TimeTicks backoff_release_time = GetBackoffReleaseTime();
- backoff_delay = backoff_release_time - base::TimeTicks::Now();
- if (backoff_delay < base::TimeDelta())
- backoff_delay = base::TimeDelta();
-
- if (automatically_retry_on_5xx_ && num_retries_ <= max_retries_) {
- StartOnIOThread();
- return;
- }
- } else {
- backoff_delay = base::TimeDelta();
- }
- request_context_getter_ = NULL;
- render_process_id_ = -1;
- render_view_id_ = -1;
- first_party_for_cookies_ = GURL();
- bool posted = delegate_loop_proxy_->PostTask(
- FROM_HERE, base::Bind(&Core::OnCompletedURLRequest, this, backoff_delay));
-
- // If the delegate message loop does not exist any more, then the delegate
- // should be gone too.
- DCHECK(posted || !delegate_);
-}
-
-void URLFetcherImpl::Core::ReadResponse() {
- // Some servers may treat HEAD requests as GET requests. To free up the
- // network connection as soon as possible, signal that the request has
- // completed immediately, without trying to read any data back (all we care
- // about is the response code and headers, which we already have).
- int bytes_read = 0;
- if (request_->status().is_success() && (request_type_ != HEAD))
- request_->Read(buffer_, kBufferSize, &bytes_read);
- OnReadCompleted(request_.get(), bytes_read);
-}
-
-void URLFetcherImpl::Core::DisownFile() {
- file_writer_->DisownFile();
-}
-
-void URLFetcherImpl::Core::StartURLRequest() {
- DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
-
- if (was_cancelled_) {
- // Since StartURLRequest() is posted as a *delayed* task, it may
- // run after the URLFetcher was already stopped.
- return;
- }
-
- DCHECK(request_context_getter_);
- DCHECK(!request_.get());
-
- g_registry.Get().AddURLFetcherCore(this);
- current_response_bytes_ = 0;
- request_.reset(new net::URLRequest(original_url_, this));
- int flags = request_->load_flags() | load_flags_;
- if (!g_interception_enabled)
- flags = flags | net::LOAD_DISABLE_INTERCEPT;
-
- if (is_chunked_upload_)
- request_->EnableChunkedUpload();
- request_->set_load_flags(flags);
- request_->set_context(request_context_getter_->GetURLRequestContext());
- request_->set_referrer(referrer_);
- request_->set_first_party_for_cookies(first_party_for_cookies_.is_empty() ?
- original_url_ : first_party_for_cookies_);
- if (render_process_id_ != -1 && render_view_id_ != -1) {
- request_->SetUserData(
- URLRequestUserData::kUserDataKey,
- new URLRequestUserData(render_process_id_, render_view_id_));
- }
-
- switch (request_type_) {
- case GET:
- break;
-
- case POST:
- case PUT:
- DCHECK(!upload_content_.empty() || is_chunked_upload_);
- DCHECK(!upload_content_type_.empty());
-
- request_->set_method(request_type_ == POST ? "POST" : "PUT");
- extra_request_headers_.SetHeader(net::HttpRequestHeaders::kContentType,
- upload_content_type_);
- if (!upload_content_.empty()) {
- request_->AppendBytesToUpload(
- upload_content_.data(), static_cast<int>(upload_content_.length()));
- }
-
- current_upload_bytes_ = -1;
- // TODO(kinaba): http://crbug.com/118103. Implement upload callback in the
- // net:: layer and avoid using timer here.
- upload_progress_checker_timer_.reset(new base::RepeatingTimer<Core>());
- upload_progress_checker_timer_->Start(
- FROM_HERE,
- base::TimeDelta::FromMilliseconds(kUploadProgressTimerInterval),
- this,
- &Core::InformDelegateUploadProgress);
- break;
-
- case HEAD:
- request_->set_method("HEAD");
- break;
-
- case DELETE_REQUEST:
- request_->set_method("DELETE");
- break;
-
- default:
- NOTREACHED();
- }
-
- if (!extra_request_headers_.IsEmpty())
- request_->SetExtraRequestHeaders(extra_request_headers_);
-
- // There might be data left over from a previous request attempt.
- data_.clear();
-
- // If we are writing the response to a file, the only caller
- // of this function should have created it and not written yet.
- DCHECK(!file_writer_.get() || file_writer_->total_bytes_written() == 0);
-
- request_->Start();
-}
-
-void URLFetcherImpl::Core::StartURLRequestWhenAppropriate() {
- DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
-
- if (was_cancelled_)
- return;
-
- if (original_url_throttler_entry_ == NULL) {
- original_url_throttler_entry_ =
- net::URLRequestThrottlerManager::GetInstance()->RegisterRequestUrl(
- original_url_);
- }
-
- int64 delay = original_url_throttler_entry_->ReserveSendingTimeForNextRequest(
- GetBackoffReleaseTime());
- if (delay == 0) {
- StartURLRequest();
- } else {
- MessageLoop::current()->PostDelayedTask(
- FROM_HERE, base::Bind(&Core::StartURLRequest, this),
- base::TimeDelta::FromMilliseconds(delay));
- }
-}
-
-void URLFetcherImpl::Core::CancelURLRequest() {
- DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
-
- if (request_.get()) {
- request_->Cancel();
- ReleaseRequest();
- }
- // Release the reference to the request context. There could be multiple
- // references to URLFetcher::Core at this point so it may take a while to
- // delete the object, but we cannot delay the destruction of the request
- // context.
- request_context_getter_ = NULL;
- render_process_id_ = -1;
- render_view_id_ = -1;
- first_party_for_cookies_ = GURL();
- was_cancelled_ = true;
- file_writer_.reset();
-}
-
-void URLFetcherImpl::Core::OnCompletedURLRequest(
- base::TimeDelta backoff_delay) {
- DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
-
- // Save the status and backoff_delay so that delegates can read it.
- if (delegate_) {
- backoff_delay_ = backoff_delay;
- InformDelegateFetchIsComplete();
- }
-}
-
-void URLFetcherImpl::Core::InformDelegateUploadProgress() {
- DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
- if (request_.get()) {
- int64 current = request_->GetUploadProgress();
- if (current_upload_bytes_ != current) {
- current_upload_bytes_ = current;
- int64 total = -1;
- if (!is_chunked_upload_)
- total = static_cast<int64>(upload_content_.size());
- delegate_loop_proxy_->PostTask(
- FROM_HERE,
- base::Bind(&Core::InformDelegateUploadProgressInDelegateThread,
- this, current, total));
- }
- }
-}
-
-void URLFetcherImpl::Core::InformDelegateUploadProgressInDelegateThread(
- int64 current, int64 total) {
- DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
- if (delegate_)
- delegate_->OnURLFetchUploadProgress(fetcher_, current, total);
-}
-
-void URLFetcherImpl::Core::InformDelegateDownloadProgress() {
- DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
- delegate_loop_proxy_->PostTask(
- FROM_HERE,
- base::Bind(&Core::InformDelegateDownloadProgressInDelegateThread,
- this, current_response_bytes_, total_response_bytes_));
-}
-
-void URLFetcherImpl::Core::InformDelegateDownloadProgressInDelegateThread(
- int64 current, int64 total) {
- DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
- if (delegate_)
- delegate_->OnURLFetchDownloadProgress(fetcher_, current, total);
-}
-
-void URLFetcherImpl::Core::InformDelegateFetchIsComplete() {
- DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
- if (delegate_)
- delegate_->OnURLFetchComplete(fetcher_);
-}
-
-void URLFetcherImpl::Core::NotifyMalformedContent() {
- DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
- if (url_throttler_entry_ != NULL) {
- int status_code = response_code_;
- if (status_code == RESPONSE_CODE_INVALID) {
- // The status code will generally be known by the time clients
- // call the |ReceivedContentWasMalformed()| function (which ends up
- // calling the current function) but if it's not, we need to assume
- // the response was successful so that the total failure count
- // used to calculate exponential back-off goes up.
- status_code = 200;
- }
- url_throttler_entry_->ReceivedContentWasMalformed(status_code);
- }
-}
-
-void URLFetcherImpl::Core::ReleaseRequest() {
- upload_progress_checker_timer_.reset();
- request_.reset();
- g_registry.Get().RemoveURLFetcherCore(this);
-}
-
-base::TimeTicks URLFetcherImpl::Core::GetBackoffReleaseTime() {
- DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
- DCHECK(original_url_throttler_entry_ != NULL);
-
- base::TimeTicks original_url_backoff =
- original_url_throttler_entry_->GetExponentialBackoffReleaseTime();
- base::TimeTicks destination_url_backoff;
- if (url_throttler_entry_ != NULL &&
- original_url_throttler_entry_ != url_throttler_entry_) {
- destination_url_backoff =
- url_throttler_entry_->GetExponentialBackoffReleaseTime();
- }
-
- return original_url_backoff > destination_url_backoff ?
- original_url_backoff : destination_url_backoff;
-}
-
void URLFetcherImpl::SetUploadData(const std::string& upload_content_type,
const std::string& upload_content) {
- DCHECK(!core_->is_chunked_upload_);
- core_->upload_content_type_ = upload_content_type;
- core_->upload_content_ = upload_content;
+ core_->SetUploadData(upload_content_type, upload_content);
}
void URLFetcherImpl::SetChunkedUpload(const std::string& content_type) {
- DCHECK(core_->is_chunked_upload_ ||
- (core_->upload_content_type_.empty() &&
- core_->upload_content_.empty()));
- core_->upload_content_type_ = content_type;
- core_->upload_content_.clear();
- core_->is_chunked_upload_ = true;
+ core_->SetChunkedUpload(content_type);
}
void URLFetcherImpl::AppendChunkToUpload(const std::string& data,
@@ -1096,111 +65,83 @@ void URLFetcherImpl::AppendChunkToUpload(const std::string& data,
core_->AppendChunkToUpload(data, is_last_chunk);
}
-const std::string& URLFetcherImpl::upload_data() const {
- return core_->upload_content_;
-}
-
void URLFetcherImpl::SetReferrer(const std::string& referrer) {
- core_->referrer_ = referrer;
+ core_->SetReferrer(referrer);
}
void URLFetcherImpl::SetLoadFlags(int load_flags) {
- core_->load_flags_ = load_flags;
+ core_->SetLoadFlags(load_flags);
}
int URLFetcherImpl::GetLoadFlags() const {
- return core_->load_flags_;
+ return core_->GetLoadFlags();
}
void URLFetcherImpl::SetExtraRequestHeaders(
const std::string& extra_request_headers) {
- core_->extra_request_headers_.Clear();
- core_->extra_request_headers_.AddHeadersFromString(extra_request_headers);
+ core_->SetExtraRequestHeaders(extra_request_headers);
}
void URLFetcherImpl::AddExtraRequestHeader(const std::string& header_line) {
- core_->extra_request_headers_.AddHeaderFromString(header_line);
+ core_->AddExtraRequestHeader(header_line);
}
-void URLFetcherImpl::GetExtraRequestHeaders(net::HttpRequestHeaders* headers) {
- headers->CopyFrom(core_->extra_request_headers_);
+void URLFetcherImpl::GetExtraRequestHeaders(
+ net::HttpRequestHeaders* headers) const {
+ GetExtraRequestHeaders(headers);
}
void URLFetcherImpl::SetRequestContext(
net::URLRequestContextGetter* request_context_getter) {
- DCHECK(!core_->request_context_getter_);
- core_->request_context_getter_ = request_context_getter;
+ core_->SetRequestContext(request_context_getter);
}
void URLFetcherImpl::AssociateWithRenderView(
const GURL& first_party_for_cookies,
int render_process_id,
int render_view_id) {
- DCHECK(core_->first_party_for_cookies_.is_empty());
- DCHECK_EQ(core_->render_process_id_, -1);
- DCHECK_EQ(core_->render_view_id_, -1);
- DCHECK_GE(render_process_id, 0);
- DCHECK_GE(render_view_id, 0);
- core_->first_party_for_cookies_ = first_party_for_cookies;
- core_->render_process_id_ = render_process_id;
- core_->render_view_id_ = render_view_id;
+ core_->AssociateWithRenderView(
+ first_party_for_cookies, render_process_id, render_view_id);
}
void URLFetcherImpl::SetAutomaticallyRetryOn5xx(bool retry) {
- core_->automatically_retry_on_5xx_ = retry;
+ core_->SetAutomaticallyRetryOn5xx(retry);
}
void URLFetcherImpl::SetMaxRetries(int max_retries) {
- core_->max_retries_ = max_retries;
+ core_->SetMaxRetries(max_retries);
}
int URLFetcherImpl::GetMaxRetries() const {
- return core_->max_retries_;
+ return core_->GetMaxRetries();
}
base::TimeDelta URLFetcherImpl::GetBackoffDelay() const {
- return core_->backoff_delay_;
+ return core_->GetBackoffDelay();
}
void URLFetcherImpl::SaveResponseToFileAtPath(
const FilePath& file_path,
scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy) {
- DCHECK(core_->delegate_loop_proxy_->BelongsToCurrentThread());
- core_->file_message_loop_proxy_ = file_message_loop_proxy;
- core_->response_destination_ = PERMANENT_FILE;
- core_->response_destination_file_path_ = file_path;
+ core_->SaveResponseToFileAtPath(file_path, file_message_loop_proxy);
}
void URLFetcherImpl::SaveResponseToTemporaryFile(
scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy) {
- DCHECK(core_->delegate_loop_proxy_->BelongsToCurrentThread());
- core_->file_message_loop_proxy_ = file_message_loop_proxy;
- core_->response_destination_ = TEMP_FILE;
+ core_->SaveResponseToTemporaryFile(file_message_loop_proxy);
}
net::HttpResponseHeaders* URLFetcherImpl::GetResponseHeaders() const {
- return core_->response_headers_;
-}
-
-void URLFetcherImpl::set_response_headers(
- scoped_refptr<net::HttpResponseHeaders> headers) {
- core_->response_headers_ = headers;
+ return core_->GetResponseHeaders();
}
-// TODO(panayiotis): socket_address_ is written in the IO thread,
-// if this is accessed in the UI thread, this could result in a race.
-// Same for response_headers_ above and was_fetched_via_proxy_ below.
net::HostPortPair URLFetcherImpl::GetSocketAddress() const {
- return core_->socket_address_;
+ return core_->GetSocketAddress();
}
bool URLFetcherImpl::WasFetchedViaProxy() const {
- return core_->was_fetched_via_proxy_;
-}
-
-void URLFetcherImpl::set_was_fetched_via_proxy(bool flag) {
- core_->was_fetched_via_proxy_ = flag;
+ return core_->WasFetchedViaProxy();
}
void URLFetcherImpl::Start() {
@@ -1208,38 +149,28 @@ void URLFetcherImpl::Start() {
}
const GURL& URLFetcherImpl::GetOriginalURL() const {
- return core_->original_url_;
+ return core_->GetOriginalURL();
}
const GURL& URLFetcherImpl::GetURL() const {
- return core_->url_;
+ return core_->GetURL();
}
const net::URLRequestStatus& URLFetcherImpl::GetStatus() const {
- return core_->status_;
+ return core_->GetStatus();
}
int URLFetcherImpl::GetResponseCode() const {
- return core_->response_code_;
+ return core_->GetResponseCode();
}
const net::ResponseCookies& URLFetcherImpl::GetCookies() const {
- return core_->cookies_;
+ return core_->GetCookies();
}
bool URLFetcherImpl::FileErrorOccurred(
base::PlatformFileError* out_error_code) const {
-
- // Can't have a file error if no file is being created or written to.
- if (!core_->file_writer_.get())
- return false;
-
- base::PlatformFileError error_code = core_->file_writer_->error_code();
- if (error_code == base::PLATFORM_FILE_OK)
- return false;
-
- *out_error_code = error_code;
- return true;
+ return core_->FileErrorOccurred(out_error_code);
}
void URLFetcherImpl::ReceivedContentWasMalformed() {
@@ -1248,41 +179,23 @@ void URLFetcherImpl::ReceivedContentWasMalformed() {
bool URLFetcherImpl::GetResponseAsString(
std::string* out_response_string) const {
- if (core_->response_destination_ != STRING)
- return false;
-
- *out_response_string = core_->data_;
- UMA_HISTOGRAM_MEMORY_KB("UrlFetcher.StringResponseSize",
- (core_->data_.length() / 1024));
-
- return true;
+ return core_->GetResponseAsString(out_response_string);
}
-bool URLFetcherImpl::GetResponseAsFilePath(bool take_ownership,
- FilePath* out_response_path) const {
- DCHECK(core_->delegate_loop_proxy_->BelongsToCurrentThread());
- const bool destination_is_file = core_->response_destination_ == TEMP_FILE ||
- core_->response_destination_ == PERMANENT_FILE;
- if (!destination_is_file || !core_->file_writer_.get())
- return false;
-
- *out_response_path = core_->file_writer_->file_path();
-
- if (take_ownership) {
- core_->io_message_loop_proxy_->PostTask(
- FROM_HERE, base::Bind(&Core::DisownFile, core_.get()));
- }
- return true;
+bool URLFetcherImpl::GetResponseAsFilePath(
+ bool take_ownership,
+ FilePath* out_response_path) const {
+ return core_->GetResponseAsFilePath(take_ownership, out_response_path);
}
// static
void URLFetcherImpl::CancelAll() {
- Core::CancelAll();
+ content::URLFetcherCore::CancelAll();
}
// static
int URLFetcherImpl::GetNumFetcherCores() {
- return Core::g_registry.Get().size();
+ return content::URLFetcherCore::GetNumFetcherCores();
}
content::URLFetcherDelegate* URLFetcherImpl::delegate() const {
diff --git a/content/common/net/url_fetcher_impl.h b/content/common/net/url_fetcher_impl.h
index 4a85652..23ca936 100644
--- a/content/common/net/url_fetcher_impl.h
+++ b/content/common/net/url_fetcher_impl.h
@@ -15,16 +15,18 @@
#define CONTENT_COMMON_NET_URL_FETCHER_IMPL_H_
#pragma once
+#include "base/basictypes.h"
#include "base/compiler_specific.h"
-#include "base/message_loop.h"
-#include "base/time.h"
+#include "content/common/content_export.h"
#include "content/public/common/url_fetcher.h"
namespace content {
+class URLFetcherCore;
+class URLFetcherDelegate;
class URLFetcherFactory;
-}
+} // namespace content
-class CONTENT_EXPORT URLFetcherImpl : public content::URLFetcher{
+class CONTENT_EXPORT URLFetcherImpl : public content::URLFetcher {
public:
// |url| is the URL to send the request to.
// |request_type| is the type of request to make.
@@ -48,7 +50,7 @@ class CONTENT_EXPORT URLFetcherImpl : public content::URLFetcher{
const std::string& extra_request_headers) OVERRIDE;
virtual void AddExtraRequestHeader(const std::string& header_line) OVERRIDE;
virtual void GetExtraRequestHeaders(
- net::HttpRequestHeaders* headers) OVERRIDE;
+ net::HttpRequestHeaders* headers) const OVERRIDE;
virtual void SetRequestContext(
net::URLRequestContextGetter* request_context_getter) OVERRIDE;
virtual void AssociateWithRenderView(const GURL& first_party_for_cookies,
@@ -84,25 +86,9 @@ class CONTENT_EXPORT URLFetcherImpl : public content::URLFetcher{
static void CancelAll();
protected:
- // How should the response be stored?
- enum ResponseDestinationType {
- STRING, // Default: In a std::string
- PERMANENT_FILE, // Write to a permanent file.
- TEMP_FILE, // Write to a temporary file.
- };
-
// Returns the delegate.
content::URLFetcherDelegate* delegate() const;
- // Used by tests.
- const std::string& upload_data() const;
-
- // Used by tests.
- void set_was_fetched_via_proxy(bool flag);
-
- // Used by tests.
- void set_response_headers(scoped_refptr<net::HttpResponseHeaders> headers);
-
private:
friend class ScopedURLFetcherFactory;
friend class TestURLFetcher;
@@ -121,8 +107,7 @@ class CONTENT_EXPORT URLFetcherImpl : public content::URLFetcher{
// NOTE: for safety, this should only be used through ScopedURLFetcherFactory!
static void set_factory(content::URLFetcherFactory* factory);
- class Core;
- scoped_refptr<Core> core_;
+ const scoped_refptr<content::URLFetcherCore> core_;
DISALLOW_COPY_AND_ASSIGN(URLFetcherImpl);
};
diff --git a/content/content_common.gypi b/content/content_common.gypi
index 7abc9d3..f35e72e 100644
--- a/content/content_common.gypi
+++ b/content/content_common.gypi
@@ -247,6 +247,8 @@
'common/message_router.h',
'common/mime_registry_messages.h',
'common/navigation_gesture.h',
+ 'common/net/url_fetcher_core.cc',
+ 'common/net/url_fetcher_core.h',
'common/net/url_fetcher_impl.cc',
'common/net/url_fetcher_impl.h',
'common/net/url_request_user_data.cc',
diff --git a/content/public/common/url_fetcher.h b/content/public/common/url_fetcher.h
index 2d6d9f8..57266dc 100644
--- a/content/public/common/url_fetcher.h
+++ b/content/public/common/url_fetcher.h
@@ -149,7 +149,8 @@ class CONTENT_EXPORT URLFetcher {
// This appends the header to the current extra request headers.
virtual void AddExtraRequestHeader(const std::string& header_line) = 0;
- virtual void GetExtraRequestHeaders(net::HttpRequestHeaders* headers) = 0;
+ virtual void GetExtraRequestHeaders(
+ net::HttpRequestHeaders* headers) const = 0;
// Set the net::URLRequestContext on the request. Must be called before the
// request is started.
diff --git a/content/test/test_url_fetcher_factory.cc b/content/test/test_url_fetcher_factory.cc
index 41d1e31..d8deeec 100644
--- a/content/test/test_url_fetcher_factory.cc
+++ b/content/test/test_url_fetcher_factory.cc
@@ -80,7 +80,8 @@ void TestURLFetcher::AddExtraRequestHeader(const std::string& header_line) {
fake_extra_request_headers_.AddHeaderFromString(header_line);
}
-void TestURLFetcher::GetExtraRequestHeaders(net::HttpRequestHeaders* headers) {
+void TestURLFetcher::GetExtraRequestHeaders(
+ net::HttpRequestHeaders* headers) const {
*headers = fake_extra_request_headers_;
}
diff --git a/content/test/test_url_fetcher_factory.h b/content/test/test_url_fetcher_factory.h
index cf809d7..c26a666 100644
--- a/content/test/test_url_fetcher_factory.h
+++ b/content/test/test_url_fetcher_factory.h
@@ -77,7 +77,7 @@ class TestURLFetcher : public content::URLFetcher {
const std::string& extra_request_headers) OVERRIDE;
virtual void AddExtraRequestHeader(const std::string& header_line) OVERRIDE;
virtual void GetExtraRequestHeaders(
- net::HttpRequestHeaders* headers) OVERRIDE;
+ net::HttpRequestHeaders* headers) const OVERRIDE;
virtual void SetRequestContext(
net::URLRequestContextGetter* request_context_getter) OVERRIDE;
virtual void AssociateWithRenderView(const GURL& first_party_for_cookies,