diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-08 10:42:25 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-08 10:42:25 +0000 |
| commit | d22618c155cd40c5740755a5f0bcaab59f13f9a7 (patch) | |
| tree | fd8a1c4580473634f293233d6c88c77387da5e8a | |
| parent | 7aa782e43917cc6ca64e4e868186056efbf11a9a (diff) | |
| download | chromium_src-d22618c155cd40c5740755a5f0bcaab59f13f9a7.zip chromium_src-d22618c155cd40c5740755a5f0bcaab59f13f9a7.tar.gz chromium_src-d22618c155cd40c5740755a5f0bcaab59f13f9a7.tar.bz2 | |
Tracking down flakiness in PrepopulateRespectBlank.
It seems the problem with the crash_service window eating input
has been eliminated, but there is still some flakiness left. My
traces indicate that probably no window has focus, so lets try to force
the browser window to have focus, like we do in the browser focus
tests.
BUG=62937
TEST=Fixing a test.
Review URL: http://codereview.chromium.org/5566006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68576 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/ui/views/find_bar_host_interactive_uitest.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/browser/ui/views/find_bar_host_interactive_uitest.cc b/chrome/browser/ui/views/find_bar_host_interactive_uitest.cc index b26e5e4..d4151c2 100644 --- a/chrome/browser/ui/views/find_bar_host_interactive_uitest.cc +++ b/chrome/browser/ui/views/find_bar_host_interactive_uitest.cc @@ -85,6 +85,7 @@ bool ChromeInForeground() { EXPECT_TRUE(chrome_window_in_foreground) << "Chrome must be in the foreground when running interactive tests\n" << "Process in foreground: " << filename.c_str() << "\n" + << "Window: " << window << "\n" << "Caption: " << caption.c_str(); return chrome_window_in_foreground; #else @@ -261,7 +262,8 @@ IN_PROC_BROWSER_TEST_F(FindInPageTest, PrepopulateRespectBlank) { // Make sure Chrome is in the foreground, otherwise sending input // won't do anything and the test will hang. - ASSERT_TRUE(ChromeInForeground()); + ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser())); + EXPECT_TRUE(ChromeInForeground()); // First we navigate to any page. Checkpoint("Navigating", start_time); |