summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorhclam@chromium.org <hclam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2008-12-05 19:31:09 +0000
committerhclam@chromium.org <hclam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2008-12-05 19:31:09 +0000
commitd604e96bed6afbdac45ed4d4318aab7bf693bd0b (patch)
tree0fb4ed80c425236a080dde6569dbf41ac39601b1
parent7cda2b7828c92e3123c74bf416a67e363e7bd8b4 (diff)
downloadchromium_src-d604e96bed6afbdac45ed4d4318aab7bf693bd0b.zip
chromium_src-d604e96bed6afbdac45ed4d4318aab7bf693bd0b.tar.gz
chromium_src-d604e96bed6afbdac45ed4d4318aab7bf693bd0b.tar.bz2
Same as CL 12831, create a new one to get rid of the eol-style commit error.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6439 0039d316-1c4b-4281-b951-d872f2087c98
-rwxr-xr-xwebkit/build/V8Bindings/build-generated-files.sh2
-rw-r--r--webkit/build/webkit_common_defines.vsprops2
-rw-r--r--webkit/port/bindings/v8/v8_proxy.cpp13
3 files changed, 13 insertions, 4 deletions
diff --git a/webkit/build/V8Bindings/build-generated-files.sh b/webkit/build/V8Bindings/build-generated-files.sh
index f5aca10..f46b202 100755
--- a/webkit/build/V8Bindings/build-generated-files.sh
+++ b/webkit/build/V8Bindings/build-generated-files.sh
@@ -43,7 +43,7 @@ export ENCODINGS_PREFIX=""
# To see what FEATURE_DEFINES Apple uses, look at:
# webkit/third_party/WebCore/Configurations/WebCore.xcconfig
-export FEATURE_DEFINES="ENABLE_SVG ENABLE_SVG_ANIMATION ENABLE_SVG_AS_IMAGE ENABLE_SVG_FONTS ENABLE_SVG_FOREIGN_OBJECT ENABLE_SVG_USE ENABLE_XPATH ENABLE_XSLT"
+export FEATURE_DEFINES="ENABLE_VIDEO ENABLE_SVG ENABLE_SVG_ANIMATION ENABLE_SVG_AS_IMAGE ENABLE_SVG_FONTS ENABLE_SVG_FOREIGN_OBJECT ENABLE_SVG_USE ENABLE_XPATH ENABLE_XSLT"
echo Building DerivedSources ${PORTROOT}...
# Use silent flag.
diff --git a/webkit/build/webkit_common_defines.vsprops b/webkit/build/webkit_common_defines.vsprops
index 0f750cc..0ea8266 100644
--- a/webkit/build/webkit_common_defines.vsprops
+++ b/webkit/build/webkit_common_defines.vsprops
@@ -6,6 +6,6 @@
>
<Tool
Name="VCCLCompilerTool"
- PreprocessorDefinitions="ENABLE_DATABASE=1;ENABLE_DASHBOARD_SUPPORT=0;ENABLE_JAVASCRIPT_DEBUGGER=0;ENABLE_JSC_MULTIPLE_THREADS=0;ENABLE_ICONDATABASE=0;ENABLE_XSLT=1;ENABLE_XPATH=1;ENABLE_SVG=1;ENABLE_SVG_ANIMATION=1;ENABLE_SVG_AS_IMAGE=1;ENABLE_SVG_USE=1;ENABLE_SVG_FOREIGN_OBJECT=1;ENABLE_SVG_FONTS=1;ENABLE_VIDEO=0;ENABLE_WORKERS=0;WEBCORE_NAVIGATOR_PLATFORM=&quot;\&quot;Win32\&quot;&quot;;USE_GOOGLE_URL_LIBRARY;USE_SYSTEM_MALLOC=1;CRASH=__debugbreak;BUILDING_CHROMIUM__=1;"
+ PreprocessorDefinitions="ENABLE_DATABASE=1;ENABLE_DASHBOARD_SUPPORT=0;ENABLE_JAVASCRIPT_DEBUGGER=0;ENABLE_JSC_MULTIPLE_THREADS=0;ENABLE_ICONDATABASE=0;ENABLE_XSLT=1;ENABLE_XPATH=1;ENABLE_SVG=1;ENABLE_SVG_ANIMATION=1;ENABLE_SVG_AS_IMAGE=1;ENABLE_SVG_USE=1;ENABLE_SVG_FOREIGN_OBJECT=1;ENABLE_SVG_FONTS=1;ENABLE_VIDEO=1;ENABLE_WORKERS=0;WEBCORE_NAVIGATOR_PLATFORM=&quot;\&quot;Win32\&quot;&quot;;USE_GOOGLE_URL_LIBRARY;USE_SYSTEM_MALLOC=1;CRASH=__debugbreak;BUILDING_CHROMIUM__=1"
/>
</VisualStudioPropertySheet>
diff --git a/webkit/port/bindings/v8/v8_proxy.cpp b/webkit/port/bindings/v8/v8_proxy.cpp
index 5981ef8b..632c306 100644
--- a/webkit/port/bindings/v8/v8_proxy.cpp
+++ b/webkit/port/bindings/v8/v8_proxy.cpp
@@ -98,6 +98,7 @@
#include "KeyboardEvent.h"
#include "Location.h"
#include "MediaList.h"
+#include "MediaPlayer.h"
#include "MessageChannel.h"
#include "MessageEvent.h"
#include "MessagePort.h"
@@ -2582,8 +2583,7 @@ bool V8Proxy::IsWrapperOfType(v8::Handle<v8::Value> value,
macro(textarea, TEXTAREA) \
macro(title, TITLE) \
macro(ul, ULIST) \
- macro(xmp, PRE) \
- FOR_EACH_VIDEO_TAG(macro)
+ macro(xmp, PRE)
V8ClassIndex::V8WrapperType V8Proxy::GetHTMLElementType(HTMLElement* element)
{
@@ -2592,6 +2592,15 @@ V8ClassIndex::V8WrapperType V8Proxy::GetHTMLElementType(HTMLElement* element)
#define ADD_TO_HASH_MAP(tag, name) \
map.set(#tag, V8ClassIndex::HTML##name##ELEMENT);
FOR_EACH_TAG(ADD_TO_HASH_MAP)
+#if ENABLE(VIDEO)
+ // If MediaPlayer::isAvailable() == false, WebCore::videoContructor
+ // creates a HTMLelement object for <video> tag rather than HTMLVideoElement
+ // so only add the mappings if media player is available, or we will get
+ // the wrong element type. Same thing for <audio> and <source>.
+ if (MediaPlayer::isAvailable()) {
+FOR_EACH_VIDEO_TAG(ADD_TO_HASH_MAP)
+ }
+#endif
#undef ADD_TO_HASH_MAP
}