summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-04-12 16:51:11 +0000
committerjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-04-12 16:51:11 +0000
commitdede934ec5e552b57d437de333dafcc87e486410 (patch)
treedf4fffd45f79498f1c48eb3b7b5ba05bde276983
parentf6f53bab45ab210f2e0c50d914e603f27f1fc676 (diff)
downloadchromium_src-dede934ec5e552b57d437de333dafcc87e486410.zip
chromium_src-dede934ec5e552b57d437de333dafcc87e486410.tar.gz
chromium_src-dede934ec5e552b57d437de333dafcc87e486410.tar.bz2
AutoFill: Use FormManager::WebFormControlElementToFormField directly instead of
finding the form field in FindFormWithFormControlElement. BUG=41013 TEST=none Review URL: http://codereview.chromium.org/1527025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44251 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/renderer/render_view.cc17
1 files changed, 4 insertions, 13 deletions
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index 7b81bd9..39e6ec6 100644
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -1970,20 +1970,11 @@ void RenderView::queryAutofillSuggestions(const WebNode& node,
const WebFormControlElement& element =
node.toConstElement<WebFormControlElement>();
- FormData form;
- if (!form_manager_.FindFormWithFormControlElement(element,
- FormManager::REQUIRE_NONE,
- &form))
- return;
+ webkit_glue::FormField field;
+ FormManager::WebFormControlElementToFormField(element, true, &field);
- // TODO(jhawkins): This is very slow. Add a label cache to FormManager.
- for (std::vector<FormField>::const_iterator iter = form.fields.begin();
- iter != form.fields.end(); ++iter) {
- if (iter->name() == element.nameForAutofill()) {
- Send(new ViewHostMsg_QueryFormFieldAutofill(
- routing_id_, autofill_query_id_, *iter));
- }
- }
+ Send(new ViewHostMsg_QueryFormFieldAutofill(
+ routing_id_, autofill_query_id_, field));
}
void RenderView::removeAutofillSuggestions(const WebString& name,