diff options
| author | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-15 15:30:33 +0000 |
|---|---|---|
| committer | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-15 15:30:33 +0000 |
| commit | df3f913f9956fc93a635a4f233d4f0a656a8a6df (patch) | |
| tree | b39232db876dd8b91afbef67c687df3c445f6207 | |
| parent | a946aa310237b41610178389cc946e162cc6587f (diff) | |
| download | chromium_src-df3f913f9956fc93a635a4f233d4f0a656a8a6df.zip chromium_src-df3f913f9956fc93a635a4f233d4f0a656a8a6df.tar.gz chromium_src-df3f913f9956fc93a635a4f233d4f0a656a8a6df.tar.bz2 | |
Make sure that Dump Symbols (dump_app_syms) comes after Strip If Needed
(strip_from_xcode).
This is a corner case that probably nobody else has ever hit, but it hits me
because I often do official release build testing without mac_real_dsym set.
This builds all of Breakpad for that just-like-official-release taste, but
doesn't give me real .dSYMs or dumped symbols, saving me the time of having to
run real dsymutil when I don't need these.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/275025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29119 0039d316-1c4b-4281-b951-d872f2087c98
| -rwxr-xr-x | chrome/chrome.gyp | 28 |
1 files changed, 22 insertions, 6 deletions
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index c9c67e5..fa43d42 100755 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -3455,12 +3455,28 @@ '../breakpad/breakpad.gyp:dump_syms', '../breakpad/breakpad.gyp:symupload', ], - 'postbuilds': [ - { - 'postbuild_name': 'Dump Symbols', - 'action': ['<(DEPTH)/build/mac/dump_app_syms', - '<(branding)'], - }, + # The "Dump Symbols" post-build step is in a target_conditions + # block so that it will follow the "Strip If Needed" step if that + # is also being used. There is no standard configuration where + # both of these steps occur together, but Mark likes to use this + # configuraiton sometimes when testing Breakpad-enabled builds + # without the time overhead of creating real .dSYM files. When + # both "Dump Symbols" and "Strip If Needed" are present, "Dump + # Symbols" must come second because "Strip If Needed" creates + # a fake .dSYM that dump_syms needs to fake dump. Since + # "Strip If Needed" is added in a target_conditions block in + # common.gypi, "Dump Symbols" needs to be in an (always true) + # target_conditions block. + 'target_conditions': [ + ['1 == 1', { + 'postbuilds': [ + { + 'postbuild_name': 'Dump Symbols', + 'action': ['<(DEPTH)/build/mac/dump_app_syms', + '<(branding)'], + }, + ], + }], ], }], # mac_breakpad ['mac_keystone==1', { |