diff options
author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-23 22:35:48 +0000 |
---|---|---|
committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-23 22:35:48 +0000 |
commit | fd11f1752b5296b7f640616193ae3663802e0736 (patch) | |
tree | d7b49dee038d5a40458a705b66b2796a8bbef3c1 | |
parent | fe41d72fbd2f2cb9f087d35065c35bbdc376b2c4 (diff) | |
download | chromium_src-fd11f1752b5296b7f640616193ae3663802e0736.zip chromium_src-fd11f1752b5296b7f640616193ae3663802e0736.tar.gz chromium_src-fd11f1752b5296b7f640616193ae3663802e0736.tar.bz2 |
Adjust Page Load Time histograms in A/B tests
We're focusing on StartToFinish rather than StartToFinishDoc
for PLT tests. I pulled out teh StartToFinishDoc histograms,
and added one more modulated histogram to look at ratios of
forward to back in various test scenarios.
I also removed the A/B tests for delayed binding.
r=willchan
Review URL: http://codereview.chromium.org/657006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39786 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/renderer/render_view.cc | 80 |
1 files changed, 21 insertions, 59 deletions
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc index 17161e9..7d68158 100644 --- a/chrome/renderer/render_view.cc +++ b/chrome/renderer/render_view.cc @@ -4131,43 +4131,30 @@ void RenderView::DumpLoadHistograms() const { static bool use_dns_histogram(FieldTrialList::Find("DnsImpact") && !FieldTrialList::Find("DnsImpact")->group_name().empty()); if (use_dns_histogram) { + UMA_HISTOGRAM_ENUMERATION(FieldTrial::MakeName( + "Renderer4.LoadType", "DnsImpact"), + load_type, NavigationState::kLoadTypeMax); switch (load_type) { case NavigationState::NORMAL_LOAD: UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( - "Renderer4.BeginToFinishDoc_NormalLoad", "DnsImpact"), - begin_to_finish_doc, kBeginToFinishDocMin, kBeginToFinishDocMax, - kBeginToFinishDocBucketCount); - UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( "Renderer4.BeginToFinish_NormalLoad", "DnsImpact"), begin_to_finish, kBeginToFinishMin, kBeginToFinishMax, kBeginToFinishBucketCount); break; case NavigationState::LINK_LOAD_NORMAL: UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( - "Renderer4.BeginToFinishDoc_LinkLoadNormal", "DnsImpact"), - begin_to_finish_doc, kBeginToFinishDocMin, kBeginToFinishDocMax, - kBeginToFinishDocBucketCount); - UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( "Renderer4.BeginToFinish_LinkLoadNormal", "DnsImpact"), begin_to_finish, kBeginToFinishMin, kBeginToFinishMax, kBeginToFinishBucketCount); break; case NavigationState::LINK_LOAD_RELOAD: UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( - "Renderer4.BeginToFinishDoc_LinkLoadReload", "DnsImpact"), - begin_to_finish_doc, kBeginToFinishDocMin, kBeginToFinishDocMax, - kBeginToFinishDocBucketCount); - UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( "Renderer4.BeginToFinish_LinkLoadReload", "DnsImpact"), begin_to_finish, kBeginToFinishMin, kBeginToFinishMax, kBeginToFinishBucketCount); break; case NavigationState::LINK_LOAD_CACHE_STALE_OK: UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( - "Renderer4.BeginToFinishDoc_LinkLoadStaleOk", "DnsImpact"), - begin_to_finish_doc, kBeginToFinishDocMin, kBeginToFinishDocMax, - kBeginToFinishDocBucketCount); - UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( "Renderer4.BeginToFinish_LinkLoadStaleOk", "DnsImpact"), begin_to_finish, kBeginToFinishMin, kBeginToFinishMax, kBeginToFinishBucketCount); @@ -4180,64 +4167,39 @@ void RenderView::DumpLoadHistograms() const { static bool use_sdch_histogram(FieldTrialList::Find("GlobalSdch") && !FieldTrialList::Find("GlobalSdch")->group_name().empty()); if (use_sdch_histogram) { + UMA_HISTOGRAM_ENUMERATION( + FieldTrial::MakeName("Renderer4.LoadType", "GlobalSdch"), + load_type, NavigationState::kLoadTypeMax); switch (load_type) { case NavigationState::NORMAL_LOAD: UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( - "Renderer4.BeginToFinishDoc_NormalLoad", "GlobalSdch"), - begin_to_finish_doc, kBeginToFinishDocMin, kBeginToFinishDocMax, - kBeginToFinishDocBucketCount); + "Renderer4.BeginToFinish_NormalLoad", "GlobalSdch"), + begin_to_finish, kBeginToFinishMin, kBeginToFinishMax, + kBeginToFinishBucketCount); break; case NavigationState::LINK_LOAD_NORMAL: UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( - "Renderer4.BeginToFinishDoc_LinkLoadNormal", "GlobalSdch"), - begin_to_finish_doc, kBeginToFinishDocMin, kBeginToFinishDocMax, - kBeginToFinishDocBucketCount); + "Renderer4.BeginToFinish_LinkLoadNormal", "GlobalSdch"), + begin_to_finish, kBeginToFinishMin, kBeginToFinishMax, + kBeginToFinishBucketCount); break; case NavigationState::LINK_LOAD_RELOAD: UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( - "Renderer4.BeginToFinishDoc_LinkLoadReload", "GlobalSdch"), - begin_to_finish_doc, kBeginToFinishDocMin, kBeginToFinishDocMax, - kBeginToFinishDocBucketCount); + "Renderer4.BeginToFinish_LinkLoadReload", "GlobalSdch"), + begin_to_finish, kBeginToFinishMin, kBeginToFinishMax, + kBeginToFinishBucketCount); break; case NavigationState::LINK_LOAD_CACHE_STALE_OK: UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( - "Renderer4.BeginToFinishDoc_LinkLoadCacheStaleOk", "GlobalSdch"), - begin_to_finish_doc, kBeginToFinishDocMin, kBeginToFinishDocMax, - kBeginToFinishDocBucketCount); + "Renderer4.BeginToFinish_LinkLoadStaleOk", "GlobalSdch"), + begin_to_finish, kBeginToFinishMin, kBeginToFinishMax, + kBeginToFinishBucketCount); break; case NavigationState::LINK_LOAD_CACHE_ONLY: UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( - "Renderer4.BeginToFinishDoc_LinkLoadCacheOnly", "GlobalSdch"), - begin_to_finish_doc, kBeginToFinishDocMin, kBeginToFinishDocMax, - kBeginToFinishDocBucketCount); - break; - default: - break; - } - } - - static bool use_socket_late_binding_histogram = - FieldTrialList::Find("SocketLateBinding") && - !FieldTrialList::Find("SocketLateBinding")->group_name().empty(); - if (use_socket_late_binding_histogram) { - switch (load_type) { - case NavigationState::NORMAL_LOAD: - UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( - "Renderer4.BeginToFinishDoc_NormalLoad", "SocketLateBinding"), - begin_to_finish_doc, kBeginToFinishDocMin, kBeginToFinishDocMax, - kBeginToFinishDocBucketCount); - break; - case NavigationState::LINK_LOAD_NORMAL: - UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( - "Renderer4.BeginToFinishDoc_LinkLoadNormal", "SocketLateBinding"), - begin_to_finish_doc, kBeginToFinishDocMin, kBeginToFinishDocMax, - kBeginToFinishDocBucketCount); - break; - case NavigationState::LINK_LOAD_RELOAD: - UMA_HISTOGRAM_CUSTOM_TIMES(FieldTrial::MakeName( - "Renderer4.BeginToFinishDoc_LinkLoadReload", "SocketLateBinding"), - begin_to_finish_doc, kBeginToFinishDocMin, kBeginToFinishDocMax, - kBeginToFinishDocBucketCount); + "Renderer4.BeginToFinish_LinkLoadCacheOnly", "GlobalSdch"), + begin_to_finish, kBeginToFinishMin, kBeginToFinishMax, + kBeginToFinishBucketCount); break; default: break; |