diff options
| author | sfeuz@chromium.org <sfeuz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-11 11:52:33 +0000 |
|---|---|---|
| committer | sfeuz@chromium.org <sfeuz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-11 11:52:33 +0000 |
| commit | fd9d182f030af6a3e14b218d3be4680059f404aa (patch) | |
| tree | b7e982c4b8637990e7bb7f1c663353404e37a142 | |
| parent | 9ba7aabc2a0be4f045099f25546becddd2b75764 (diff) | |
| download | chromium_src-fd9d182f030af6a3e14b218d3be4680059f404aa.zip chromium_src-fd9d182f030af6a3e14b218d3be4680059f404aa.tar.gz chromium_src-fd9d182f030af6a3e14b218d3be4680059f404aa.tar.bz2 | |
Test for empty passphrase in Sync setup process.
Show the incorrect passphrase message if the user wants to enter an empty passphrase.
BUG=81967
TEST=Test manually.
Review URL: http://codereview.chromium.org/6966008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84965 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/sync/engine/syncapi.cc | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/chrome/browser/sync/engine/syncapi.cc b/chrome/browser/sync/engine/syncapi.cc index 08ee2ae..48327fa 100644 --- a/chrome/browser/sync/engine/syncapi.cc +++ b/chrome/browser/sync/engine/syncapi.cc @@ -1996,6 +1996,14 @@ void SyncManager::SyncInternal::SetUsingExplicitPassphrasePrefForMigration( void SyncManager::SyncInternal::SetPassphrase( const std::string& passphrase, bool is_explicit) { + // We do not accept empty passphrases. + if (passphrase.empty()) { + VLOG(1) << "Rejecting empty passphrase."; + FOR_EACH_OBSERVER(SyncManager::Observer, observers_, + OnPassphraseRequired(sync_api::REASON_SET_PASSPHRASE_FAILED)); + return; + } + // All accesses to the cryptographer are protected by a transaction. WriteTransaction trans(GetUserShare()); Cryptographer* cryptographer = trans.GetCryptographer(); |