Added support for SetInstantSuggestion

BUG=103672
TEST=Note that NOTIMPLEMENTEDs are gone


Review URL: http://codereview.chromium.org/8523007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109525 0039d316-1c4b-4281-b951-d872f2087c98

5 files changed, 18 insertions, 12 deletions

diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index 158738d..2141338 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -63,6 +63,9 @@
 
 #if defined(OS_WIN)
 #include "chrome/browser/ui/views/first_run_bubble.h"
+#endif
+
+#if defined(OS_WIN) || defined(USE_AURA)
 #include "chrome/browser/ui/views/location_bar/suggested_text_view.h"
 #endif
 
@@ -413,7 +416,7 @@ gfx::Point LocationBarView::GetLocationEntryOrigin() const {
   return origin;
 }
 
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(USE_AURA)
 void LocationBarView::SetInstantSuggestion(const string16& text,
                                            bool animate_to_complete) {
   // Don't show the suggested text if inline autocomplete is prevented.
@@ -1238,7 +1241,7 @@ void LocationBarView::Observe(int type,
   }
 }
 
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(USE_AURA)
 bool LocationBarView::HasValidSuggestText() const {
   return suggested_text_view_ && !suggested_text_view_->size().IsEmpty() &&
       !suggested_text_view_->GetText().empty();
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.h b/chrome/browser/ui/views/location_bar/location_bar_view.h
index 28ae57e..614563f 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.h
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.h
@@ -55,7 +55,7 @@ class HorizontalPainter;
 class Label;
 }  // namespace views
 
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(USE_AURA)
 class SuggestedTextView;
 #endif
 
@@ -165,7 +165,7 @@ class LocationBarView : public LocationBar,
   // appears, not where the icons are shown).
   gfx::Point GetLocationEntryOrigin() const;
 
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(USE_AURA)
   // Invoked from OmniboxViewWin to show the instant suggestion.
   void SetInstantSuggestion(const string16& text,
                             bool animate_to_complete);
@@ -325,7 +325,7 @@ class LocationBarView : public LocationBar,
   // Sets the visibility of view to new_vis.
   void ToggleVisibility(bool new_vis, views::View* view);
 
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(USE_AURA)
 #if !defined(USE_AURA)
   // Helper for the Mouse event handlers that does all the real work.
   void OnMouseEvent(const views::MouseEvent& event, UINT msg);
@@ -390,7 +390,7 @@ class LocationBarView : public LocationBar,
   // Shown if the user has selected a keyword.
   SelectedKeywordView* selected_keyword_view_;
 
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(USE_AURA)
   // View responsible for showing suggested text. This is NULL when there is no
   // suggested text.
   SuggestedTextView* suggested_text_view_;
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index f621264..1afbc07 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -148,7 +148,7 @@ OmniboxViewViews::OmniboxViewViews(AutocompleteEditController* controller,
                                    Profile* profile,
                                    CommandUpdater* command_updater,
                                    bool popup_window_mode,
-                                   views::View* location_bar)
+                                   LocationBarView* location_bar)
     : model_(new AutocompleteEditModel(this, controller, profile)),
       popup_view_(CreatePopupView(location_bar)),
       controller_(controller),
@@ -157,7 +157,8 @@ OmniboxViewViews::OmniboxViewViews(AutocompleteEditController* controller,
       popup_window_mode_(popup_window_mode),
       security_level_(ToolbarModel::NONE),
       ime_composing_before_change_(false),
-      delete_at_end_pressed_(false) {
+      delete_at_end_pressed_(false),
+      location_bar_view_(location_bar) {
   set_border(views::Border::CreateEmptyBorder(kAutocompleteVerticalMargin, 0,
                                               kAutocompleteVerticalMargin, 0));
 }
@@ -562,12 +563,11 @@ CommandUpdater* OmniboxViewViews::GetCommandUpdater() {
 
 void OmniboxViewViews::SetInstantSuggestion(const string16& input,
                                             bool animate_to_complete) {
-  NOTIMPLEMENTED();
+  location_bar_view_->SetInstantSuggestion(input, animate_to_complete);
 }
 
 string16 OmniboxViewViews::GetInstantSuggestion() const {
-  NOTIMPLEMENTED();
-  return string16();
+  return location_bar_view_->GetInstantSuggestion();
 }
 
 int OmniboxViewViews::TextWidth() const {
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.h b/chrome/browser/ui/views/omnibox/omnibox_view_views.h
index ec9f3e5..5e51848 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.h
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.h
@@ -46,7 +46,7 @@ class OmniboxViewViews : public views::View,
                    Profile* profile,
                    CommandUpdater* command_updater,
                    bool popup_window_mode,
-                   views::View* location_bar);
+                   LocationBarView* location_bar);
   virtual ~OmniboxViewViews();
 
   // Initialize, create the underlying views, etc;
@@ -185,6 +185,7 @@ class OmniboxViewViews : public views::View,
 
   // Was the delete key pressed with an empty selection at the end of the edit?
   bool delete_at_end_pressed_;
+  LocationBarView* location_bar_view_;
 
   DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews);
 };
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index cb8989e..b0c6b2f 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -4787,6 +4787,8 @@
                 ['include', '^browser/ui/views/location_bar/page_action_with_badge_view.h'],
                 ['include', '^browser/ui/views/location_bar/selected_keyword_view.cc'],
                 ['include', '^browser/ui/views/location_bar/selected_keyword_view.h'],
+                ['include', '^browser/ui/views/location_bar/suggested_text_view.cc'],
+                ['include', '^browser/ui/views/location_bar/suggested_text_view.h'],
                 ['include', '^browser/ui/views/location_bar/star_view.cc'],
                 ['include', '^browser/ui/views/location_bar/star_view.h'],
                 ['include', '^browser/ui/views/notifications/balloon_view.cc'],